MIME-Version: 1.0
From: Chao Li <li.evan.chao@gmail.com>
Date: Thu, 25 Dec 2025 11:12:07 +0800
Message-ID: 
 <CAEoWx2m1Vo97Jg9=K7JAZ0xdkg5D=GkgOxZR1=EW7mUfy008fw@mail.gmail.com>
Subject: Trivial Fix: use palloc_array/repalloc_array for BufFile file arrays
To: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000015c5d90646be2584"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEoWx2m1Vo97Jg9%3DK7JAZ0xdkg5D%3DGkgOxZR1%3DEW7mUfy008fw%40mail.gmail.com>
Precedence: bulk

--00000000000015c5d90646be2584
Content-Type: multipart/alternative; boundary="00000000000015c5d80646be2582"

--00000000000015c5d80646be2582
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Hackers,

I noticed this error while working on [1].

In BufFile, the fields is claimed as an array:
```
struct BufFile
{
    File *files; /* palloc'd array with numFiles entries */
```

However, it=E2=80=99s allocated by palloc_object():
```
file->files =3D palloc_object(File);
```

And reallocated by repalloc():
```
    file->files =3D (File *) repalloc(file->files,
        (file->numFiles + 1) * sizeof(File));
```

This trivial patch just changes to use palloc_array/repalloc_array, which
makes the intent clearer.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

--00000000000015c5d80646be2582
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"auto" style=3D"line-break:after-white-space"><=
div>Hi Hackers,</div><div><br></div><div>I noticed this error while working=
 on [1].</div><div><br></div><div>In BufFile, the fields is claimed as an a=
rray:</div><div>```</div><div>struct BufFile<br>{</div><div>=C2=A0 =C2=A0 F=
ile       *files;          /* palloc&#39;d array with numFiles entries */<b=
r></div><div>```</div><div><br></div><div>However, it=E2=80=99s allocated b=
y palloc_object():</div><div>```</div><div>file-&gt;files =3D palloc_object=
(File);</div><div>```</div><div><br></div><div>And reallocated by repalloc(=
):</div><div>```</div><div>=C2=A0 =C2=A0 file-&gt;files =3D (File *) repall=
oc(file-&gt;files,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 (file-&gt;numFiles + 1) *=
 sizeof(File));</div><div>```</div><div><br></div><div>This trivial patch j=
ust changes to use=C2=A0palloc_array/repalloc_array, which makes the intent=
 clearer.</div><div><br></div>Best regards,<br><div id=3D"m_-42740990356575=
26536AppleMailSignature">
--<br>Chao Li (Evan)<br>HighGo Software Co., Ltd.<br><a href=3D"https://www=
.highgo.com/" target=3D"_blank">https://www.highgo.com/</a><br><br><br><br>

</div>
<br></div></div>

--00000000000015c5d80646be2582--

--00000000000015c5d90646be2584
Content-Type: application/octet-stream;
	name="v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch"
Content-Disposition: attachment;
	filename="v1-0001-Use-palloc_array-repalloc_array-for-BufFile-file-.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mjkv8sjb0>
X-Attachment-Id: f_mjkv8sjb0

RnJvbSBkMWE5MmM0YWVhZDg5ZTI3ZTRkZmQ1Yzg5MjM2NWE3YTg5NzNmNWRiIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQ2hhbyBMaSAoRXZhbikiIDxsaWNAaGlnaGdvLmNvbT4KRGF0
ZTogVGh1LCAyNSBEZWMgMjAyNSAxMTowMDoyNiArMDgwMApTdWJqZWN0OiBbUEFUQ0ggdjFdIFVz
ZSBwYWxsb2NfYXJyYXkvcmVwYWxsb2NfYXJyYXkgZm9yIEJ1ZkZpbGUgZmlsZSBhcnJheXMKCk5v
IGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLgoKQXV0aG9yOiBDaGFvIExpIDxsaWNAaGlnaGdv
LmNvbT4KLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL2ZpbGUvYnVmZmlsZS5jIHwgMTAgKysrKy0t
LS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRp
ZmYgLS1naXQgYS9zcmMvYmFja2VuZC9zdG9yYWdlL2ZpbGUvYnVmZmlsZS5jIGIvc3JjL2JhY2tl
bmQvc3RvcmFnZS9maWxlL2J1ZmZpbGUuYwppbmRleCA4NWIzMTZkODc5ZC4uYzlkNWFjOGM5OTMg
MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvZmlsZS9idWZmaWxlLmMKKysrIGIvc3Jj
L2JhY2tlbmQvc3RvcmFnZS9maWxlL2J1ZmZpbGUuYwpAQCAtMTQwLDcgKzE0MCw3IEBAIG1ha2VC
dWZGaWxlKEZpbGUgZmlyc3RmaWxlKQogewogCUJ1ZkZpbGUgICAgKmZpbGUgPSBtYWtlQnVmRmls
ZUNvbW1vbigxKTsKIAotCWZpbGUtPmZpbGVzID0gcGFsbG9jX29iamVjdChGaWxlKTsKKwlmaWxl
LT5maWxlcyA9IHBhbGxvY19hcnJheShGaWxlLCAxKTsKIAlmaWxlLT5maWxlc1swXSA9IGZpcnN0
ZmlsZTsKIAlmaWxlLT5yZWFkT25seSA9IGZhbHNlOwogCWZpbGUtPmZpbGVzZXQgPSBOVUxMOwpA
QCAtMTcxLDggKzE3MSw3IEBAIGV4dGVuZEJ1ZkZpbGUoQnVmRmlsZSAqZmlsZSkKIAogCUN1cnJl
bnRSZXNvdXJjZU93bmVyID0gb2xkb3duZXI7CiAKLQlmaWxlLT5maWxlcyA9IChGaWxlICopIHJl
cGFsbG9jKGZpbGUtPmZpbGVzLAotCQkJCQkJCQkJKGZpbGUtPm51bUZpbGVzICsgMSkgKiBzaXpl
b2YoRmlsZSkpOworCWZpbGUtPmZpbGVzID0gcmVwYWxsb2NfYXJyYXkoZmlsZS0+ZmlsZXMsIEZp
bGUsIGZpbGUtPm51bUZpbGVzICsgMSk7CiAJZmlsZS0+ZmlsZXNbZmlsZS0+bnVtRmlsZXNdID0g
cGZpbGU7CiAJZmlsZS0+bnVtRmlsZXMrKzsKIH0KQEAgLTI3MSw3ICsyNzAsNyBAQCBCdWZGaWxl
Q3JlYXRlRmlsZVNldChGaWxlU2V0ICpmaWxlc2V0LCBjb25zdCBjaGFyICpuYW1lKQogCWZpbGUg
PSBtYWtlQnVmRmlsZUNvbW1vbigxKTsKIAlmaWxlLT5maWxlc2V0ID0gZmlsZXNldDsKIAlmaWxl
LT5uYW1lID0gcHN0cmR1cChuYW1lKTsKLQlmaWxlLT5maWxlcyA9IHBhbGxvY19vYmplY3QoRmls
ZSk7CisJZmlsZS0+ZmlsZXMgPSBwYWxsb2NfYXJyYXkoRmlsZSwgMSk7CiAJZmlsZS0+ZmlsZXNb
MF0gPSBNYWtlTmV3RmlsZVNldFNlZ21lbnQoZmlsZSwgMCk7CiAJZmlsZS0+cmVhZE9ubHkgPSBm
YWxzZTsKIApAQCAtOTEwLDggKzkwOSw3IEBAIEJ1ZkZpbGVBcHBlbmQoQnVmRmlsZSAqdGFyZ2V0
LCBCdWZGaWxlICpzb3VyY2UpCiAJaWYgKHRhcmdldC0+cmVzb3duZXIgIT0gc291cmNlLT5yZXNv
d25lcikKIAkJZWxvZyhFUlJPUiwgImNvdWxkIG5vdCBhcHBlbmQgQnVmRmlsZSB3aXRoIG5vbi1t
YXRjaGluZyByZXNvdXJjZSBvd25lciIpOwogCi0JdGFyZ2V0LT5maWxlcyA9IChGaWxlICopCi0J
CXJlcGFsbG9jKHRhcmdldC0+ZmlsZXMsIHNpemVvZihGaWxlKSAqIG5ld051bUZpbGVzKTsKKwl0
YXJnZXQtPmZpbGVzID0gcmVwYWxsb2NfYXJyYXkodGFyZ2V0LT5maWxlcywgRmlsZSwgbmV3TnVt
RmlsZXMpOwogCWZvciAoaSA9IHRhcmdldC0+bnVtRmlsZXM7IGkgPCBuZXdOdW1GaWxlczsgaSsr
KQogCQl0YXJnZXQtPmZpbGVzW2ldID0gc291cmNlLT5maWxlc1tpIC0gdGFyZ2V0LT5udW1GaWxl
c107CiAJdGFyZ2V0LT5udW1GaWxlcyA9IG5ld051bUZpbGVzOwotLSAKMi4zOS41IChBcHBsZSBH
aXQtMTU0KQoK
--00000000000015c5d90646be2584--