MIME-Version: 1.0
References: 
 <CAEqnbaUthOQARV1dscGvB_EsqC-YfxiM6rWkVDHc+G+f4oSUHw@mail.gmail.com>
 <CAHut+PvizcpeHA1Twf_hwe=wANQ1LV5zY6_q+39gTFJc7+bCKg@mail.gmail.com>
In-Reply-To: 
 <CAHut+PvizcpeHA1Twf_hwe=wANQ1LV5zY6_q+39gTFJc7+bCKg@mail.gmail.com>
From: Gyan Sreejith <gyan.sreejith@gmail.com>
Date: Thu, 11 Dec 2025 20:33:15 -0500
Message-ID: 
 <CAEqnbaVNZYbB_YufchM49d=XC1ZGrVV8ikCPmGotWoCZASY3Uw@mail.gmail.com>
Subject: Re: [Proposal] Adding Log File Capability to pg_createsubscriber
To: Peter Smith <smithpb2250@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org, vignesh C <vignesh21@gmail.com>
Content-Type: multipart/alternative; boundary="0000000000007de05e0645b73ff4"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEqnbaVNZYbB_YufchM49d%3DXC1ZGrVV8ikCPmGotWoCZASY3Uw%40mail.gmail.com>
Precedence: bulk

--0000000000007de05e0645b73ff4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks for the feedback, Peter.

I am currently working on the SGML docs update, and will promptly get back
with an update.

For your second point, currently, all output goes directly to the console.
I thought it made more sense to break it up into multiple files depending
on what was being invoked. Do you have another opinion?

Thank you once again,
Gyan Sreejith

On Thu, Dec 11, 2025 at 2:29=E2=80=AFAM Peter Smith <smithpb2250@gmail.com>=
 wrote:

> On Wed, Dec 10, 2025 at 9:17=E2=80=AFAM Gyan Sreejith <gyan.sreejith@gmai=
l.com>
> wrote:
> >
> > Background:
> >
> > pg_createsubscriber currently outputs all messages (internal validation
> messages, standby server start/stop logs, recovery progress output, and
> output from utilities) directly to the console. As a result, users may fi=
nd
> debugging and handling errors difficult. It would be more convenient if
> messages were separated and stored in different log files. There is alrea=
dy
> a similar implementation in pg_upgrade.
> >
> > Proposed Solution:
> >
> > Based on issues mentioned previously, I would like to propose a new
> argument -l <logdir> which can be specified for pg_createsubscriber. Usin=
g
> it would create the following log files:
> >
> > logdir/pg_createsubscriber_server.log which captures all logs related t=
o
> starting and stopping the standby server.
> >
> > logdir/pg_createsubscriber_resetwal.log which captures the output of
> pg_resetwal
> >
> > logdir/pg_createsubscriber_internal.log which captures internal
> diagnostic output from pg_createsubscriber (validations, checks, etc.)
> >
> > Overall, this proposed solution could make the pg_createsubscriber
> command output messages more organized. The command would be easier to us=
e
> as users will only have to read individual log files rather than parse
> through lots of possibly irrelevant output messages. I have attached the
> patch for this change.
> >
> > Special thanks to Vignesh C. for his offlist guidance on this project.
> >
> >
> > Regards, Gyan Sreejith
> >
>
> Hi Gyan.
>
> I haven't yet looked at this patch in any detail, but here are some
> quick comments:
>
> =3D=3D=3D=3D=3D=3D
>
> 1.
> + printf(_("  -l, --logdir=3DLOGDIR             location for the new log
> directory\n"));
>
> The patch is missing SGML docs updates for pg_createsubscriber new
> option, and any explanation of the split of logfiles.
>
> 2.
> I might be mistaken, but IIUC it seems the splitting of the logfile
> only works when --logdir is specified. Is that correct?
> Why should --logdir have any side-effect other than assigning the log
> destination folder?
>
> =3D=3D=3D=3D=3D=3D
> Kind Regards,
> Peter Smith.
> Fujitsu Australia
>

--0000000000007de05e0645b73ff4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Thanks for the feedback, Peter.<br><br>I am currently work=
ing on the SGML docs update, and will promptly get back with an update.=C2=
=A0<div><br></div><div>For your second point, currently, all output goes=C2=
=A0directly to the console. I thought it made more sense to break it up int=
o multiple files depending on what was being invoked. Do you have another o=
pinion?=C2=A0<br><br>Thank you once again,<br>Gyan Sreejith</div></div><br>=
<div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Thu, De=
c 11, 2025 at 2:29=E2=80=AFAM Peter Smith &lt;<a href=3D"mailto:smithpb2250=
@gmail.com" target=3D"_blank">smithpb2250@gmail.com</a>&gt; wrote:<br></div=
><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border=
-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Dec 10, 2025 at =
9:17=E2=80=AFAM Gyan Sreejith &lt;<a href=3D"mailto:gyan.sreejith@gmail.com=
" target=3D"_blank">gyan.sreejith@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Background:<br>
&gt;<br>
&gt; pg_createsubscriber currently outputs all messages (internal validatio=
n messages, standby server start/stop logs, recovery progress output, and o=
utput from utilities) directly to the console. As a result, users may find =
debugging and handling errors difficult. It would be more convenient if mes=
sages were separated and stored in different log files. There is already a =
similar implementation in pg_upgrade.<br>
&gt;<br>
&gt; Proposed Solution:<br>
&gt;<br>
&gt; Based on issues mentioned previously, I would like to propose a new ar=
gument -l &lt;logdir&gt; which can be specified for pg_createsubscriber. Us=
ing it would create the following log files:<br>
&gt;<br>
&gt; logdir/pg_createsubscriber_server.log which captures all logs related =
to starting and stopping the standby server.<br>
&gt;<br>
&gt; logdir/pg_createsubscriber_resetwal.log which captures the output of p=
g_resetwal<br>
&gt;<br>
&gt; logdir/pg_createsubscriber_internal.log which captures internal diagno=
stic output from pg_createsubscriber (validations, checks, etc.)<br>
&gt;<br>
&gt; Overall, this proposed solution could make the pg_createsubscriber com=
mand output messages more organized. The command would be easier to use as =
users will only have to read individual log files rather than parse through=
 lots of possibly irrelevant output messages. I have attached the patch for=
 this change.<br>
&gt;<br>
&gt; Special thanks to Vignesh C. for his offlist guidance on this project.=
<br>
&gt;<br>
&gt;<br>
&gt; Regards, Gyan Sreejith<br>
&gt;<br>
<br>
Hi Gyan.<br>
<br>
I haven&#39;t yet looked at this patch in any detail, but here are some<br>
quick comments:<br>
<br>
=3D=3D=3D=3D=3D=3D<br>
<br>
1.<br>
+ printf(_(&quot;=C2=A0 -l, --logdir=3DLOGDIR=C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0location for the new log<br>
directory\n&quot;));<br>
<br>
The patch is missing SGML docs updates for pg_createsubscriber new<br>
option, and any explanation of the split of logfiles.<br>
<br>
2.<br>
I might be mistaken, but IIUC it seems the splitting of the logfile<br>
only works when --logdir is specified. Is that correct?<br>
Why should --logdir have any side-effect other than assigning the log<br>
destination folder?<br>
<br>
=3D=3D=3D=3D=3D=3D<br>
Kind Regards,<br>
Peter Smith.<br>
Fujitsu Australia<br>
</blockquote></div>

--0000000000007de05e0645b73ff4--