Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tAuL5-000nDh-E2 for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Nov 2024 17:06:02 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tAuL1-008Oar-QZ for pgsql-hackers@arkaria.postgresql.org; Tue, 12 Nov 2024 17:06:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tAuL1-008Oaj-Eo for pgsql-hackers@lists.postgresql.org; Tue, 12 Nov 2024 17:06:00 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1tAuKv-001WD2-Jw for pgsql-hackers@postgresql.org; Tue, 12 Nov 2024 17:05:58 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2e2d1858cdfso4503843a91.1 for ; Tue, 12 Nov 2024 09:05:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731431152; x=1732035952; darn=postgresql.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=r0uikGfSx0SmgDbKmQhiW+zT5XVQA8j0mVcrF1j/yjA=; b=nRzmog5dYGl6mcZC00G5TadlaQeoFEwEaiv6tSPCbTkPy1S+z5kKS15oYZhD3OqveD 5p9D1TjP5UuvxEC3ROjtCAWUW3MRhWNJ7ZCHyI05A3v3WD/mal9vWuJBS1fAYtZgUucI 569pjw747rNhy0XuqqzqzHDz2A4xCNB0QL5TZ0vqdJKuy3EiP3WkzB7SPM79iHjSsk0M UJf1E7WaItA5fv/+cS25dn566qNyfAwNEd63HgvTodw0T5Rd5yVD93yw73g8eIjtirHr ymx/RDfpJ92duLP+Zzt0BgpKBZKkMqa8mgYze5G8nTVhoFA1utYHwdGl74DXO5TDHYXP SMKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731431152; x=1732035952; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=r0uikGfSx0SmgDbKmQhiW+zT5XVQA8j0mVcrF1j/yjA=; b=FXjYh561JsOtsWRxkQ99s1sLIYwC/8/Tb2aXeCkeep6Mg75tIk/FzlDUJjcOfce+3Y uOQoamUaGeJlyhP1KsGo8yhF/wfE8EPB8gilOxEAxvMLALkSs0FSXxMLemA7EHp93dYj KlmbqqSC1Fk/DhaZ/qRCDFoqgsqnofmRSn0cE3XpFzEvIS9wsHe+jNf/u/0cNB4NeU1q aNH+1lpi7m7dTB1wkMiQByq9Tk5qSJtSdVBeYappzotwFQss1gEWQAVi2AfhrQBDkyf6 hVAMlrHpl+FKAahCMwCh1m4vIIgzr1jLMYvZfyQKfTRR9bJMWu6/NISnQJFzNGWdYlom oiZw== X-Gm-Message-State: AOJu0YxwcNbXTBX9/48BTIqJ08BuIGAjJJzqWS+VNDgNnrOcxV4+FKzt 3xs3c7y06jQfThvX/xuGtHoxOxSe3yO87fzdvlv3frHgsu3AzloybltYKsVOPTUBr/u+R3milj5 JZVwEFcddD22GLzJtXg05nz+rw5Ebw+Wa X-Google-Smtp-Source: AGHT+IG4QTrKG5eIHog25ngPqjhZxk3kDGwxIqv7HYxEmoATtczoFQHsJJztAXHQGFwbYKgDPdYWXLrbplAowZopNBA= X-Received: by 2002:a17:90b:388f:b0:2e2:cd62:549c with SMTP id 98e67ed59e1d1-2e9b17412a3mr26304999a91.22.1731431151839; Tue, 12 Nov 2024 09:05:51 -0800 (PST) MIME-Version: 1.0 From: Ranier Vilela Date: Tue, 12 Nov 2024 14:05:40 -0300 Message-ID: Subject: Fix array access (src/bin/pg_dump/pg_dump.c) To: Pg Hackers Content-Type: multipart/mixed; boundary="000000000000c267260626ba3a46" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000c267260626ba3a46 Content-Type: multipart/alternative; boundary="000000000000c267250626ba3a44" --000000000000c267250626ba3a44 Content-Type: text/plain; charset="UTF-8" Hi. Per Coverity. The function *determineNotNullFlags* has a little oversight. The struct field *notnull_islocal* is an array. I think this is a simple typo. Fix using array notation access. Trivial patch attached. best regards, Ranier Vilela --000000000000c267250626ba3a44 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi.

Per Coverity.
=
The function *determineNotNullFlags* has a little oversight.=
The struct field *notnull_islocal* is an array.

I think this is a simple typo.
Fix using arra= y notation access.

Trivial patch attached.

best regards,
Ranier Vilela

<= /div>
--000000000000c267250626ba3a44-- --000000000000c267260626ba3a46 Content-Type: application/octet-stream; name="fix_array_access_pg_dump.patch" Content-Disposition: attachment; filename="fix_array_access_pg_dump.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_m3epdr2t0 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19kdW1wLmMgYi9zcmMvYmluL3BnX2R1bXAv cGdfZHVtcC5jCmluZGV4IGE4YzE0MWI2ODkuLjQwNGY1ZDg2NzUgMTAwNjQ0Ci0tLSBhL3NyYy9i aW4vcGdfZHVtcC9wZ19kdW1wLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX2R1bXAuYwpAQCAt OTM5Nyw3ICs5Mzk3LDcgQEAgZGV0ZXJtaW5lTm90TnVsbEZsYWdzKEFyY2hpdmUgKmZvdXQsIFBH cmVzdWx0ICpyZXMsIGludCByLAogCQkJICovCiAJCQlpZiAoZG9wdC0+YmluYXJ5X3VwZ3JhZGUg JiYKIAkJCQkhdGJpbmZvLT5pc3BhcnRpdGlvbiAmJgotCQkJCSF0YmluZm8tPm5vdG51bGxfaXNs b2NhbCkKKwkJCQkhdGJpbmZvLT5ub3RudWxsX2lzbG9jYWxbal0pCiAJCQl7CiAJCQkJdGJpbmZv LT5ub3RudWxsX2NvbnN0cnNbal0gPQogCQkJCQlwc3RyZHVwKFBRZ2V0dmFsdWUocmVzLCByLCBp X25vdG51bGxfbmFtZSkpOwo= --000000000000c267260626ba3a46--