MIME-Version: 1.0
References: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
 <a984fb94-0694-4b70-9fbb-8562acb4e8f1@gmail.com>
In-Reply-To: <a984fb94-0694-4b70-9fbb-8562acb4e8f1@gmail.com>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Mon, 16 Mar 2026 11:18:54 -0300
Message-ID: 
 <CAEudQAoBPKbb3XX1H8SV95BOyJYL5SjH2D7CHKgDFBXWeSg9Lg@mail.gmail.com>
Subject: Re: Avoid resource leak (contrib/postgres_fdw/connection.c)
To: Matheus Alcantara <matheusssilv97@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000caea89064d24e673"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEudQAoBPKbb3XX1H8SV95BOyJYL5SjH2D7CHKgDFBXWeSg9Lg%40mail.gmail.com>
Precedence: bulk

--000000000000caea89064d24e673
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi.

Em seg., 16 de mar. de 2026 =C3=A0s 11:16, Matheus Alcantara <
matheusssilv97@gmail.com> escreveu:

> On 16/03/26 08:45, Ranier Vilela wrote:
> > Hi.
> >
> > Per Coverity.
> >
> > CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)
> > 8. leaked_storage: Variable str going out of scope leaks the storage
> > str.data points to.
> >
> > The function *postgres_fdw_connection* leaks the contents of
> > var str.data
> > Once that function *cstring_to_text* palloc the contents
> > must be necessary to free the var str.data.
> >
> > patch attached.
> >
>
> Hi,
>
> Thanks for the patch, it looks correct to me. I've searched for this
> pattern `PG_RETURN_TEXT_P(cstring_to_text(.*.data` in other places and
> I've just found on postgres_fdw/connection.c
>
> I've also search for other cases of `return cstring_to_text(...)`
> usages and I didn't found anything that seems suspicious.
>
> Tests are also passing.
>
Thanks for taking a look.

best regards,
Ranier Vilela

--000000000000caea89064d24e673
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi.</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">Em seg., 16 de mar. de 2026 =
=C3=A0s 11:16, Matheus Alcantara &lt;<a href=3D"mailto:matheusssilv97@gmail=
.com">matheusssilv97@gmail.com</a>&gt; escreveu:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">On 16/03/26 08:45, Ranier Vilela wrote:<br=
>
&gt; Hi.<br>
&gt; <br>
&gt; Per Coverity.<br>
&gt; <br>
&gt; CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)<br>
&gt; 8. leaked_storage: Variable str going out of scope leaks the storage<b=
r>
&gt; str.data points to.<br>
&gt; <br>
&gt; The function *postgres_fdw_connection* leaks the contents of<br>
&gt; var str.data<br>
&gt; Once that function *cstring_to_text* palloc the contents<br>
&gt; must be necessary to free the var str.data.<br>
&gt; <br>
&gt; patch attached.<br>
&gt; <br>
<br>
Hi,<br>
<br>
Thanks for the patch, it looks correct to me. I&#39;ve searched for this <b=
r>
pattern `PG_RETURN_TEXT_P(cstring_to_text(.*.data` in other places and <br>
I&#39;ve just found on postgres_fdw/connection.c<br>
<br>
I&#39;ve also search for other cases of `return cstring_to_text(...)` <br>
usages and I didn&#39;t found anything that seems suspicious.<br>
<br>
Tests are also passing.<br></blockquote><div>Thanks for taking a look.</div=
><div><br></div><div>best regards,</div><div>Ranier Vilela</div></div></div=
>

--000000000000caea89064d24e673--