MIME-Version: 1.0
References: <80b16434-b9b1-4c3d-8f28-569f21c2c102@app.fastmail.com>
 <CAEudQArAr+HiBsMA_mC2=S0ruHjn8123z2DHmyAnCN6j7yDvQQ@mail.gmail.com>
 <2c4c70ef-6567-4f5a-baa0-e16eb9430572@app.fastmail.com> <CAEudQApzU=q7ozYn-fKMBQYb44xkvurjKDZqzafM-qC1WCRLJA@mail.gmail.com>
In-Reply-To: <CAEudQApzU=q7ozYn-fKMBQYb44xkvurjKDZqzafM-qC1WCRLJA@mail.gmail.com>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Wed, 19 Jun 2024 10:51:32 -0300
Message-ID: <CAEudQAoZSHYJZAfzQK53666+RvXLTCtg3Fk0ww1WGv+vXah+yw@mail.gmail.com>
Subject: Re: Add pg_get_acl() function get the ACL for a database object
To: Joel Jacobson <joel@compiler.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000009fad60061b3e7f7e"
Archived-At: <https://www.postgresql.org/message-id/CAEudQAoZSHYJZAfzQK53666%2BRvXLTCtg3Fk0ww1WGv%2BvXah%2Byw%40mail.gmail.com>
Precedence: bulk

--0000000000009fad60061b3e7f7e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qua., 19 de jun. de 2024 =C3=A0s 10:28, Ranier Vilela <ranier.vf@gmail.c=
om>
escreveu:

> Em qua., 19 de jun. de 2024 =C3=A0s 10:26, Joel Jacobson <joel@compiler.o=
rg>
> escreveu:
>
>> Hi Ranier,
>>
>> Thanks for looking at this.
>>
>> I've double-checked the patch I sent, and it works fine.
>>
>> I think I know the cause of your problem:
>>
>> Since this is a catalog change, you need to run `make clean`, to ensure
>> the catalog is rebuilt,
>> followed by the usual `make && make install`.
>>
>> You also need to run `initdb` to create a new database cluster, with the
>> new catalog version.
>>
>> Let me know if you need more specific instructions.
>>
> Sorry, sorry but I'm on Windows -> meson.
>
> Double checked with:
> ninja clean
> ninja
> ninja install
>
Sorry for the noise, now pg_get_acl is shown in the regress test.

Regarding the patch, could it be written in the following style?

Datum
pg_get_acl(PG_FUNCTION_ARGS)
{
Oid classId =3D PG_GETARG_OID(0);
Oid objectId =3D PG_GETARG_OID(1);
Oid catalogId;
AttrNumber Anum_oid;
AttrNumber Anum_acl;

/* for "pinned" items in pg_depend, return null */
if (!OidIsValid(classId) && !OidIsValid(objectId))
PG_RETURN_NULL();

catalogId =3D (classId =3D=3D LargeObjectRelationId) ?
LargeObjectMetadataRelationId : classId;
Anum_oid =3D get_object_attnum_oid(catalogId);
Anum_acl =3D get_object_attnum_acl(catalogId);

if (Anum_acl !=3D InvalidAttrNumber)
{
Relation rel;
HeapTuple tup;
Datum datum;
bool isnull;

rel =3D table_open(catalogId, AccessShareLock);

tup =3D get_catalog_object_by_oid(rel, Anum_oid, objectId);
if (!HeapTupleIsValid(tup))
elog(ERROR, "cache lookup failed for object %u of catalog \"%s\"",
objectId, RelationGetRelationName(rel));

datum =3D heap_getattr(tup, Anum_acl, RelationGetDescr(rel), &isnull);

table_close(rel, AccessShareLock);

if (!isnull)
PG_RETURN_DATUM(datum);
}

PG_RETURN_NULL();
}

best regards,
Ranier Vilela

--0000000000009fad60061b3e7f7e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">Em qua., 19 de jun. de 2024 =C3=A0s 10:28, Ranier Vilela &lt;<a href=
=3D"mailto:ranier.vf@gmail.com">ranier.vf@gmail.com</a>&gt; escreveu:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div=
 class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">Em qua., 19 de=
 jun. de 2024 =C3=A0s 10:26, Joel Jacobson &lt;<a href=3D"mailto:joel@compi=
ler.org" target=3D"_blank">joel@compiler.org</a>&gt; escreveu:<br></div><bl=
ockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-lef=
t:1px solid rgb(204,204,204);padding-left:1ex">Hi Ranier,<br>
<br>
Thanks for looking at this.<br>
<br>
I&#39;ve double-checked the patch I sent, and it works fine.<br>
<br>
I think I know the cause of your problem:<br>
<br>
Since this is a catalog change, you need to run `make clean`, to ensure the=
 catalog is rebuilt,<br>
followed by the usual `make &amp;&amp; make install`.<br>
<br>
You also need to run `initdb` to create a new database cluster, with the ne=
w catalog version.<br>
<br>
Let me know if you need more specific instructions.<br></blockquote><div>So=
rry,=C2=A0sorry but I&#39;m on Windows -&gt; meson.</div><div><br></div><di=
v>Double checked with:</div><div>ninja clean</div><div>ninja</div><div>ninj=
a install</div></div></div></blockquote><div>Sorry for the noise, now pg_ge=
t_acl is shown in the regress test.</div><div><br></div><div>Regarding the =
patch, could it be written in the following style?</div><div><br></div><div=
>Datum<br>pg_get_acl(PG_FUNCTION_ARGS)<br>{<br>	Oid			classId =3D PG_GETARG=
_OID(0);<br>	Oid			objectId =3D PG_GETARG_OID(1);<br>	Oid			catalogId;<br>	=
AttrNumber	Anum_oid;<br>	AttrNumber	Anum_acl;<br><br>	/* for &quot;pinned&q=
uot; items in pg_depend, return null */<br>	if (!OidIsValid(classId) &amp;&=
amp; !OidIsValid(objectId))<br>		PG_RETURN_NULL();<br><br>	catalogId =3D (c=
lassId =3D=3D LargeObjectRelationId) ? LargeObjectMetadataRelationId : clas=
sId;<br>	Anum_oid =3D get_object_attnum_oid(catalogId);<br>	Anum_acl =3D ge=
t_object_attnum_acl(catalogId);<br><br>	if (Anum_acl !=3D InvalidAttrNumber=
)<br>	{<br>		Relation	rel;<br>		HeapTuple	tup;<br>		Datum		datum;<br>		bool=
		isnull;<br><br>		rel =3D table_open(catalogId, AccessShareLock);<br><br>	=
	tup =3D get_catalog_object_by_oid(rel, Anum_oid, objectId);<br>		if (!Heap=
TupleIsValid(tup))<br>			elog(ERROR, &quot;cache lookup failed for object %=
u of catalog \&quot;%s\&quot;&quot;,<br>				objectId, RelationGetRelationNa=
me(rel));<br><br>		datum =3D heap_getattr(tup, Anum_acl, RelationGetDescr(r=
el), &amp;isnull);<br><br>		table_close(rel, AccessShareLock);<br><br>		if =
(!isnull)<br>			PG_RETURN_DATUM(datum);<br>	}<br><br>	PG_RETURN_NULL();<br>=
}</div><div><br></div><div>best regards,</div><div>Ranier Vilela<br></div><=
/div></div>

--0000000000009fad60061b3e7f7e--