Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiudF-003hrd-1D for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Feb 2025 12:17:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tiudD-008ppp-2p for pgsql-hackers@arkaria.postgresql.org; Fri, 14 Feb 2025 12:17:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiudC-008plZ-Ow for pgsql-hackers@lists.postgresql.org; Fri, 14 Feb 2025 12:17:19 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tiudB-000lEm-2W for pgsql-hackers@lists.postgresql.org; Fri, 14 Feb 2025 12:17:18 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2fa5af6d743so3133098a91.3 for ; Fri, 14 Feb 2025 04:17:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739535437; x=1740140237; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=1QwnR0dbORllYo73kXKkJ3OL3H6LewXGcSop1uTCeNA=; b=TFcjfIdbE/HgYCcG8SQj5HeGQdOMGlIlyo8K1M/JnMaCI7aSRpGahGPRcv9r4Rz0Sg 903v9/8h4ykSTT9OKunYSWzK8pvmhjW8CvZLAkRVGD8Ri00cp1pQEuUpZ5yhnULUIIAZ UIKIKMgiF6YR3lmxttb8l4ZbnRKvnMyASeISPRZOpglJskxa98Vekpnz8ueVEw/IrIGT g856E3CFWnZL4r/MWCRHsmkoRrvSmh3wjfHc1kGUABY0NQRDyezSr0MHt4q2iOx8f7hw gij1h//AhkmtSRakTMYSR+TMyXkqvdB7JZhxVu/bF9Rp6ecNmyzfQiE77x6AHVhLYqOR /0nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739535437; x=1740140237; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1QwnR0dbORllYo73kXKkJ3OL3H6LewXGcSop1uTCeNA=; b=HocXMDSTuyDIO6ffxAeDH6elhQiA/+7oPClWioqdDlXjlAlMOT+U9dXOLHhEERF0dY V9jzZITQ8B5Xw7Yb6SNk2imDdXqLDSQL8ih/Xm8m9cRborGilY9AZ47pXWEKcxYA93Kt auNaKV/2cIlTb8gQ7XkrqGgheskGfhJejdQip+9LSSRks8H381ZM0eUl0qnIQr5pDIk/ aSrGTPBqGDtuYbuJNMBd3iqk7kelgZX2zHpJBbQVN118Kj8VpbgMXuBhIwYUasGHqqn7 GcBHiQIA4QnnCRvuX5c7ri9hu+QWj7PNQxfPs/PhqpauYl1TG9SL9hhaeYDqLNPLBbq9 AcsA== X-Forwarded-Encrypted: i=1; AJvYcCUCFHVF0sghsvYcHyZ+/TFcM1Ut4tWKV2zTYU+PiXAyIjO1BLFcgfBQgPavdXZFIsnBOvhYdHzBFNvAv4db@lists.postgresql.org X-Gm-Message-State: AOJu0YxwqHRCiI5BqpECGdrVO6PVUDNKWF59yYz5MU1Y2Jm9shKPmUMZ wT24EWP1uI5NJ5mvLuCnza122OTw4ZjbPhxm7SkZy9Icnk0VJAmCtYfpduVvV8I9zL4wqwkvJYH mH28UqrbnjjHGXg6ELogMJr9p4pQ= X-Gm-Gg: ASbGnct1BA4FQN1NqzzwH7dto5Gbl6baCZMc3IvNcRV4jR2lbnvK+O1bWBGuRm0aiW3 PTVSpqrORHRXocYlYhrqBQz4ropao5KRoOz+K9Du3ozJURn7t6OwZEKWEHvrmwIYKpQCScilI X-Google-Smtp-Source: AGHT+IExPQkQCQ52FLKDBOOpuzK6ICZmsNMHFH/kj65YvI1LJbGMN3vWoLdAyqbFDgVCLvzBh4h3Oxr5gHoA8OyTq08= X-Received: by 2002:a17:90b:4d10:b0:2ee:bf84:4fe8 with SMTP id 98e67ed59e1d1-2fc0f0db357mr9612899a91.30.1739535436772; Fri, 14 Feb 2025 04:17:16 -0800 (PST) MIME-Version: 1.0 References: <3718360.1739473209@sss.pgh.pa.us> In-Reply-To: <3718360.1739473209@sss.pgh.pa.us> From: Ranier Vilela Date: Fri, 14 Feb 2025 09:17:09 -0300 X-Gm-Features: AWEUYZmie7BX32MPblmqdBBbTIePTZj35X4Dzy7S5OMzRQiawC0f699qlEFpATk Message-ID: Subject: Re: pg17.3 PQescapeIdentifier() ignores len To: Tom Lane Cc: Justin Pryzby , pgsql-hackers@lists.postgresql.org Content-Type: multipart/alternative; boundary="000000000000c87fc5062e192748" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --000000000000c87fc5062e192748 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Em qui., 13 de fev. de 2025 =C3=A0s 16:00, Tom Lane esc= reveu: > Justin Pryzby writes: > > The fprintf suggests that since 5dc1e42b4 PQescapeIdentifier ignores it= s > len. > > Ugh, yes. Need something like the attached. > > FTR, 5dc1e42b4 et al were quite subtle patches done under extreme time > pressure. I wonder if they have any other issues. More eyes on those > patches would be welcome, now that they are public. > Passes on standard tests at Windows 64 bits, msvc 2022 64 bits. best regards, Ranier Vilela --000000000000c87fc5062e192748 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Em qui., 13 de fev. de 2025 =C3=A0s 16:00, To= m Lane <tgl@sss.pgh.pa.us> e= screveu:
Justin = Pryzby <pryzby= @telsasoft.com> writes:
> The fprintf suggests that since 5dc1e42b4 PQescapeIdentifier ignores i= ts len.

Ugh, yes.=C2=A0 Need something like the attached.

FTR, 5dc1e42b4 et al were quite subtle patches done under extreme time
pressure.=C2=A0 I wonder if they have any other issues.=C2=A0 More eyes on = those
patches would be welcome, now that they are public.
Pa= sses on standard tests at Windows 64 bits, msvc 2022 64 bits.
best regards,
Ranier Vilela
--000000000000c87fc5062e192748--