MIME-Version: 1.0
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Mon, 9 Mar 2026 10:16:20 -0300
Message-ID: 
 <CAEudQApbWon+3Eb9x4WW_D-JkSt2mvfx99dXu9VZ4AeCuTh=fw@mail.gmail.com>
Subject: Avoid multiple calls to memcpy (src/backend/access/index/genam.c)
To: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000fe7377064c9735f1"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEudQApbWon%2B3Eb9x4WW_D-JkSt2mvfx99dXu9VZ4AeCuTh%3Dfw%40mail.gmail.com>
Precedence: bulk

--000000000000fe7377064c9735f1
Content-Type: multipart/alternative; boundary="000000000000fe7376064c9735ef"

--000000000000fe7376064c9735ef
Content-Type: text/plain; charset="UTF-8"

Hi.

In the functions *systable_beginscan* and *systable_beginscan_ordered*,
is possible a small optimization.
The array *idxkey* can be constructed in one go with a single call to
mempcy.
The excess might not make much of a difference, but I think it's worth the
effort.

patch attached.

best regards,
Ranier Vilela

--000000000000fe7376064c9735ef
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi.</div><div><br></div><div>In the functions *systab=
le_beginscan* and *systable_beginscan_ordered*,</div><div>is possible a sma=
ll optimization.</div><div>The array *idxkey* can be constructed in one go =
with a single call to mempcy.</div><div>The excess might not make much of a=
 difference, but I think it&#39;s worth the effort.</div><div><br></div><di=
v>patch attached.</div><div><br></div><div>best regards,</div><div>Ranier V=
ilela</div></div>

--000000000000fe7376064c9735ef--

--000000000000fe7377064c9735f1
Content-Type: application/octet-stream;
	name="avoid-multiple-calls-to-memcpy-genam.patch"
Content-Disposition: attachment;
	filename="avoid-multiple-calls-to-memcpy-genam.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmj7cjcz0>
X-Attachment-Id: f_mmj7cjcz0

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9pbmRleC9nZW5hbS5jIGIvc3JjL2JhY2tl
bmQvYWNjZXNzL2luZGV4L2dlbmFtLmMKaW5kZXggNWU4OWI4NmE2Mi4uYWZmYWVkMmM0OCAxMDA2
NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2luZGV4L2dlbmFtLmMKKysrIGIvc3JjL2JhY2tl
bmQvYWNjZXNzL2luZGV4L2dlbmFtLmMKQEAgLTQzNSwxMyArNDM1LDEzIEBAIHN5c3RhYmxlX2Jl
Z2luc2NhbihSZWxhdGlvbiBoZWFwUmVsYXRpb24sCiAKIAkJaWR4a2V5ID0gcGFsbG9jX2FycmF5
KFNjYW5LZXlEYXRhLCBua2V5cyk7CiAKKwkJbWVtY3B5KGlkeGtleSwga2V5LCBua2V5cyAqIHNp
emVvZihTY2FuS2V5RGF0YSkpOworCiAJCS8qIENvbnZlcnQgYXR0cmlidXRlIG51bWJlcnMgdG8g
YmUgaW5kZXggY29sdW1uIG51bWJlcnMuICovCiAJCWZvciAoaSA9IDA7IGkgPCBua2V5czsgaSsr
KQogCQl7CiAJCQlpbnQJCQlqOwogCi0JCQltZW1jcHkoJmlkeGtleVtpXSwgJmtleVtpXSwgc2l6
ZW9mKFNjYW5LZXlEYXRhKSk7Ci0KIAkJCWZvciAoaiA9IDA7IGogPCBJbmRleFJlbGF0aW9uR2V0
TnVtYmVyT2ZBdHRyaWJ1dGVzKGlyZWwpOyBqKyspCiAJCQl7CiAJCQkJaWYgKGtleVtpXS5za19h
dHRubyA9PSBpcmVsLT5yZF9pbmRleC0+aW5ka2V5LnZhbHVlc1tqXSkKQEAgLTY4OCwxMyArNjg4
LDEzIEBAIHN5c3RhYmxlX2JlZ2luc2Nhbl9vcmRlcmVkKFJlbGF0aW9uIGhlYXBSZWxhdGlvbiwK
IAogCWlkeGtleSA9IHBhbGxvY19hcnJheShTY2FuS2V5RGF0YSwgbmtleXMpOwogCisJbWVtY3B5
KGlkeGtleSwga2V5LCBua2V5cyAqIHNpemVvZihTY2FuS2V5RGF0YSkpOworCiAJLyogQ29udmVy
dCBhdHRyaWJ1dGUgbnVtYmVycyB0byBiZSBpbmRleCBjb2x1bW4gbnVtYmVycy4gKi8KIAlmb3Ig
KGkgPSAwOyBpIDwgbmtleXM7IGkrKykKIAl7CiAJCWludAkJCWo7CiAKLQkJbWVtY3B5KCZpZHhr
ZXlbaV0sICZrZXlbaV0sIHNpemVvZihTY2FuS2V5RGF0YSkpOwotCiAJCWZvciAoaiA9IDA7IGog
PCBJbmRleFJlbGF0aW9uR2V0TnVtYmVyT2ZBdHRyaWJ1dGVzKGluZGV4UmVsYXRpb24pOyBqKysp
CiAJCXsKIAkJCWlmIChrZXlbaV0uc2tfYXR0bm8gPT0gaW5kZXhSZWxhdGlvbi0+cmRfaW5kZXgt
PmluZGtleS52YWx1ZXNbal0pCg==
--000000000000fe7377064c9735f1--