MIME-Version: 1.0
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Mon, 16 Mar 2026 08:45:49 -0300
Message-ID: 
 <CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg+1DGrag@mail.gmail.com>
Subject: Avoid resource leak (contrib/postgres_fdw/connection.c)
To: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000717f60064d22c3d5"
Archived-At: 
 <https://www.postgresql.org/message-id/CAEudQAprLegxufoi93JuFVkCDmjT5wtGhu3gxT-E1Fg%2B1DGrag%40mail.gmail.com>
Precedence: bulk

--000000000000717f60064d22c3d5
Content-Type: multipart/alternative; boundary="000000000000717f5f064d22c3d3"

--000000000000717f5f064d22c3d3
Content-Type: text/plain; charset="UTF-8"

Hi.

Per Coverity.

CID 1645716: (#1 of 1): Resource leak (RESOURCE_LEAK)
8. leaked_storage: Variable str going out of scope leaks the storage
str.data points to.

The function *postgres_fdw_connection* leaks the contents of
var str.data
Once that function *cstring_to_text* palloc the contents
must be necessary to free the var str.data.

patch attached.

best regards,
Ranier Vilelas

--000000000000717f5f064d22c3d3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi.</div><div><br></div><div>Per Coverity.</div><div>=
<br></div><div>
<span><div>

<span class=3D"gmail-defect-text">CID 1645716: (#1 of 1): Resource leak (RE=
SOURCE_LEAK)
</span></div><span class=3D"event-order">8.</span>
    <span class=3D"event-tag">leaked_storage:</span>
    <span class=3D"gmail-description">Variable str going out of scope leaks=
 the storage str.data points to.</span></span></div><div><br></div><div>The=
 function *postgres_fdw_connection* leaks the contents of</div><div>var str=
.data</div><div>Once that function *cstring_to_text* palloc the contents</d=
iv><div>must be necessary to free the var str.data.</div><div><br></div><di=
v>patch attached.</div><div><br></div><div>best regards,</div><div>Ranier V=
ilelas</div></div>

--000000000000717f5f064d22c3d3--

--000000000000717f60064d22c3d5
Content-Type: application/octet-stream;
	name="avoid-resource-leak-postgres_fdw-connection.patch"
Content-Disposition: attachment;
	filename="avoid-resource-leak-postgres_fdw-connection.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmt4955p0>
X-Attachment-Id: f_mmt4955p0

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcG9zdGdyZXNfZmR3L2Nvbm5lY3Rpb24uYyBiL2NvbnRyaWIv
cG9zdGdyZXNfZmR3L2Nvbm5lY3Rpb24uYwppbmRleCA3ZTJiODIyZDE2Li44N2YzZTM3MjdmIDEw
MDY0NAotLS0gYS9jb250cmliL3Bvc3RncmVzX2Zkdy9jb25uZWN0aW9uLmMKKysrIGIvY29udHJp
Yi9wb3N0Z3Jlc19mZHcvY29ubmVjdGlvbi5jCkBAIC0yMzU1LDYgKzIzNTUsNyBAQCBwb3N0Z3Jl
c19mZHdfY29ubmVjdGlvbihQR19GVU5DVElPTl9BUkdTKQogCUZvcmVpZ25TZXJ2ZXIgKnNlcnZl
ciA9IEdldEZvcmVpZ25TZXJ2ZXIoc2VydmVyaWQpOwogCVVzZXJNYXBwaW5nICp1c2VyID0gR2V0
VXNlck1hcHBpbmcodXNlcmlkLCBzZXJ2ZXJpZCk7CiAJU3RyaW5nSW5mb0RhdGEgc3RyOworCXRl
eHQJCSpyZXN1bHQ7CiAJY29uc3QgY2hhciAqKmtleXdvcmRzOwogCWNvbnN0IGNoYXIgKip2YWx1
ZXM7CiAJY2hhcgkgICAqYXBwbmFtZTsKQEAgLTIzNzEsMTIgKzIzNzIsMTUgQEAgcG9zdGdyZXNf
ZmR3X2Nvbm5lY3Rpb24oUEdfRlVOQ1RJT05fQVJHUykKIAkJYXBwZW5kRXNjYXBlZFZhbHVlKCZz
dHIsIHZhbHVlc1tpXSk7CiAJCXNlcCA9ICIgIjsKIAl9CisJcmVzdWx0ID0gY3N0cmluZ190b190
ZXh0KHN0ci5kYXRhKTsKIAogCWlmIChhcHBuYW1lICE9IE5VTEwpCiAJCXBmcmVlKGFwcG5hbWUp
OwogCXBmcmVlKGtleXdvcmRzKTsKIAlwZnJlZSh2YWx1ZXMpOwotCVBHX1JFVFVSTl9URVhUX1Ao
Y3N0cmluZ190b190ZXh0KHN0ci5kYXRhKSk7CisJcGZyZWUoc3RyLmRhdGEpOworCisJUEdfUkVU
VVJOX1RFWFRfUChyZXN1bHQpOwogfQogCiAvKgo=
--000000000000717f60064d22c3d5--