MIME-Version: 1.0
References: <cd24aa81-152e-4194-9bbe-0f34a0a3f539@dunslane.net>
 <202503311812.vxg5b7rzfgf6@alvherre.pgsql> <CAKYtNArtO8T-u5=E4ibxFfW+zQ8dBmOZQFgRa36+27NFkdtK0Q@mail.gmail.com>
 <616efe2c-3986-43cf-b88c-4435849acf9e@dunslane.net> <CAKYtNAoE1xUcMmBq-1qCaZGUDQLfMSVa6hzBVA-PqbmSTzPf5A@mail.gmail.com>
 <CAKYtNAq530UTAtnVs5xfONQ0j6vS-Sys50p5+SNfC7G7_ghCVQ@mail.gmail.com> <948154fe-0278-4f4c-8f5a-085e12f03163@dunslane.net>
In-Reply-To: <948154fe-0278-4f4c-8f5a-085e12f03163@dunslane.net>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Thu, 10 Apr 2025 15:38:18 -0300
Message-ID: <CAEudQApwQzpRB-0orH1L2vRhXvW6KXZWFjYqAfspS_SmOz-roQ@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>, 
	jian he <jian.universality@gmail.com>, Srinath Reddy <srinath2133@gmail.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/mixed; boundary="00000000000088b714063270e399"
Archived-At: <https://www.postgresql.org/message-id/CAEudQApwQzpRB-0orH1L2vRhXvW6KXZWFjYqAfspS_SmOz-roQ%40mail.gmail.com>
Precedence: bulk

--00000000000088b714063270e399
Content-Type: multipart/alternative; boundary="00000000000088b713063270e397"

--00000000000088b713063270e397
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi.

Em sex., 4 de abr. de 2025 =C3=A0s 17:11, Andrew Dunstan <andrew@dunslane.n=
et>
escreveu:

>
> On 2025-04-04 Fr 5:12 AM, Mahendra Singh Thalor wrote:
>
> On Fri, 4 Apr 2025 at 13:52, Mahendra Singh Thalor <mahi6run@gmail.com> <=
mahi6run@gmail.com> wrote:
>
> On Fri, 4 Apr 2025 at 01:17, Andrew Dunstan <andrew@dunslane.net> <andrew=
@dunslane.net> wrote:
>
> On 2025-04-01 Tu 1:59 AM, Mahendra Singh Thalor wrote:
>
> On Mon, 31 Mar 2025 at 23:43, =C3=81lvaro Herrera <alvherre@alvh.no-ip.or=
g> <alvherre@alvh.no-ip.org> wrote:
>
> Hi
>
> FWIW I don't think the on_exit_nicely business is in final shape just
> yet.  We're doing something super strange and novel about keeping track
> of an array index, so that we can modify it later.  Or something like
> that, I think?  That doesn't sound all that nice to me.  Elsewhere it
> was suggested that we need some way to keep track of the list of things
> that need cleanup (a list of connections IIRC?) -- perhaps in a
> thread-local variable or a global or something -- and we install the
> cleanup function once, and that reads from the variable.  The program
> can add things to the list, or remove them, at will; and we don't need
> to modify the cleanup function in any way.
>
> --
> =C3=81lvaro Herrera        Breisgau, Deutschland  =E2=80=94  https://www.=
EnterpriseDB.com/
>
> Thanks =C3=81lvaro for the feedback.
>
> I removed the old handling of on_exit_nicely_list from the last patch
> set and added one simple function to just update the archive handle in
> shutdown_info.  (shutdown_info.AHX =3D AHX;)
>
> For first database, we will add entry into on_exit_nicely_list array
> and for rest database, we will update only shutdown_info as we already
> closed connection for previous database.With this fix, we will not
> touch entry of on_exit_nicely_list for each database.
>
> Here, I am attaching updated patches.
>
>
> OK, looks good. here's my latest. I'm currently working on tidying up
> docco and comments.
>
>
> cheers
>
>
> andrew
>
>
>
>
> --
> Andrew Dunstan
> EDB: https://www.enterprisedb.com
>
> Thanks Andrew for the updated patches.
>
> Here, I am attaching a delta patch with some more TAP-test cases.
>
>
> Here, I am attaching an updated delta patch which has some more TAP
> tests. Please include these tests also. This patch can be applied on
> v20250403_0004* patch.
>
>
>
>
> Thanks. I have pushed these now with a few further small tweaks.
>
Sorry if it is not the right place.
Coverity has another resource leak alert.

trivial patch attached.

best regards,
Ranier Vilela

>

--00000000000088b713063270e397
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi.</div><br><div class=3D"gmail_quote gmail_quote_co=
ntainer"><div dir=3D"ltr" class=3D"gmail_attr">Em sex., 4 de abr. de 2025 =
=C3=A0s 17:11, Andrew Dunstan &lt;<a href=3D"mailto:andrew@dunslane.net">an=
drew@dunslane.net</a>&gt; escreveu:<br></div><blockquote class=3D"gmail_quo=
te" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204=
);padding-left:1ex"><u></u>

 =20
   =20
 =20
  <div>
    <p><br>
    </p>
    <div>On 2025-04-04 Fr 5:12 AM, Mahendra
      Singh Thalor wrote:<br>
    </div>
    <blockquote type=3D"cite">
      <pre>On Fri, 4 Apr 2025 at 13:52, Mahendra Singh Thalor <a href=3D"ma=
ilto:mahi6run@gmail.com" target=3D"_blank">&lt;mahi6run@gmail.com&gt;</a> w=
rote:
</pre>
      <blockquote type=3D"cite">
        <pre>On Fri, 4 Apr 2025 at 01:17, Andrew Dunstan <a href=3D"mailto:=
andrew@dunslane.net" target=3D"_blank">&lt;andrew@dunslane.net&gt;</a> wrot=
e:
</pre>
        <blockquote type=3D"cite">
          <pre>On 2025-04-01 Tu 1:59 AM, Mahendra Singh Thalor wrote:
</pre>
          <blockquote type=3D"cite">
            <pre>On Mon, 31 Mar 2025 at 23:43, =C3=81lvaro Herrera <a href=
=3D"mailto:alvherre@alvh.no-ip.org" target=3D"_blank">&lt;alvherre@alvh.no-=
ip.org&gt;</a> wrote:
</pre>
            <blockquote type=3D"cite">
              <pre>Hi

FWIW I don&#39;t think the on_exit_nicely business is in final shape just
yet.  We&#39;re doing something super strange and novel about keeping track
of an array index, so that we can modify it later.  Or something like
that, I think?  That doesn&#39;t sound all that nice to me.  Elsewhere it
was suggested that we need some way to keep track of the list of things
that need cleanup (a list of connections IIRC?) -- perhaps in a
thread-local variable or a global or something -- and we install the
cleanup function once, and that reads from the variable.  The program
can add things to the list, or remove them, at will; and we don&#39;t need
to modify the cleanup function in any way.

--
=C3=81lvaro Herrera        Breisgau, Deutschland  =E2=80=94  <a href=3D"htt=
ps://www.EnterpriseDB.com/" target=3D"_blank">https://www.EnterpriseDB.com/=
</a>
</pre>
            </blockquote>
            <pre>Thanks =C3=81lvaro for the feedback.

I removed the old handling of on_exit_nicely_list from the last patch
set and added one simple function to just update the archive handle in
shutdown_info.  (shutdown_info.AHX =3D AHX;)

For first database, we will add entry into on_exit_nicely_list array
and for rest database, we will update only shutdown_info as we already
closed connection for previous database.With this fix, we will not
touch entry of on_exit_nicely_list for each database.

Here, I am attaching updated patches.

</pre>
          </blockquote>
          <pre>OK, looks good. here&#39;s my latest. I&#39;m currently work=
ing on tidying up
docco and comments.


cheers


andrew


--
Andrew Dunstan
EDB: <a href=3D"https://www.enterprisedb.com" target=3D"_blank">https://www=
.enterprisedb.com</a>
</pre>
        </blockquote>
        <pre>Thanks Andrew for the updated patches.

Here, I am attaching a delta patch with some more TAP-test cases.

</pre>
      </blockquote>
      <pre>Here, I am attaching an updated delta patch which has some more =
TAP
tests. Please include these tests also. This patch can be applied on
v20250403_0004* patch.

</pre>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Thanks. I have pushed these now with a few further small tweaks.</p>=
</div></blockquote><div>Sorry if it is not the right place.</div><div>Cover=
ity has another resource leak alert.</div><div><br></div><div>trivial patch=
 attached.</div><div><br></div><div>best regards,</div><div>Ranier Vilela</=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
  </div>

</blockquote></div></div>

--00000000000088b713063270e397--
--00000000000088b714063270e399
Content-Type: application/octet-stream; 
	name="fix_resource_leak_pg_restore.patch"
Content-Disposition: attachment; 
	filename="fix_resource_leak_pg_restore.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m9bpb60z0>
X-Attachment-Id: f_m9bpb60z0

ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMgYi9zcmMvYmluL3BnX2R1
bXAvcGdfcmVzdG9yZS5jCmluZGV4IDA2YzI4YWIzMTQuLmViMzEwOWQ3MTkgMTAwNjQ0Ci0tLSBh
L3NyYy9iaW4vcGdfZHVtcC9wZ19yZXN0b3JlLmMKKysrIGIvc3JjL2Jpbi9wZ19kdW1wL3BnX3Jl
c3RvcmUuYwpAQCAtOTA1LDYgKzkwNSw3IEBAIHJlYWRfb25lX3N0YXRlbWVudChTdHJpbmdJbmZv
IGluQnVmLCBGSUxFICpwZmlsZSkKIAkJaWYgKGMgPT0gJ1xuJykKIAkJCWFwcGVuZFN0cmluZ0lu
Zm9DaGFyKGluQnVmLCAoY2hhcikgJ1xuJyk7CiAJfQorCWRlc3Ryb3lTdHJpbmdJbmZvKCZxKTsK
IAogCS8qIE5vIGlucHV0IGJlZm9yZSBFT0Ygc2lnbmFsIG1lYW5zIHRpbWUgdG8gcXVpdC4gKi8K
IAlpZiAoYyA9PSBFT0YgJiYgaW5CdWYtPmxlbiA9PSAwKQo=
--00000000000088b714063270e399--