public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ranier Vilela <[email protected]>
To: Tom Lane <[email protected]>
Cc: [email protected]
Subject: Re: New compiler warnings in buildfarm
Date: Tue, 30 Jul 2024 13:56:16 -0300
Message-ID: <CAEudQApxfgRjnwqUw=pyAB4pkL9pUrAVDwN4eNMBUVjaeVE0Fg@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
Em ter., 30 de jul. de 2024 às 13:19, Tom Lane <[email protected]> escreveu:
> Sometime in the last month or so, flaviventris's bleeding-edge
> version of gcc has started whining[1] about truncation of a
> string literal's implicit trailing '\0' in contexts like this:
>
> ../pgsql/src/backend/commands/copyto.c:106:41: warning: initializer-string
> for array of 'char' is too long [-Wunterminated-string-initialization]
> 106 | static const char BinarySignature[11] = "PGCOPY\n\377\r\n\0";
> | ^~~~~~~~~~~~~~~~~~~~
>
> ../pgsql/src/backend/utils/adt/numutils.c:29:1: warning:
> initializer-string for array of 'char' is too long
> [-Wunterminated-string-initialization]
> 29 | "00" "01" "02" "03" "04" "05" "06" "07" "08" "09"
> | ^~~~
>
> Presumably this'll appear in less-bleeding-edge releases in a
> few months' time.
>
> In the BinarySignature case, we could silence it in at least two ways.
> We could remove the explicit trailing \0 and rely on the implicit one:
>
> -static const char BinarySignature[11] = "PGCOPY\n\377\r\n\0";
> +static const char BinarySignature[11] = "PGCOPY\n\377\r\n";
>
> Or just drop the unnecessary array length specification:
>
+1 for dropping the length specification.
The trailing \0 the compiler will automatically fill in.
Note this came from copyfromparse.c, who also have the same problem.
best regards,
Ranier Vilela
view thread (3+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: Re: New compiler warnings in buildfarm
In-Reply-To: <CAEudQApxfgRjnwqUw=pyAB4pkL9pUrAVDwN4eNMBUVjaeVE0Fg@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox