MIME-Version: 1.0
References: <cd24aa81-152e-4194-9bbe-0f34a0a3f539@dunslane.net>
 <202503311812.vxg5b7rzfgf6@alvherre.pgsql> <CAKYtNArtO8T-u5=E4ibxFfW+zQ8dBmOZQFgRa36+27NFkdtK0Q@mail.gmail.com>
 <616efe2c-3986-43cf-b88c-4435849acf9e@dunslane.net> <CAKYtNAoE1xUcMmBq-1qCaZGUDQLfMSVa6hzBVA-PqbmSTzPf5A@mail.gmail.com>
 <CAKYtNAq530UTAtnVs5xfONQ0j6vS-Sys50p5+SNfC7G7_ghCVQ@mail.gmail.com>
 <948154fe-0278-4f4c-8f5a-085e12f03163@dunslane.net> <CAEudQApwQzpRB-0orH1L2vRhXvW6KXZWFjYqAfspS_SmOz-roQ@mail.gmail.com>
 <01134839-c4d7-4488-9026-eeac8f1d33ed@dunslane.net>
In-Reply-To: <01134839-c4d7-4488-9026-eeac8f1d33ed@dunslane.net>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Thu, 10 Apr 2025 18:45:42 -0300
Message-ID: <CAEudQAr45bfRTk0X1kLQbF6KPXqRyO-Cj_kF-uwkyp=zh-__MA@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@alvh.no-ip.org>, 
	jian he <jian.universality@gmail.com>, Srinath Reddy <srinath2133@gmail.com>, 
	pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="000000000000aafb62063273816b"
Archived-At: <https://www.postgresql.org/message-id/CAEudQAr45bfRTk0X1kLQbF6KPXqRyO-Cj_kF-uwkyp%3Dzh-__MA%40mail.gmail.com>
Precedence: bulk

--000000000000aafb62063273816b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qui., 10 de abr. de 2025 =C3=A0s 15:58, Andrew Dunstan <andrew@dunslane.=
net>
escreveu:

>
> On 2025-04-10 Th 2:38 PM, Ranier Vilela wrote:
>
>
>>
>> Thanks. I have pushed these now with a few further small tweaks.
>>
> Sorry if it is not the right place.
> Coverity has another resource leak alert.
>
> trivial patch attached.
>
>
>
>
> Thanks for checking. Pushed.
>
Andew, I think that the commit wasn't very correct.
Now the variable *q* is being destroyed inside the loop.

The patch was destroying the variable *q* (stringinfo),
after the loop while.

best regards,
Ranier Vilela

>

--000000000000aafb62063273816b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_quote gmail_quote_container"><div =
dir=3D"ltr" class=3D"gmail_attr">Em qui., 10 de abr. de 2025 =C3=A0s 15:58,=
 Andrew Dunstan &lt;<a href=3D"mailto:andrew@dunslane.net">andrew@dunslane.=
net</a>&gt; escreveu:<br></div><blockquote class=3D"gmail_quote" style=3D"m=
argin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left=
:1ex"><u></u>

 =20
   =20
 =20
  <div>
    <p><br>
    </p>
    <div>On 2025-04-10 Th 2:38 PM, Ranier Vilela
      wrote:<br>
    </div>
    <blockquote type=3D"cite">
     =20
      <div dir=3D"ltr">
        <div class=3D"gmail_quote">
          <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
            <div><br>
              <p><br>
              </p>
              <p>Thanks. I have pushed these now with a few further
                small tweaks.</p>
            </div>
          </blockquote>
          <div>Sorry if it is not the right place.</div>
          <div>Coverity has another resource leak alert.</div>
          <div><br>
          </div>
          <div>trivial patch attached.</div>
          <div><br>
          </div>
          <br>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>Thanks for checking. Pushed.</p></div></blockquote><div>Andew, I thi=
nk that the commit wasn&#39;t very correct. <br></div><div>Now the variable=
 *q* is being destroyed inside the loop.</div><div></div><div><br></div><di=
v>The patch was destroying the variable *q* (stringinfo),</div><div>after t=
he loop while.</div><div>=C2=A0</div><div>best regards,</div><div>Ranier Vi=
lela</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8=
ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>
  </div>

</blockquote></div></div>

--000000000000aafb62063273816b--