MIME-Version: 1.0
References: <CAEudQAqMeE0AHcOsOzZx51Z0eiFJAjhBPRFt+Bxi3ETXWen7ig@mail.gmail.com>
 <DB8C32CC-83B9-4441-9E6A-626890B5E7F6@yesql.se>
In-Reply-To: <DB8C32CC-83B9-4441-9E6A-626890B5E7F6@yesql.se>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Wed, 10 Apr 2024 15:31:02 -0300
Message-ID: <CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00+SkTjFNHSw@mail.gmail.com>
Subject: Re: Fix resource leak (src/backend/libpq/be-secure-common.c)
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000048a8e10615c23e51"
Archived-At: <https://www.postgresql.org/message-id/CAEudQArcwFzYdGcRk8Tyf2ij0DR7mOoqSJejsa00%2BSkTjFNHSw%40mail.gmail.com>
Precedence: bulk

--00000000000048a8e10615c23e51
Content-Type: multipart/alternative; boundary="00000000000048a8e00615c23e4f"

--00000000000048a8e00615c23e4f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em ter., 2 de abr. de 2024 =C3=A0s 15:31, Daniel Gustafsson <daniel@yesql.s=
e>
escreveu:

> > On 2 Apr 2024, at 20:13, Ranier Vilela <ranier.vf@gmail.com> wrote:
>
> > Fix by freeing the pointer, like pclose_check (src/common/exec.c)
> similar case.
>
> Off the cuff, seems reasonable when loglevel is LOG.
>

Per Coverity.

Another case of resource leak, when loglevel is LOG.
In the function shell_archive_file (src/backend/archive/shell_archive.c)
The pointer *xlogarchcmd*  is not freed.

best regards,
Ranier Vilela

--00000000000048a8e00615c23e4f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">Em ter., 2 de abr. de 2024 =C3=A0s 15:31, Daniel Gustafsson &lt;<a h=
ref=3D"mailto:daniel@yesql.se">daniel@yesql.se</a>&gt; escreveu:<br></div><=
blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-l=
eft:1px solid rgb(204,204,204);padding-left:1ex">&gt; On 2 Apr 2024, at 20:=
13, Ranier Vilela &lt;<a href=3D"mailto:ranier.vf@gmail.com" target=3D"_bla=
nk">ranier.vf@gmail.com</a>&gt; wrote:<br>
<br>
&gt; Fix by freeing the pointer, like pclose_check (src/common/exec.c) simi=
lar case.<br>
<br>
Off the cuff, seems reasonable when loglevel is LOG.<br></blockquote><br><d=
iv>Per Coverity.</div><div><br></div><div>
<div>Another case of resource leak, when loglevel is LOG.</div><div></div>

</div><div>In the function shell_archive_file (src/backend/archive/shell_ar=
chive.c)</div><div>The pointer *xlogarchcmd*=C2=A0 is not freed.<br></div><=
div><br></div><div>best regards,</div><div>Ranier Vilela</div></div></div>

--00000000000048a8e00615c23e4f--
--00000000000048a8e10615c23e51
Content-Type: application/octet-stream; 
	name="fix-resource-leak-shell_archive.patch"
Content-Disposition: attachment; 
	filename="fix-resource-leak-shell_archive.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_luu5brc10>
X-Attachment-Id: f_luu5brc10

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FyY2hpdmUvc2hlbGxfYXJjaGl2ZS5jIGIvc3JjL2Jh
Y2tlbmQvYXJjaGl2ZS9zaGVsbF9hcmNoaXZlLmMKaW5kZXggMDkyNTM0OGJmZS4uNTA2YzVhMzBh
ZCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYXJjaGl2ZS9zaGVsbF9hcmNoaXZlLmMKKysrIGIv
c3JjL2JhY2tlbmQvYXJjaGl2ZS9zaGVsbF9hcmNoaXZlLmMKQEAgLTEyNSw5ICsxMjUsMTEgQEAg
c2hlbGxfYXJjaGl2ZV9maWxlKEFyY2hpdmVNb2R1bGVTdGF0ZSAqc3RhdGUsIGNvbnN0IGNoYXIg
KmZpbGUsCiAJCQkJCSBlcnJkZXRhaWwoIlRoZSBmYWlsZWQgYXJjaGl2ZSBjb21tYW5kIHdhczog
JXMiLAogCQkJCQkJCSAgIHhsb2dhcmNoY21kKSkpOwogCQl9CisJCXBmcmVlKHhsb2dhcmNoY21k
KTsKIAogCQlyZXR1cm4gZmFsc2U7CiAJfQorCXBmcmVlKHhsb2dhcmNoY21kKTsKIAogCWVsb2co
REVCVUcxLCAiYXJjaGl2ZWQgd3JpdGUtYWhlYWQgbG9nIGZpbGUgXCIlc1wiIiwgZmlsZSk7CiAJ
cmV0dXJuIHRydWU7
--00000000000048a8e10615c23e51--