MIME-Version: 1.0
References: <CAEudQAqjqkXXsjdKpmi=ry+JCfaKrFJO9NF1bP5CrtvZwh0uHg@mail.gmail.com>
In-Reply-To: <CAEudQAqjqkXXsjdKpmi=ry+JCfaKrFJO9NF1bP5CrtvZwh0uHg@mail.gmail.com>
From: Ranier Vilela <ranier.vf@gmail.com>
Date: Sat, 30 Dec 2023 10:40:11 -0300
Message-ID: <CAEudQArx03C3x2UDKjTrknFsxYmx3Bu+A6yyi59y1NRFi2s3xQ@mail.gmail.com>
Subject: Re: Windows sockets (select missing events?)
To: Pg Hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000006382ea060dba4a54"
Archived-At: <https://www.postgresql.org/message-id/CAEudQArx03C3x2UDKjTrknFsxYmx3Bu%2BA6yyi59y1NRFi2s3xQ%40mail.gmail.com>
Precedence: bulk

--0000000000006382ea060dba4a54
Content-Type: multipart/alternative; boundary="0000000000006382e8060dba4a52"

--0000000000006382e8060dba4a52
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Em qui., 28 de dez. de 2023 =C3=A0s 14:45, Ranier Vilela <ranier.vf@gmail.c=
om>
escreveu:

> Hi,
>
> The type of field fd_count is defined in winsock.h:
> typedef unsigned int    u_int;
>
> So in the struct fd_set,
> the field fd_count is unsigned int.
>
> The pgwin32_select  function has loops that use *int* as indices.
>
> Question: in Windows, the socket select function isn't missing some event=
s?
>
> If not, It would be a good prevention practice, using the correct type,
> right?
>
> Patch attached.
>
Fix overflow with patch.

best regards,
Ranier Vilela

--0000000000006382e8060dba4a52
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail=
_attr">Em qui., 28 de dez. de 2023 =C3=A0s 14:45, Ranier Vilela &lt;<a href=
=3D"mailto:ranier.vf@gmail.com">ranier.vf@gmail.com</a>&gt; escreveu:<br></=
div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div=
>Hi,</div><div><br></div><div>The type of field fd_count is defined in wins=
ock.h:</div><div>typedef unsigned int =C2=A0 =C2=A0u_int;</div><div><br></d=
iv><div>So in the struct fd_set,<br></div><div>the field fd_count is unsign=
ed int.</div><div><br></div>The=20
pgwin32_select=C2=A0 function has loops that use *int* as indices.<div><br>=
</div><div>Question: in Windows, the socket select function isn&#39;t missi=
ng some events?</div><div>=C2=A0</div><div>If not, It would be a good preve=
ntion practice, using the correct type, right?</div><div><br></div><div>Pat=
ch attached.</div></div></blockquote><div>Fix overflow with patch.</div><di=
v><br></div><div>best regards,</div><div>Ranier Vilela</div></div></div>

--0000000000006382e8060dba4a52--
--0000000000006382ea060dba4a54
Content-Type: application/octet-stream; 
	name="v1-001-fix-socket-select-events.patch"
Content-Disposition: attachment; 
	filename="v1-001-fix-socket-select-events.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lqs40lh00>
X-Attachment-Id: f_lqs40lh00

ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BvcnQvd2luMzIvc29ja2V0LmMgYi9zcmMvYmFja2Vu
ZC9wb3J0L3dpbjMyL3NvY2tldC5jCmluZGV4IDljMzM5Mzk3ZDEuLjE4ZGM4ZDk2ODYgMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL3BvcnQvd2luMzIvc29ja2V0LmMKKysrIGIvc3JjL2JhY2tlbmQv
cG9ydC93aW4zMi9zb2NrZXQuYwpAQCAtNTE5LDggKzUxOSw4IEBAIHBnd2luMzJfc2VsZWN0KGlu
dCBuZmRzLCBmZF9zZXQgKnJlYWRmZHMsIGZkX3NldCAqd3JpdGVmZHMsIGZkX3NldCAqZXhjZXB0
ZmRzLCBjCiAJCQkJCQkJCQkJICogZGlmZmVyZW50IGZyb20gd3JpdGVmZHMsIHNvCiAJCQkJCQkJ
CQkJICogMipGRF9TRVRTSVpFIHNvY2tldHMgKi8KIAlTT0NLRVQJCXNvY2tldHNbRkRfU0VUU0la
RSAqIDJdOwotCWludAkJCW51bWV2ZW50cyA9IDA7Ci0JaW50CQkJaTsKKwl1X2ludAkJbnVtZXZl
bnRzID0gMDsKKwl1X2ludAkJaTsKIAlpbnQJCQlyOwogCURXT1JECQl0aW1lb3V0dmFsID0gV1NB
X0lORklOSVRFOwogCUZEX1NFVAkJb3V0cmVhZGZkczsKQEAgLTYxOCw3ICs2MTgsNyBAQCBwZ3dp
bjMyX3NlbGVjdChpbnQgbmZkcywgZmRfc2V0ICpyZWFkZmRzLCBmZF9zZXQgKndyaXRlZmRzLCBm
ZF9zZXQgKmV4Y2VwdGZkcywgYwogCQl7CiAJCQlUcmFuc2xhdGVTb2NrZXRFcnJvcigpOwogCQkJ
LyogcmVsZWFzZSBhbHJlYWR5LWFzc2lnbmVkIGV2ZW50IG9iamVjdHMgKi8KLQkJCXdoaWxlICgt
LWkgPj0gMCkKKwkJCXdoaWxlIChpLS0gPj0gMCkKIAkJCQlXU0FFdmVudFNlbGVjdChzb2NrZXRz
W2ldLCBOVUxMLCAwKTsKIAkJCWZvciAoaSA9IDA7IGkgPCBudW1ldmVudHM7IGkrKykKIAkJCQlX
U0FDbG9zZUV2ZW50KGV2ZW50c1tpXSk7
--0000000000006382ea060dba4a54--