MIME-Version: 1.0
References: 
 <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>
 <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com>
 <CAHg+QDdzUMW4qQmywiPmVo2z3+HccFZL+mujdXbB+ghU21u7dA@mail.gmail.com>
 <CAExHW5vmmAS6Vroh8W9+vmuM2ReocODRCWPqYozGSyhxCxxL+Q@mail.gmail.com>
 <2b3490b5-e0e5-4f3b-9165-df1990bee70b@eisentraut.org>
In-Reply-To: <2b3490b5-e0e5-4f3b-9165-df1990bee70b@eisentraut.org>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Tue, 12 May 2026 11:50:55 +0530
Message-ID: 
 <CAExHW5sG6f5m22viW99wgsOmAXXK9312obZJMfZjCUevM7K9rg@mail.gmail.com>
Subject: Re: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
To: Peter Eisentraut <peter@eisentraut.org>
Cc: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
 Junwang Zhao <zhjwpku@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000005d4e68065198de18"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5sG6f5m22viW99wgsOmAXXK9312obZJMfZjCUevM7K9rg%40mail.gmail.com>
Precedence: bulk

--0000000000005d4e68065198de18
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 4, 2026 at 8:42=E2=80=AFPM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
>
> On 29.04.26 16:09, Ashutosh Bapat wrote:
> > On Mon, Apr 27, 2026 at 11:34=E2=80=AFAM SATYANARAYANA NARLAPURAM
> > <satyanarlapuram@gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> On Sun, Apr 26, 2026 at 8:10=E2=80=AFAM Junwang Zhao <zhjwpku@gmail.co=
m> wrote:
> >>>
> >>> Hi SATYANARAYANA,
> >>>
> >>> On Sun, Apr 26, 2026 at 3:53=E2=80=AFAM SATYANARAYANA NARLAPURAM
> >>> <satyanarlapuram@gmail.com> wrote:
> >>>>
> >>>> Hi hackers,
> >>>>
> >>>> transformRangeGraphTable() calls transformExpr() and
> >>>> assign_list_collations() for COLUMNS expressions but missed calling
> >>>> resolveTargetListUnknowns(). As a result, literals such as 'val1'
> >>>> in a COLUMNS clause retained type "unknown", causing failures with
> >>>> ORDER BY, UNION, and output conversions.
> >>>>
> >>>> Fix by calling resolveTargetListUnknowns() on the columns target
> >>>> list right after assign_list_collations(), similar to SELECT target =
lists in
> >>>> transformSelectStmt().
> >>>>
> >>>> Attached a patch to fix this, which also includes test cases to repr=
oduce.
> >>>
> >>> I can reproduce this and the patch fixes it.
> >>>
> >>> One question: why is resolveTargetListUnknowns called after
> >>> assign_list_collations?
> >>>
> >>> I'm asking because in transformSelectStmt, resolveTargetListUnknowns
> >>> is invoked before assign_query_collations. It might not matter, but k=
eeping
> >>> the order consistent would be good for readers.
> >>
> >>
> >> Updated the patch. It should be before.
> >
> > Do we really need a test for ORDER BY on a literal column? I replaced
> > all the test queries with a single one which covers all the scenarios
> > covered by those queries.
> >
> > The patch needed to consider pstate->p_resolve_unknowns. Unknown
> > literals are not resolved as text always. See the test query.
>
> I couldn't find a commit to apply this patch cleanly (the subject says
> patch 5/5, so maybe you had some unpublished local changes?).

I am maintaining all the SQL/PGQ fixes in the same branch and creating
patches from that branch. Hence 5/5. But still it shouldn't have
applied cleanly. Both git cherry-pick and git am <attached patch
file>, on a fresh branch succeeded. Please let me know if you still
face the issue.

> After
> applying the test case manually, it looks like the test output is
> already correct without the code change.  So if this patch is still
> required, we need a better test case.
>

Yes, the test query doesn't reproduce the bug. Actually all but only
two queries from the Satya's patch show the bug. I have included a
test query which fails, with expected error message, without code
changes now. Also I don't think we need a separate section for this
test query. Included the query in one of the earliest sections in the
file.

--=20
Best Wishes,
Ashutosh Bapat

--0000000000005d4e68065198de18
Content-Type: text/x-patch; charset="US-ASCII";
	name="v20260512-0001-Resolve-unknown-type-literals-in-GRAPH_TAB.patch"
Content-Disposition: attachment;
	filename="v20260512-0001-Resolve-unknown-type-literals-in-GRAPH_TAB.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mp28qxsv0>
X-Attachment-Id: f_mp28qxsv0

RnJvbSA2OWZjYmYyYjkwN2ZmODNhYWExNzU5M2M1NTk2ZTQ5NWNjMDcyMGU3IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdt
YWlsLmNvbT4KRGF0ZTogV2VkLCAyOSBBcHIgMjAyNiAxOTowNzoxMyArMDUzMApTdWJqZWN0OiBb
UEFUQ0ggdjIwMjYwNTEyIDQvNF0gUmVzb2x2ZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgaW4gR1JB
UEhfVEFCTEUKIENPTFVNTlMKClRoZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgaW4gdGhlIENPTFVN
TlMgY2xhdXNlIG9mIGEgR1JBUEhfVEFCTEUgYXJlIG5vdwpyZXNvbHZlZCB0byB0aGUgYXBwcm9w
cmlhdGUgdHlwZXMsIGNhdXNpbmcgdmFyaW91cyBmYWlsdXJlcy4gQ2FsbApyZXNvbHZlVGFyZ2V0
TGlzdFVua25vd25zKCkgb24gdGhlIGNvbHVtbnMgdGFyZ2V0bGlzdCB0byByZXNvbHZlIHVua25v
bncgdHlwZQpsaXRlcmFscy4gRG8gdGhpcyBiZWZvcmUgYXNzaWduaW5nIGNvbGxhdGlvbnMgc28g
dGhhdCB0aGUgcmVzb2x2ZWQgdHlwZXMgYXJlCnVzZWQgZm9yIGNvbGxhdGlvbnMgYXNzaWdubWVu
dC4KClJlcG9ydGVkIGJ5OiBTYXR5YSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21haWwu
Y29tPgpBdXRob3I6IFNhdHlhIE5hcmxhcHVyYW0gPHNhdHlhbmFybGFwdXJhbUBnbWFpbC5jb20+
CkF1dGhvcjogQXNodXRvc2ggQmFwYXQgPGFzaHV0b3NoLmJhcGF0Lm9zc0BnbWFpbC5jb20+ClJl
dmlld2VkIGJ5OiBKdW53YW5nIFpoYW8gPHpoandwa3VAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBo
dHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlkL0NBSGcrUURjeUtOV3l6RG9LTXhp
Wk5qdjdDLXdBeHM4eTBab05rT1YxMzdZK25rM1VYZ0BtYWlsLmdtYWlsLmNvbQotLS0KIHNyYy9i
YWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYyAgICAgICAgIHwgNCArKysrCiBzcmMvdGVzdC9y
ZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxlLm91dCB8IDkgKysrKysrKysrCiBzcmMvdGVzdC9y
ZWdyZXNzL3NxbC9ncmFwaF90YWJsZS5zcWwgICAgICB8IDIgKysKIDMgZmlsZXMgY2hhbmdlZCwg
MTUgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9j
bGF1c2UuYyBiL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYwppbmRleCA0MjcwYzIz
ODJjNC4uM2QwNTg1YjhlZmIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9j
bGF1c2UuYworKysgYi9zcmMvYmFja2VuZC9wYXJzZXIvcGFyc2VfY2xhdXNlLmMKQEAgLTEwMDMs
NiArMTAwMywxMCBAQCB0cmFuc2Zvcm1SYW5nZUdyYXBoVGFibGUoUGFyc2VTdGF0ZSAqcHN0YXRl
LCBSYW5nZUdyYXBoVGFibGUgKnJndCkKIAkJY29sdW1ucyA9IGxhcHBlbmQoY29sdW1ucywgdGUp
OwogCX0KIAorCS8qIHJlc29sdmUgYW55IHN0aWxsLXVucmVzb2x2ZWQgb3V0cHV0IGNvbHVtbnMg
YXMgYmVpbmcgdHlwZSB0ZXh0ICovCisJaWYgKHBzdGF0ZS0+cF9yZXNvbHZlX3Vua25vd25zKQor
CQlyZXNvbHZlVGFyZ2V0TGlzdFVua25vd25zKHBzdGF0ZSwgY29sdW1ucyk7CisKIAkvKgogCSAq
IEFzc2lnbiBjb2xsYXRpb25zIHRvIGNvbHVtbiBleHByZXNzaW9ucyBub3cgc2luY2UKIAkgKiBh
c3NpZ25fcXVlcnlfY29sbGF0aW9ucygpIGRvZXMgbm90IHByb2Nlc3MgcmFuZ2V0YWJsZSBlbnRy
aWVzLgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJsZS5v
dXQgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxlLm91dAppbmRleCBjYzZk
ODBhZmQ4Mi4uZThkNDlmZDVjZDQgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0
ZWQvZ3JhcGhfdGFibGUub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhf
dGFibGUub3V0CkBAIC0xNjAsNiArMTYwLDE1IEBAIFNFTEVDVCAqIEZST00gR1JBUEhfVEFCTEUg
KG15c2hvcCBNQVRDSCAoYyBJUyBjdXN0b21lcnMpIENPTFVNTlMgKGMubmFtZSkpOwogIGN1c3Rv
bWVyMwogKDMgcm93cykKIAorLS0gVW5rbm93biB0eXBlIHJlc29sdXRpb24KK1NFTEVDVCAqLCBw
Z190eXBlb2YodW5rbm93bl9jb2wpIEFTIHVua25vd25fY29sX3R5cGUsIHBnX3R5cGVvZihudWxs
X2NvbCkgQVMgbnVsbF9jb2xfdHlwZSBGUk9NIEdSQVBIX1RBQkxFIChteXNob3AgTUFUQ0ggKGMg
SVMgY3VzdG9tZXJzKSBDT0xVTU5TIChjLm5hbWUsICd1bmtub3duLWxpdGVyYWwnIEFTIHVua25v
d25fY29sLCBOVUxMIEFTIG51bGxfY29sKSk7CisgICBuYW1lICAgIHwgICB1bmtub3duX2NvbCAg
IHwgbnVsbF9jb2wgfCB1bmtub3duX2NvbF90eXBlIHwgbnVsbF9jb2xfdHlwZSAKKy0tLS0tLS0t
LS0tKy0tLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0tKy0tLS0t
LS0tLS0tLS0tLQorIGN1c3RvbWVyMSB8IHVua25vd24tbGl0ZXJhbCB8ICAgICAgICAgIHwgdGV4
dCAgICAgICAgICAgICB8IHRleHQKKyBjdXN0b21lcjIgfCB1bmtub3duLWxpdGVyYWwgfCAgICAg
ICAgICB8IHRleHQgICAgICAgICAgICAgfCB0ZXh0CisgY3VzdG9tZXIzIHwgdW5rbm93bi1saXRl
cmFsIHwgICAgICAgICAgfCB0ZXh0ICAgICAgICAgICAgIHwgdGV4dAorKDMgcm93cykKKwogU0VM
RUNUICogRlJPTSBHUkFQSF9UQUJMRSAobXlzaG9wIE1BVENIIChjIElTIGN1c3RvbWVycyBXSEVS
RSBjLmFkZHJlc3MgPSAnVVMnKS1bSVMgY3VzdG9tZXJfb3JkZXJzXS0+KG8gSVMgb3JkZXJzKSBD
T0xVTU5TIChjLm5hbWUpKTsKICAgIG5hbWUgICAgCiAtLS0tLS0tLS0tLQpkaWZmIC0tZ2l0IGEv
c3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsIGIvc3JjL3Rlc3QvcmVncmVzcy9z
cWwvZ3JhcGhfdGFibGUuc3FsCmluZGV4IDBlMzgxZWM3MmJjLi5lNzYxZjA5ZTA1NyAxMDA2NDQK
LS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsCisrKyBiL3NyYy90ZXN0
L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbApAQCAtMTM0LDYgKzEzNCw4IEBAIElOU0VSVCBJ
TlRPIHdpc2hsaXN0X2l0ZW1zICh3aXNobGlzdF9pdGVtc19pZCwgd2lzaGxpc3RfaWQsIHByb2R1
Y3Rfbm8pIFZBTFVFUwogCiAtLSBzaW5nbGUgZWxlbWVudCBwYXRoIHBhdHRlcm4KIFNFTEVDVCAq
IEZST00gR1JBUEhfVEFCTEUgKG15c2hvcCBNQVRDSCAoYyBJUyBjdXN0b21lcnMpIENPTFVNTlMg
KGMubmFtZSkpOworLS0gVW5rbm93biB0eXBlIHJlc29sdXRpb24KK1NFTEVDVCAqLCBwZ190eXBl
b2YodW5rbm93bl9jb2wpIEFTIHVua25vd25fY29sX3R5cGUsIHBnX3R5cGVvZihudWxsX2NvbCkg
QVMgbnVsbF9jb2xfdHlwZSBGUk9NIEdSQVBIX1RBQkxFIChteXNob3AgTUFUQ0ggKGMgSVMgY3Vz
dG9tZXJzKSBDT0xVTU5TIChjLm5hbWUsICd1bmtub3duLWxpdGVyYWwnIEFTIHVua25vd25fY29s
LCBOVUxMIEFTIG51bGxfY29sKSk7CiBTRUxFQ1QgKiBGUk9NIEdSQVBIX1RBQkxFIChteXNob3Ag
TUFUQ0ggKGMgSVMgY3VzdG9tZXJzIFdIRVJFIGMuYWRkcmVzcyA9ICdVUycpLVtJUyBjdXN0b21l
cl9vcmRlcnNdLT4obyBJUyBvcmRlcnMpIENPTFVNTlMgKGMubmFtZSkpOwogLS0gZ3JhcGggZWxl
bWVudCBzcGVjaWZpY2F0aW9uIHdpdGhvdXQgbGFiZWwgb3IgdmFyaWFibGUKIFNFTEVDVCAqIEZS
T00gR1JBUEhfVEFCTEUgKG15c2hvcCBNQVRDSCAoYyBJUyBjdXN0b21lcnMgV0hFUkUgYy5hZGRy
ZXNzID0gJ1VTJyktW10tPihvIElTIG9yZGVycykgQ09MVU1OUyAoYy5uYW1lIEFTIGN1c3RvbWVy
X25hbWUpKTsKLS0gCjIuMzQuMQoK
--0000000000005d4e68065198de18--