public inbox for [email protected]
help / color / mirror / Atom feedFrom: Ashutosh Bapat <[email protected]>
To: Junwang Zhao <[email protected]>
Cc: Vik Fearing <[email protected]>
Cc: Ajay Pal <[email protected]>
Cc: Imran Zaheer <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: SQL Property Graph Queries (SQL/PGQ)
Date: Tue, 28 Jan 2025 15:56:45 +0530
Message-ID: <CAExHW5saaVXr1rpsxBbkGDLKhVirrWEXQPcM_7nUv9R3UEYuWA@mail.gmail.com> (raw)
In-Reply-To: <CAEG8a3L-BC85c6fTUK0iU+TEcubRKODqGAf=kkwf=YSynKL2PA@mail.gmail.com>
References: <[email protected]>
<CAExHW5s3BL_qUwQ=ye8RX7GnVcGC+FeR7h6jFocBZC5JFXATEQ@mail.gmail.com>
<[email protected]>
<CAExHW5vhiawMAEtRwV=X-zQmJeUVY2iyuskWFFKobm_ZvgMf9Q@mail.gmail.com>
<CAExHW5tf9UDzhNWXHyDNBG4DRoq81-Ty4XqcY8wiixt844B0eA@mail.gmail.com>
<CAExHW5uF7KMcABuNVB1de6JRY3ne-jYEP3+8ycQZGkFA=1OTLw@mail.gmail.com>
<CA+UBfakRHrTqTkx8W0cmxGD7zfnZkZ4nczUvp0FGF68LvMSG-A@mail.gmail.com>
<CAExHW5uykgWS=4fqL8eJqCKOQcHgtK89=Nq7eS_av-28ge=LKQ@mail.gmail.com>
<CA+UBfamThQm9FQ7Kv=HQZPDy5CfULpn6yuU0bzPy-kX-=-jV4Q@mail.gmail.com>
<CABRHmytyWxGMaQejiZ28OubtqnOUfzB9nZQSctyvsmxvS_cKCw@mail.gmail.com>
<CABRHmyuvgFEXNgUsxXiSHh01iKcLrqyvcDWeOP+wuXjbMRYkEw@mail.gmail.com>
<CABRHmytkwZNiXEqLKx7r6w3xVL8pCiFLaG8_a=BkqfcuumM1vA@mail.gmail.com>
<CAExHW5vqo7iTcVznspb3HHD87Ps3Q=JF6_gg+h5mhyuwhd3Q4Q@mail.gmail.com>
<CAExHW5serNyfY4v9oy6us=tM7ZyAd3_gYnMjOmRPk8eWEskSog@mail.gmail.com>
<[email protected]>
<CAExHW5tYchoePjt3Z69zSmgMW50_jxNfpUiodRcQABUY6V8oxw@mail.gmail.com>
<CAExHW5vG8sgT7H=Q6V_+aMF3f3vs+F7Mu_3AFrufhD=BPkBP0A@mail.gmail.com>
<CAExHW5tDDwUK0dVqFRyUag8UsABmFNWhz8E6AVPDV2BXJLsY5w@mail.gmail.com>
<CAEG8a3KFWD-a-jRtA__opQQaC9Z=_+rw=Gtydk1zStR-roMwWw@mail.gmail.com>
<CAExHW5sM+ZGVzR1428FsDHuWc-FU2-6zQr5j91KLh6vZaWY0ow@mail.gmail.com>
<CAExHW5t9OkLPv5g68C9=kaduyaz2HZQ2bHzOT3d421Wm4_teuA@mail.gmail.com>
<CAEG8a3KLQ4GLKA7cLNPfMVNMy7-QEGCW4jVz+pa+ErYbgmFh9w@mail.gmail.com>
<CAExHW5soDmT=yuXOqGLuNbp-_p-0rGD_CbAQ0PqROUKNBtJsBw@mail.gmail.com>
<CAEG8a3L_Q8chyLQsOLtfLFfOHRW=sL_akKrtmh334RfjgGvWKg@mail.gmail.com>
<CAEG8a3L-BC85c6fTUK0iU+TEcubRKODqGAf=kkwf=YSynKL2PA@mail.gmail.com>
On Fri, Jan 24, 2025 at 9:16 PM Junwang Zhao <[email protected]> wrote:
>
> I figured out it's because I have `-DWRITE_READ_PARSE_PLAN_TREES` this option,
> removing this option clears the warning, but I'm not sure if this is a
> hidden issue.
>
Thanks for the hint. I found the issue and the fix appears in 0004.
Some members of RangeTblEntry were not being handled in read/out
functions.
> >
> > 0001-0009 patches are the same as the previous set sans mergeconflict fixes.
> > 0010 - is test for \dGx - to make sure that the extended format output
> > works with \dG. We may decide not to have this patch in the final
> > commit. But no harm in being there til that point.
>
> I have some changes based on the latest patch set. I attached two patches with
> the following summary.
>
> 0001:
> - doc: some of the query in ddl.sgml can not be executed
The standard seems to require a property reference to be qualified by
element pattern variable, even if the property is referenced within
the same element pattern bound to the variable. Hence I accepted your
document fixes which qualify property reference with element pattern
variable.
However, I didn't understand why you changed a LABEL name from order to order_.
> - after path factor was introduced, some comments doesn't apply
Thanks pointing those out. Accepted after rephrasing those and also
correcting some related comments.
>
> 0002:
> - add a get_propgraph_element_alias_name function and do some trivial refactor
>
I see you have added some negative tests - object not found tests, but
I didn't see positive tests. Hence I haven't added those changes in
the attached patchset. But we certainly need those changes. You may
want to submit a patch with positive tests. That code needs to be
fixed before committing anyway.
--
Best Wishes,
Ashutosh Bapat
Attachments:
[application/zip] pg_sql_pgq-20250128.zip (164.5K, ../CAExHW5saaVXr1rpsxBbkGDLKhVirrWEXQPcM_7nUv9R3UEYuWA@mail.gmail.com/2-pg_sql_pgq-20250128.zip)
download
view thread (37+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: SQL Property Graph Queries (SQL/PGQ)
In-Reply-To: <CAExHW5saaVXr1rpsxBbkGDLKhVirrWEXQPcM_7nUv9R3UEYuWA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox