MIME-Version: 1.0
References: <1DA5D52A-4AFA-426E-83F7-42ED974D682B@gmail.com>
 <CAExHW5s1q7eyp4qJLPzCgnsE9tQ8uKdLyOwKt3cijdMR_0E+Cg@mail.gmail.com>
 <E3D6552E-DB26-47BC-9C7C-0F9CB936BF5B@gmail.com>
 <CAExHW5s-4MHjo0wn=bNGQQd=Q+3SW_HGxJCFnoBF+hiy5ni8wA@mail.gmail.com>
 <59B04C7C-8DE7-48CE-9CD4-6E188D16A0C4@gmail.com>
 <02fe13db-4fba-4e9d-9b4c-e6271a133502@app.fastmail.com>
In-Reply-To: <02fe13db-4fba-4e9d-9b4c-e6271a133502@app.fastmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 29 Apr 2026 17:40:32 +0530
Message-ID: 
 <CAExHW5so9k_8RsAs00-rTY+4x9rtuO6cmwy8RG6jZx1PZGVHqQ@mail.gmail.com>
Subject: Re: Property graph: fix error handling when dropping non-existent
 label property
To: =?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Cc: Chao Li <li.evan.chao@gmail.com>,
	"L. pgsql-hackers" <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5so9k_8RsAs00-rTY%2B4x9rtuO6cmwy8RG6jZx1PZGVHqQ%40mail.gmail.com>
Precedence: bulk

On Wed, Apr 29, 2026 at 3:22=E2=80=AFPM =C3=81lvaro Herrera <alvherre@kuril=
emu.de> wrote:
>
> On 2026-04-29, Chao Li wrote:
>
> >> Looks good to me. However, I did change OidIsValid() and !OidIsValid()
> >> back to (oid) and (!oid) conditions to be consistent with the rest of
> >> the code.
> >
> > In the file, I also see:
> > ```
> >     if (pgrelid =3D=3D InvalidOid)
> > ```
> >
> > Should we take this opportunity to change to use OidIsValid()
> > everywhere in the file? As this feature is new to PG19, we can cleanup
> > the inconsistency before releasing v19. Otherwise some people might
> > also file a cleanup patch for this in the future.
>
> Yeah, I find "if (oid)" a rather terrible coding pattern. The negative on=
e is perhaps not so bad, but I'd keep both cases similar by using the macro=
 in both, for consistency.
>

I am in favour of doing this change, but let's do it in a separate patch.

--=20
Best Wishes,
Ashutosh Bapat