MIME-Version: 1.0
References: 
 <CAExHW5vM1bneLYfg0wGeAa=52UiJ3z4vKd3AJ72X8Fw6k3KKrg@mail.gmail.com>
 <CAExHW5uEK+eeG7e2g6uWh7POrFpfp+dqfaa=_3miMN17zgeaJw@mail.gmail.com>
 <CAExHW5vz+PUHHUuzGRwtyx-mPLQk3nCZXxrFqnruRadEFrO5Xg@mail.gmail.com>
 <CAExHW5so6VSxBC-1V=35229Z1+dw5vhw8HxHg9ry7UzceKcXzA@mail.gmail.com>
 <26c766d6-db0f-43d3-a618-44f8d40a3121@iki.fi>
 <CA+TgmoaoSha9KnSdrA7DDMYD9+Uor4OPEaQ88bbEC3QuVE5Mcg@mail.gmail.com>
 <62b8dc23-8f6a-4cac-91ff-f74bb5bc159a@iki.fi>
 <CA+TgmoboxAaS6MCRf__LRhf8Ji3B0O9_=d7KzRS12QhOuocnTQ@mail.gmail.com>
 <c7b4dafc-7a6c-43e4-8b9e-20807396590b@iki.fi>
 <CA+Tgmob7E3CGDoEBB3mwfk+v1CgcOG8yL0VHje2gy9Ts=e1Zxw@mail.gmail.com>
 <f8fc6f77-292d-4225-9f54-382c39da5ebc@iki.fi>
 <CA+TgmobqwCHp1w6xkTJmZiq4C8Pr0O3tNUvSFZcAgYLkvF45bg@mail.gmail.com>
 <8a6799be-bd42-49fb-8914-856c97bb1977@iki.fi>
 <CA+Tgmob8ot7qam7a650nx_4jyEoFLs8s_kPMc1+EB7-dr56=WA@mail.gmail.com>
 <cc3ff976-c303-45cd-9a8d-a90483170e37@iki.fi>
 <CA+TgmoauqYXm8iA3FGRAVKxYShUxWBiS_MSLmQpTrmO7wNHamw@mail.gmail.com>
 <113724ab-0028-493f-9605-6e8570f0939f@iki.fi>
 <CAExHW5uTNWOSxJDWQAUnS0tZawob2_J3dRAtc67NHNZ98X4_xA@mail.gmail.com>
In-Reply-To: 
 <CAExHW5uTNWOSxJDWQAUnS0tZawob2_J3dRAtc67NHNZ98X4_xA@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 25 Mar 2026 21:35:03 +0530
Message-ID: 
 <CAExHW5t439y61YD9bc7d5wZWHp6J=M43Qu3eEZOBPguZML7o2A@mail.gmail.com>
Subject: Re: Better shared data structure management and resizable shared data
 structures
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>, chaturvedipalak1911@gmail.com
Content-Type: multipart/mixed; boundary="0000000000001e658f064ddb6fc2"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5t439y61YD9bc7d5wZWHp6J%3DM43Qu3eEZOBPguZML7o2A%40mail.gmail.com>
Precedence: bulk

--0000000000001e658f064ddb6fc2
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 24, 2026 at 9:02=E2=80=AFPM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
>
> I will continue from 0008 tomorrow.
>

I reviewed the documentation part of 0008. I have a few edits attached.

I have just one comment that's not covered in the edits

@@ -4254,8 +4254,8 @@ SELECT * FROM pg_locks pl LEFT JOIN pg_prepared_xacts=
 ppx
<para>
Anonymous allocations are allocations that have been made
with <literal>ShmemAlloc()</literal> directly, rather than via
- <literal>ShmemInitStruct()</literal> or
- <literal>ShmemInitHash()</literal>.
+ <literal>ShmemRequestStruct()</literal> or
+ <literal>ShmemRequestHash()</literal>.
</para>

ShmemInitStruct() and ShmemInitHash() are still the functions to
allocate named structures. If we are going to keep ShmemInitStruct()
and ShmemInitHash() around for a while, I think it is more accurate to
mention them in this sentence along with the new functions.

Will continue reviewing the patch tomorrow.

--=20
Best Wishes,
Ashutosh Bapat

--0000000000001e658f064ddb6fc2
Content-Type: application/octet-stream; name="0008_edits.patch.nocibot"
Content-Disposition: attachment; filename="0008_edits.patch.nocibot"
Content-Transfer-Encoding: base64
Content-ID: <f_mn68iai40>
X-Attachment-Id: f_mn68iai40

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC94ZnVuYy5zZ21sIGIvZG9jL3NyYy9zZ21sL3hmdW5j
LnNnbWwKaW5kZXggYWNmNmZmNzRmOTguLjFjMGYzOWUxMWVjIDEwMDY0NAotLS0gYS9kb2Mvc3Jj
L3NnbWwveGZ1bmMuc2dtbAorKysgYi9kb2Mvc3JjL3NnbWwveGZ1bmMuc2dtbApAQCAtMzYyOCw3
ICszNjI4LDcgQEAgQ1JFQVRFIEZVTkNUSU9OIG1ha2VfYXJyYXkoYW55ZWxlbWVudCkgUkVUVVJO
UyBhbnlhcnJheQogICAgICAgQWRkLWlucyBjYW4gcmVzZXJ2ZSBzaGFyZWQgbWVtb3J5IG9uIHNl
cnZlciBzdGFydHVwLiAgVG8gZG8gc28sIHRoZQogICAgICAgYWRkLWluJ3Mgc2hhcmVkIGxpYnJh
cnkgbXVzdCBiZSBwcmVsb2FkZWQgYnkgc3BlY2lmeWluZyBpdCBpbgogICAgICAgPHhyZWYgbGlu
a2VuZD0iZ3VjLXNoYXJlZC1wcmVsb2FkLWxpYnJhcmllcyIvPjxpbmRleHRlcm0+PHByaW1hcnk+
c2hhcmVkX3ByZWxvYWRfbGlicmFyaWVzPC9wcmltYXJ5PjwvaW5kZXh0ZXJtPi4KLSAgICAgIFRo
ZSBzaGFyZWQgbGlicmFyeSBzaG91bGQgcmVnaXN0ZXIgY2FsbGJhY2tzIGluIGl0cworICAgICAg
VGhlIHNoYXJlZCBsaWJyYXJ5IHNob3VsZCByZWdpc3RlciBjYWxsYmFja3MgaW4KICAgICAgIGl0
cyA8ZnVuY3Rpb24+X1BHX2luaXQ8L2Z1bmN0aW9uPiBmdW5jdGlvbiwgd2hpY2ggdGhlbiBnZXQg
Y2FsbGVkIGF0IHRoZQogICAgICAgcmlnaHQgc3RhZ2VzIG9mIHRoZSBzeXN0ZW0gc3RhcnR1cCB0
byBpbml0aWFsaXplIHRoZSBzaGFyZWQgbWVtb3J5LgogICAgICAgSGVyZSBpcyBhbiBleGFtcGxl
OgpAQCAtMzY5MiwxMSArMzY5MiwxMSBAQCBteV9zaG1lbV9pbml0KHZvaWQgKmFyZykKIH0KIAog
PC9wcm9ncmFtbGlzdGluZz4KLSAgICAgIFRoZSA8ZnVuY3Rpb24+cmVxdWVzdF9mbjwvZnVuY3Rp
b24+IGNhbGxiYWNrIGlzIGNhbGxlZCBkdXJpbmcgc3lzdGVtCisgICAgICBUaGUgPGZ1bmN0aW9u
PnNobWVtX3JlcXVlc3RfZm48L2Z1bmN0aW9uPiBjYWxsYmFjayBpcyBjYWxsZWQgZHVyaW5nIHN5
c3RlbQogICAgICAgc3RhcnR1cCwgYmVmb3JlIHRoZSBzaGFyZWQgbWVtb3J5IGhhcyBiZWVuIGFs
bG9jYXRlZC4gSXQgc2hvdWxkIGNhbGwKICAgICAgIDxmdW5jdGlvbj5TaG1lbVJlcXVlc3RTdHJ1
Y3QoKTwvZnVuY3Rpb24+IHRvIHJlZ2lzdGVyIHRoZSBhZGQtaW4ncwogICAgICAgc2hhcmVkIG1l
bW9yeSBuZWVkcy4gTm90ZSB0aGF0IDxmdW5jdGlvbj5TaG1lbVJlcXVlc3RTdHJ1Y3QoKTwvZnVu
Y3Rpb24+Ci0gICAgICBkb2VzbicnIGltbWVkaWF0ZWx5IGFsbG9jYXRlIG9yIGluaXRpYWxpemUg
dGhlIG1lbW9yeSwgaXQgbWVyZWx5CisgICAgICBkb2Vzbid0IGltbWVkaWF0ZWx5IGFsbG9jYXRl
IG9yIGluaXRpYWxpemUgdGhlIG1lbW9yeSwgaXQgbWVyZWx5CiAgICAgICByZWdpc3RlcnMgdGhl
IHNwYWNlIHRvIGJlIGFsbG9jYXRlZCBsYXRlciBpbiB0aGUgc3RhcnR1cCBzZXF1ZW5jZS4gIFdo
ZW4KICAgICAgIHRoZSBtZW1vcnkgaXMgYWxsb2NhdGVkLCBpdCBpcyBpbml0aWFsaXplZCB0byB6
ZXJvLiAgVG8gYW55IG1vcmUgY29tcGxleAogICAgICAgaW5pdGlhbGl6YXRpb24sIHNldCB0aGUg
PGZ1bmN0aW9uPmluaXRfZm4oKTwvZnVuY3Rpb24+IGNhbGxiYWNrLCB3aGljaApAQCAtMzcyNiw3
ICszNzI2LDcgQEAgbXlfc2htZW1faW5pdCh2b2lkICphcmcpCiAgICAgICBsaWJyYXJpZXMgdGhh
dCBhcmUgbm90IHNwZWNpZmllZCBpbgogICAgICAgPHhyZWYgbGlua2VuZD0iZ3VjLXNoYXJlZC1w
cmVsb2FkLWxpYnJhcmllcyIvPjxpbmRleHRlcm0+PHByaW1hcnk+c2hhcmVkX3ByZWxvYWRfbGli
cmFyaWVzPC9wcmltYXJ5PjwvaW5kZXh0ZXJtPi4KICAgICAgIEhvd2V2ZXIsIGFmdGVyIHN0YXJ0
dXAgdGhlIGFsbG9jYXRpb24gY2FuIGZhaWwgaWYgdGhlcmUgaXMgbm90IGVub3VnaAotICAgICAg
c2hhcmVkIG1lbW9yeSBhdmFpbGFibGUuIFRoZSBzeXN0ZW0gcmVzZXJ2ZXMgYSBzb21lcyBtZW1v
cnkgZm9yCisgICAgICBzaGFyZWQgbWVtb3J5IGF2YWlsYWJsZS4gVGhlIHN5c3RlbSByZXNlcnZl
cyBzb21lIG1lbW9yeSBmb3IKICAgICAgIGFsbG9jYXRpb25zIGFmdGVyIHN0YXJ0dXAsIGJ1dCB0
aGF0IHJlc2VydmF0aW9uIGlzIHNtYWxsLgogICAgICA8L3BhcmE+CiAgICAgIDxwYXJhPgpAQCAt
MzczOSw4ICszNzM5LDggQEAgbXlfc2htZW1faW5pdCh2b2lkICphcmcpCiAgICAgICBXaGVuIDxm
dW5jdGlvbj5SZWdpc3RlclNobWVtQ2FsbGJhY2tzKCk8L2Z1bmN0aW9uPiBpcyBjYWxsZWQgYWZ0
ZXIKICAgICAgIHN0YXJ0dXAsIGl0IHdpbGwgaW1tZWRpYXRlbHkgY2FsbCB0aGUgYXBwcm9wcmlh
dGUgY2FsbGJhY2tzLCBkZXBlbmRpbmcKICAgICAgIG9uIHdoZXRoZXIgdGhlIHJlcXVlc3RlZCBt
ZW1vcnkgYXJlYXMgd2VyZSBhbHJlYWR5IGluaXRpYWxpemVkIGJ5Ci0gICAgICBhbm90aGVyIGJh
Y2tlbmQuIFRoZSBjYWxsYmFja3Mgd2lsbCBiZSBoZWxkIHdoaWxlIGhvbGRpbmcgYW4gaW50ZXJu
YWwKLSAgICAgIGxvY2ssIHdoaWNoIHByZXZlbnRzIGNvbmN1cnJlbnQgdHdvIGJhY2tlbmRzIGZy
b20gaW5pdGlhbGl6YXRpbmcgdGhlCisgICAgICBhbm90aGVyIGJhY2tlbmQuIFRoZSBjYWxsYmFj
a3Mgd2lsbCBiZSBjYWxsZWQgd2hpbGUgaG9sZGluZyBhbiBpbnRlcm5hbAorICAgICAgbG9jaywg
d2hpY2ggcHJldmVudHMgbXVsdGlwbGUgYmFja2VuZHMgZnJvbSBpbml0aWFsaXphdGluZyB0aGUK
ICAgICAgIG1lbW9yeSBhcmVhIGNvbmN1cnJlbnRseS4KICAgICAgPC9wYXJhPgogICAgIDwvc2Vj
dDM+Cg==
--0000000000001e658f064ddb6fc2--