MIME-Version: 1.0
References: <202311301140.wo7f6eoi772a@alvherre.pgsql> <79de837a-33c2-481b-91dd-7f3926262baa@postgrespro.ru>
 <CAExHW5stHDXdRi1_pvNwq5R=qEseBeUxL6_v2ZRT3Pns2K6Jsw@mail.gmail.com> <CACJufxEAteeETm9A53WEeqVubfCfFQ0d-fLNnF-9G4h0S1sNwQ@mail.gmail.com>
In-Reply-To: <CACJufxEAteeETm9A53WEeqVubfCfFQ0d-fLNnF-9G4h0S1sNwQ@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Mon, 11 Dec 2023 19:05:32 +0530
Message-ID: <CAExHW5t4f0K6JrE1Yj3zzOJ3_FDb1M0eFpOVnANFUQ3e9WXwYA@mail.gmail.com>
Subject: Re: Report planning memory in EXPLAIN ANALYZE
To: jian he <jian.universality@gmail.com>
Cc: Andrei Lepikhov <a.lepikhov@postgrespro.ru>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Andy Fan <zhihui.fan1213@gmail.com>, David Rowley <dgrowleyml@gmail.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAExHW5t4f0K6JrE1Yj3zzOJ3_FDb1M0eFpOVnANFUQ3e9WXwYA%40mail.gmail.com>
Precedence: bulk

On Mon, Dec 11, 2023 at 2:06=E2=80=AFPM jian he <jian.universality@gmail.co=
m> wrote:
>
> On Mon, Dec 4, 2023 at 3:24=E2=80=AFPM Ashutosh Bapat
> <ashutosh.bapat.oss@gmail.com> wrote:
> >
> > On Fri, Dec 1, 2023 at 8:27=E2=80=AFAM Andrei Lepikhov
> > <a.lepikhov@postgrespro.ru> wrote:
> > >
> > > On 30/11/2023 18:40, Alvaro Herrera wrote:
> > > > Well, SUMMARY is enabled by default with ANALYZE, and I'd rather no=
t
> > > > have planner memory consumption displayed by default with all EXPLA=
IN
> > > > ANALYZEs.  So yeah, I still think this deserves its own option.
> > > >
> > > > But let's hear others' opinions on this point.  I'm only one vote h=
ere.
> > >
> > > I agree; it should be disabled by default. The fact that memory
> > > consumption outputs with byte precision (very uncomfortable for
> > > perception) is a sign that the primary audience is developers and for
> > > debugging purposes.
> >
> > That's 2 vs 1. Here's patch with MEMORY option added. Replying to
> > Alvaro's earlier relevant comments.
> >
>
> "Include information on planner's memory consumption. Specially,
> include the total memory allocated by the planner and net memory that
> remains used at the end of the planning. It defaults to
> <literal>FALSE</literal>.
> "
> doc/src/sgml/ref/explain.sgml
> I can view MemoryContextSizeDifference, figure out the meaning.
>
> But I am not sure "net memory that remains used at the end of the
> planning" is the correct description.
> (I am not native english speaker).

The word "net" is used as an adjective, see [1]

[1] https://www.merriam-webster.com/dictionary/net (as an adjective)

Does that help? Do you have any other wording proposal?

--=20
Best Wishes,
Ashutosh Bapat