MIME-Version: 1.0
References: <CAExHW5ujRhbOz6_aTq_jQA8NjeFqq9d_8G9viShWvXx8gdSXiQ@mail.gmail.com>
 <CAA4eK1JLRiW_Mkps+oGu_a1DZHJqhoXV9Ru33B4hV5UYUtLPJg@mail.gmail.com>
 <CALDaNm1bfwt=hmZD7V17t-giJLw3kndLBxLzSD+oSXNfMmGVsw@mail.gmail.com>
 <CAExHW5sqY8AS5WqyTD1v=V+pAZvtHXcZ5++2z1fn7NcpBmhj_g@mail.gmail.com>
 <CALDaNm0fWoS7eX9o3iVq8NwynpvAKKFK0YPEXWDTgBEOOjvFkw@mail.gmail.com>
 <OS0PR01MB57161E8D61ACCF34D505FBDA9425A@OS0PR01MB5716.jpnprd01.prod.outlook.com>
 <CALDaNm14bBNi60JaveK-WDgjYsDxa5ArRWzj2JrjQgc9CBzYiw@mail.gmail.com>
 <CAA4eK1J-_g8ruuOKTXA7sGjRASBG7XsXpHzpz324ygEd+HmsvA@mail.gmail.com>
 <CALDaNm3Hj72XtEcn_nRm4t4c59gaYCJk=-aeaJT47ktoAmBUNQ@mail.gmail.com>
 <CAA4eK1LA=gb0xyg+-93WJOX1EEJE8qroPQnNw==DreuW2VDm7g@mail.gmail.com> <CAA4eK1KPvbtpCJUuU6ZaZ=6BuBEvAzLCHNniNG98g0tOo3CkNA@mail.gmail.com>
In-Reply-To: <CAA4eK1KPvbtpCJUuU6ZaZ=6BuBEvAzLCHNniNG98g0tOo3CkNA@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 5 Jul 2023 19:20:06 +0530
Message-ID: <CAExHW5tcfvvwrKP4TtHFetBd0mc3CPpjsSDbjz3HYQJCcGc4JA@mail.gmail.com>
Subject: Re: pg_decode_message vs skip_empty_xacts and xact_wrote_changes
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>, 
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAExHW5tcfvvwrKP4TtHFetBd0mc3CPpjsSDbjz3HYQJCcGc4JA%40mail.gmail.com>
Precedence: bulk

On Wed, Jul 5, 2023 at 2:29=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.com=
> wrote:
>
> On Wed, Jul 5, 2023 at 2:28=E2=80=AFPM Amit Kapila <amit.kapila16@gmail.c=
om> wrote:
> >
> > On Mon, Jul 3, 2023 at 4:49=E2=80=AFPM vignesh C <vignesh21@gmail.com> =
wrote:
> > >
> > > +1 for the first version patch, I also felt the first version is
> > > easily understandable.
> > >
> >
> > Okay, please find the slightly updated version (changed a comment and
> > commit message). Unless there are more comments, I'll push this in a
> > day or two.
> >
>
> oops, forgot to attach the patch.

I still think that we need to do something so that a new call to
pg_output_begin() automatically takes care of the conditions under
which it should be called. Otherwise, we will introduce a similar
problem in some other place in future.

--=20
Best Wishes,
Ashutosh Bapat