MIME-Version: 1.0
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Mon, 24 Mar 2025 17:11:45 +0530
Message-ID: 
 <CAExHW5ti5igDwOOde6shgfS7JPtCY9gNrkB3xNr=FuGTYVDSjQ@mail.gmail.com>
Subject: pg_restore documentation and --create/--single-transaction limitation
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000075bb5006311517ce"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5ti5igDwOOde6shgfS7JPtCY9gNrkB3xNr%3DFuGTYVDSjQ%40mail.gmail.com>
Precedence: bulk

--00000000000075bb5006311517ce
Content-Type: text/plain; charset="UTF-8"

Hi All,
The pg_restore documentation usually mentions the pair of switches
which can not be used together. However, it does not mention that
--create and --single-transaction can not be used together. Here's a
patch fixing the same.

Looking for a precedence, I found that we have mentioned a similar
limitation concerning --data-only and --schema-only only under
--schema and not at both the sections. Maybe it's missing or we chose
to mention it only at one place. But then I am not sure which one
place I should use to mention the new limitation. So, I have added the
note in the sections corresponding to both the switches so that a user
reading either of them knows about the limitation.

-- 
Best Wishes,
Ashutosh Bapat

--00000000000075bb5006311517ce
Content-Type: text/x-patch; charset="US-ASCII";
	name="0001-pg_restore-documentation-correction-20250324.patch"
Content-Disposition: attachment;
	filename="0001-pg_restore-documentation-correction-20250324.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m8mzxwpc0>
X-Attachment-Id: f_m8mzxwpc0

RnJvbSBlOWVmYTI3Njg4Y2IwZjg1ODI1ZmQ3Y2RhMDIxMTg4MThhMWVkZWFlIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdt
YWlsLmNvbT4KRGF0ZTogTW9uLCAyNCBNYXIgMjAyNSAxNjo1OToxNiArMDUzMApTdWJqZWN0OiBb
UEFUQ0hdIHBnX3Jlc3RvcmUgZG9jdW1lbnRhdGlvbiBjb3JyZWN0aW9uCgotLWNyZWF0ZSBhbmQg
LS1zaW5nbGUtdHJhbnNhY3Rpb24gc3dpdGNoZXMgY2Fubm90IGJlIHNwZWNpZmllZCB0b2dldGhl
ci4gQnV0Ci0tcGdfcmVzdG9yZSBkb2N1bWVudGF0aW9uIGRvZXMgbm90IG1lbnRpb24gdGhpcy4g
Rml4IHRoZSBkb2N1bWVudGF0aW9uLgoKQXV0aG9yOiBBc2h1dG9zaCBCYXBhdAotLS0KIGRvYy9z
cmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21sIHwgNyArKysrKystCiAxIGZpbGUgY2hhbmdlZCwg
NiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL3NyYy9zZ21s
L3JlZi9wZ19yZXN0b3JlLnNnbWwgYi9kb2Mvc3JjL3NnbWwvcmVmL3BnX3Jlc3RvcmUuc2dtbApp
bmRleCAzNTE0MDE4NzgwNy4uMWFlMjhjYjhlZmIgMTAwNjQ0Ci0tLSBhL2RvYy9zcmMvc2dtbC9y
ZWYvcGdfcmVzdG9yZS5zZ21sCisrKyBiL2RvYy9zcmMvc2dtbC9yZWYvcGdfcmVzdG9yZS5zZ21s
CkBAIC0xNDgsNiArMTQ4LDEwIEBAIFBvc3RncmVTUUwgZG9jdW1lbnRhdGlvbgogICAgICAgICA8
Y29tbWFuZD5DUkVBVEUgREFUQUJBU0U8L2NvbW1hbmQ+IGNvbW1hbmRzLiAgQWxsIGRhdGEgaXMg
cmVzdG9yZWQgaW50byB0aGUKICAgICAgICAgZGF0YWJhc2UgbmFtZSB0aGF0IGFwcGVhcnMgaW4g
dGhlIGFyY2hpdmUuCiAgICAgICAgPC9wYXJhPgorCisgICAgICAgPHBhcmE+CisgICAgICAgIFRo
aXMgb3B0aW9uIGNhbm5vdCBiZSB1c2VkIHdpdGggPG9wdGlvbj4tLXNpbmdsZS10cmFuc2FjdGlv
bjwvb3B0aW9uPi4KKyAgICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3RpdGVtPgogICAgICA8L3Zh
cmxpc3RlbnRyeT4KIApAQCAtNjE4LDcgKzYyMiw4IEBAIFBvc3RncmVTUUwgZG9jdW1lbnRhdGlv
bgogICAgICAgICBlbWl0dGVkIGNvbW1hbmRzIGluIDxjb21tYW5kPkJFR0lOPC9jb21tYW5kPi88
Y29tbWFuZD5DT01NSVQ8L2NvbW1hbmQ+KS4gIFRoaXMKICAgICAgICAgZW5zdXJlcyB0aGF0IGVp
dGhlciBhbGwgdGhlIGNvbW1hbmRzIGNvbXBsZXRlIHN1Y2Nlc3NmdWxseSwgb3Igbm8KICAgICAg
ICAgY2hhbmdlcyBhcmUgYXBwbGllZC4gVGhpcyBvcHRpb24gaW1wbGllcwotICAgICAgICA8b3B0
aW9uPi0tZXhpdC1vbi1lcnJvcjwvb3B0aW9uPi4KKyAgICAgICAgPG9wdGlvbj4tLWV4aXQtb24t
ZXJyb3I8L29wdGlvbj4uIFRoaXMgb3B0aW9uIGNhbm5vdCBiZSB1c2VkIHdpdGgKKyAgICAgICAg
PG9wdGlvbj4tLWNyZWF0ZTwvb3B0aW9uPi4KICAgICAgICA8L3BhcmE+CiAgICAgICA8L2xpc3Rp
dGVtPgogICAgICA8L3Zhcmxpc3RlbnRyeT4KCmJhc2UtY29tbWl0OiAxOWM2ZWIwNmM1MWY0ZGE3
MGUyZWEwZjFiZGI2NGEwMTQyZThlMmFhCi0tIAoyLjM0LjEKCg==
--00000000000075bb5006311517ce--