MIME-Version: 1.0
References: <20260630173053.51.noahmisch@microsoft.com>
 <CAExHW5sjypF-x1rcutfwxafBxw1mKt4FAQRMFTafMQaZQXAUAg@mail.gmail.com>
 <CAExHW5tdnJDhUUXZ9V8n7aBnW2hqRC0MZgsHnuZj092om3PhQg@mail.gmail.com>
 <CAExHW5sgk_QrxY475uYqrPyW_tMripfM3Z2OoUkkmkj8E_vECg@mail.gmail.com>
 <517efb40-dcf8-4ff5-bfa6-c2bbf18ff64e@eisentraut.org>
In-Reply-To: <517efb40-dcf8-4ff5-bfa6-c2bbf18ff64e@eisentraut.org>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 8 Jul 2026 18:59:33 +0530
Message-ID: 
 <CAExHW5tqKgVxNP7ecQUXRnDwFpKFCa1MdkQCrFEfi91rzQBS9g@mail.gmail.com>
Subject: Re: Wrong query result w/ propgraph single lateral col reference
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Noah Misch <noah@leadboat.com>, pgsql-hackers@postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5tqKgVxNP7ecQUXRnDwFpKFCa1MdkQCrFEfi91rzQBS9g%40mail.gmail.com>
Precedence: bulk

On Wed, Jul 8, 2026 at 2:35=E2=80=AFPM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
>
> I would like this code to be organized differently.  Note that the
> existing insert_*_record functions don't do any error checking; they are
> just there to make catalog modifications.  There are various check_*
> functions that pretty much correspond to syntax rule checks, but these
> are run after the catalog changes, hence the present issue.  Maybe we
> should have a set of "pre-check" functions in addition?
>

I chose to perform the checks in insert_*_record() functions to keep
them at a central place instead of dispersing all over like the
check_* functions. The latter need to peform their checks considering
the overall shape of the property graph, however, the specification
checks are fairly local - like duplicate property or label names
specified in the same command or duplicate labels being inserted -
they won't usually need checks across labels or elements for example.
I am afraid we might have to sprinkle pre_check_* functions at
multiple places - thus leading to a risk of missing places as this
code evolves.

Do you expect insert_element_record() to perform sanity checks of
labels or insert_label_record() to perform sanity checks on
properties? Or do you expect a hierarchy of pre_check_ functions
cascading from elements to labels to properties?

--=20
Best Wishes,
Ashutosh Bapat