MIME-Version: 1.0
References: <DFCDD5H4J7VX.3GJKRBBDCKQ86@jeltef.nl>
In-Reply-To: <DFCDD5H4J7VX.3GJKRBBDCKQ86@jeltef.nl>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 31 Dec 2025 19:24:12 +0530
Message-ID: 
 <CAExHW5tuJTmuikfkabWq+mvomucY3iQ_vV-10KAsZWM7Yg6tvg@mail.gmail.com>
Subject: Re: Add "format" target to make and ninja to run pgindent and
 pgperltidy
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Daniel Gustafsson <daniel@yesql.se>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5tuJTmuikfkabWq%2BmvomucY3iQ_vV-10KAsZWM7Yg6tvg%40mail.gmail.com>
Precedence: bulk

On Wed, Dec 31, 2025 at 5:06=E2=80=AFPM Jelte Fennema-Nio <postgres@jeltef.=
nl> wrote:
>
> This tries to make running formatting a lot easier for committers, but
> primarily for new contributors. You can not format the files by simply
> running one of the folowing:
>
> make format
> ninja -C build format
>

I generally like the idea. Since perltidy is not enforced regularly
(like pgindent), running it usually ends up modifying files which are
not part of the patch. So I avoid it if not necessary. Do you propose
to make it optional?

--=20
Best Wishes,
Ashutosh Bapat