MIME-Version: 1.0
References: 
 <CAHg+QDckbpX_Lk-6bz5JA+Bd1+KfsO0=9r0hPZt8X+PX6kbWFw@mail.gmail.com>
 <CAExHW5uBe5QhZMmY68pv8RtvZxhejqB+D6Sr6bs=v17bTtaD+w@mail.gmail.com>
 <CAHg+QDdYq0NNF2ueLd1Hvn2njtJL2-MONd-=6REM6_4fHRTnhQ@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDdYq0NNF2ueLd1Hvn2njtJL2-MONd-=6REM6_4fHRTnhQ@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Thu, 23 Apr 2026 14:59:49 +0530
Message-ID: 
 <CAExHW5tz11k1REwVB2HP04bUPbS22JL0LSjUQWEs56J66AHVsQ@mail.gmail.com>
Subject: Re: [Patch] Block ALTER TABLE RENAME COLUMN when column is used by
 property graph
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5tz11k1REwVB2HP04bUPbS22JL0LSjUQWEs56J66AHVsQ%40mail.gmail.com>
Precedence: bulk

On Thu, Apr 23, 2026 at 1:09=E2=80=AFPM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
>
> Hi
>
> On Thu, Apr 23, 2026 at 12:33=E2=80=AFAM Ashutosh Bapat <ashutosh.bapat.o=
ss@gmail.com> wrote:
>>
>> On Thu, Apr 23, 2026 at 12:23=E2=80=AFPM SATYANARAYANA NARLAPURAM
>> <satyanarlapuram@gmail.com> wrote:
>> >
>> > Hi hackers,
>> >
>> > When a table column is referenced by a property graph, the property
>> > name stored in pg_propgraph_property.pgpname would become stale after
>> > a column rename.  This caused GRAPH_TABLE queries to fail with the new
>> > column name ("property does not exist") while the old (dead) name
>> > continued to work.  pg_get_propgraphdef() would also emit confusing
>> > output like "new_col AS old_col".
>>
>> This behaviour is inline with the behaviour of view.
>>
>> #create view vt as select a from t1;
>> CREATE VIEW
>> #\d+ vt
>>                              View "public.vt"
>>  Column |  Type   | Collation | Nullable | Default | Storage | Descripti=
on
>> --------+---------+-----------+----------+---------+---------+----------=
---
>>  a      | integer |           |          |         | plain   |
>> View definition:
>>  SELECT a
>>    FROM t1;
>>
>> #alter table t1 rename column a TO aa;
>> ALTER TABLE
>> #\d+ vt
>>                              View "public.vt"
>>  Column |  Type   | Collation | Nullable | Default | Storage | Descripti=
on
>> --------+---------+-----------+----------+---------+---------+----------=
---
>>  a      | integer |           |          |         | plain   |
>> View definition:
>>  SELECT aa AS a
>>    FROM t1;
>>
>> Name of the property is derived from the name of the column it
>> references if the property name is not specified at the time of
>> creating the property. But these two are different. Changing column
>> name can not be expected to change the property name automatically. If
>> two elements have the same label, the set of property names associated
>> with that label is expected to be the same for those two elements as
>> well.
>
>
> Ashutosh, should we document this or it is a well known fact and not need=
ed? Asking in the context of Graphs, not views.

I don't think we need to document it.

--
Best Wishes,
Ashutosh Bapat