MIME-Version: 1.0
References: <CAExHW5vvhhtdv-LctC5Wz-yuyh1me3KtvyuOqX48BRQicDGTJg@mail.gmail.com>
 <20230717142452.74yml7mfqkypfixp@alvherre.pgsql> <CAA4eK1+A3h9rmboKA9UH_Fzbw+zJax1WPxgtme=kfvp-8chG6w@mail.gmail.com>
 <CAD21AoC0zZqxHPb44akZg2+SzkUrrG23p01NvK=Binkc67sCeg@mail.gmail.com>
 <CAA4eK1KG9C5vkjQSVi-omT1QJsDoZDnBEiY+rVfNQbqKz0UtYw@mail.gmail.com>
 <CAExHW5uiKkfW8b6uLuAqjsiiGLTeU2ZRpPkPfzhwrpUmHT3SAA@mail.gmail.com>
 <CAA4eK1JQB=musr4+HA_3WvnUYrRsir2zQ2Ks0au+Za3y_kQqMQ@mail.gmail.com> <CAA4eK1JzHWjdDu1Qzh6Tpb3zD3v_Sku7Yn=ATP=Kb8yiM3onRw@mail.gmail.com>
In-Reply-To: <CAA4eK1JzHWjdDu1Qzh6Tpb3zD3v_Sku7Yn=ATP=Kb8yiM3onRw@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Thu, 20 Jul 2023 22:09:31 +0530
Message-ID: <CAExHW5uALEHb=j_n9ar-bWwQ3WXD7J00EkHDGi=zqwPjtfQoyw@mail.gmail.com>
Subject: Re: logicalrep_message_type throws an error
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, 
	Euler Taveira <euler@eulerto.com>, pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/CAExHW5uALEHb%3Dj_n9ar-bWwQ3WXD7J00EkHDGi%3DzqwPjtfQoyw%40mail.gmail.com>
Precedence: bulk

On Thu, Jul 20, 2023 at 9:11=E2=80=AFAM Amit Kapila <amit.kapila16@gmail.co=
m> wrote:
> >
> > Okay, changed it accordingly.
> >
>
> oops, forgot to attach the patch.
>

WFM

@@ -3367,7 +3367,7 @@ apply_dispatch(StringInfo s)
         default:
             ereport(ERROR,
                     (errcode(ERRCODE_PROTOCOL_VIOLATION),
-                     errmsg("invalid logical replication message type
\"%c\"", action)));
+                     errmsg("invalid logical replication message type
\"??? (%d)\"", action)));

I think we should report character here since that's what is visible
in the code and also the message types are communicated as characters
not integers. Makes debugging easier. Context may report integer as an
additional data point.

--=20
Best Wishes,
Ashutosh Bapat