MIME-Version: 1.0
References: 
 <CAExHW5vM1bneLYfg0wGeAa=52UiJ3z4vKd3AJ72X8Fw6k3KKrg@mail.gmail.com>
 <8a6799be-bd42-49fb-8914-856c97bb1977@iki.fi>
 <CA+Tgmob8ot7qam7a650nx_4jyEoFLs8s_kPMc1+EB7-dr56=WA@mail.gmail.com>
 <cc3ff976-c303-45cd-9a8d-a90483170e37@iki.fi>
 <CA+TgmoauqYXm8iA3FGRAVKxYShUxWBiS_MSLmQpTrmO7wNHamw@mail.gmail.com>
 <113724ab-0028-493f-9605-6e8570f0939f@iki.fi>
 <CAExHW5uTNWOSxJDWQAUnS0tZawob2_J3dRAtc67NHNZ98X4_xA@mail.gmail.com>
 <CAExHW5t439y61YD9bc7d5wZWHp6J=M43Qu3eEZOBPguZML7o2A@mail.gmail.com>
 <CAExHW5v5FVZbsO9sLzztMZ11C3hgGStE=HkkV2bQkCyncess4w@mail.gmail.com>
 <b2451225-0a10-4ded-abef-4e9efbde7a8e@iki.fi>
 <CAExHW5tCC0T1ky=Jnq-AvMxa67Adaw7aQ4iQAO=BSdHcbSNBVg@mail.gmail.com>
 <791c3f18-f4de-4d84-ac6b-c7ccc074dd38@iki.fi>
 <CAExHW5tS7GncN90oJWOSzW_3F1EHL9xwe59L7Req3nUVgmObUw@mail.gmail.com>
 <9d919bd9-94dd-4bda-8ccf-ebced4178c53@iki.fi>
 <CAExHW5sYgt=XekOoAE-Tu_Dv8obWZCjCqAPT9vtN2D4m=M=drQ@mail.gmail.com>
 <470e7ebe-0971-49f6-8e46-9b8f6395f88b@iki.fi>
 <87y0iz2c1v.fsf@wibble.ilmari.org>
 <4297b4ee-5248-415f-ae12-abf2a23f4ab6@iki.fi>
In-Reply-To: <4297b4ee-5248-415f-ae12-abf2a23f4ab6@iki.fi>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Tue, 7 Apr 2026 19:49:28 +0530
Message-ID: 
 <CAExHW5uMQGvQH6GKaBZVtH4S9O13TwN+_0Vy1gUpAW=_T_AmRA@mail.gmail.com>
Subject: Re: Better shared data structure management and resizable shared data
 structures
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>,
	Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
	pgsql-hackers <pgsql-hackers@postgresql.org>, chaturvedipalak1911@gmail.com
Content-Type: multipart/mixed; boundary="0000000000006b12a5064edf79c0"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5uMQGvQH6GKaBZVtH4S9O13TwN%2B_0Vy1gUpAW%3D_T_AmRA%40mail.gmail.com>
Precedence: bulk

--0000000000006b12a5064edf79c0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Heikki,
CallShmemCallbacksAfterStartup() holds ShmemIndexLock while invoking
init_fn/attach_fn callbacks. That looks wrong. Before this commit,
init or attach code was not run with the lock held. Any reason the
lock is held while calling init and attach callbacks. Since these
function can come from extensions, we don't have control on what goes
in those functions, and thus looks problematic. Further, it will
serialize all the attach_fn executions across backends, since each
will be run under the lock. In my case, the init_fn was performing
ShmemIndex lookup which deadlocked. It's questionable whether init
function should lookup ShmemIndex but, it's not something that needs
to be prohibited either.

Here's patch fixing it.

--
Best Wishes,
Ashutosh Bapat

On Tue, Apr 7, 2026 at 6:56=E2=80=AFPM Heikki Linnakangas <hlinnaka@iki.fi>=
 wrote:
>
> On 07/04/2026 15:24, Dagfinn Ilmari Manns=C3=A5ker wrote:
> > Heikki Linnakangas <hlinnaka@iki.fi> writes:
> >
> >> Those are now committed, and here's a new version rebased over those
> >> changes.
> >
> > I noticed this bit during my habitual morning skim of new commits:
> >
> >> diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/ut=
ils/misc/injection_point.c
> >> index c06b0e9b800..9981d6e212f 100644
> >> --- a/src/backend/utils/misc/injection_point.c
> >> +++ b/src/backend/utils/misc/injection_point.c
> >> @@ -17,6 +17,7 @@
> >>    */
> >>   #include "postgres.h"
> >>
> >> +#include "storage/subsystems.h"
> >>   #include "utils/injection_point.h"
> >>
> >>   #ifdef USE_INJECTION_POINTS
> >> @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry
> >>
> >>   static HTAB *InjectionPointCache =3D NULL;
> >>
> >> +#ifdef USE_INJECTION_POINTS
> >> +static void InjectionPointShmemRequest(void *arg);
> >> +static void InjectionPointShmemInit(void *arg);
> >> +#endif
> >> +
> >
> > This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact
> > visible at the end of the previous diff hunk), no need for another one.
>
> Fixed, thanks. I also noticed that the #include "storage/subsystems.h"
> can be moved inside the #ifdef block; fixed that too.
>
> - Heikki
>

--0000000000006b12a5064edf79c0
Content-Type: text/x-patch; charset="US-ASCII";
	name="v20260407-0001-Unlock-ShmemIndexLock-before-calling-init_.patch"
Content-Disposition: attachment;
	filename="v20260407-0001-Unlock-ShmemIndexLock-before-calling-init_.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mnopgg4c0>
X-Attachment-Id: f_mnopgg4c0

RnJvbSBmMDhiZjk0YjRmMThjN2FlYTljNmU3ZDNmMzIxYzE1M2RhN2E3NmQ4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdt
YWlsLmNvbT4KRGF0ZTogVHVlLCA3IEFwciAyMDI2IDE5OjI0OjE1ICswNTMwClN1YmplY3Q6IFtQ
QVRDSCB2MjAyNjA0MDddIFVubG9jayBTaG1lbUluZGV4TG9jayBiZWZvcmUgY2FsbGluZyBpbml0
X2ZuCiBjYWxsYmFjawoKQ2FsbFNobWVtQ2FsbGJhY2tzQWZ0ZXJTdGFydHVwKCkgY2FsbHMgaW5p
dF9mbiBvciBhdHRhY2hfZm4gY2FsbGJhY2tzCndoaWxlIGhvbGRpbmcgU2htZW1JbmRleExvY2su
IFRob3NlIGNhbGxiYWNrcyBkbyBub3QgcmVxdWlyZSB0aGUgbG9jayB0bwpiZSBoZWxkLiBCZWZv
cmUgZDQ4ODVhZjNkNjUzMjVjMWZjZDMxOWU5OGM2MzRmZGU5YTIwMDQ0MywgY29kZQppbml0aWFs
aXppbmcgdGhlIHNoYXJlZCBzdHJ1Y3R1cmVzIGV4ZWN1dGVkIHdpdGhvdXQgaG9sZGluZwpTaG1l
bUluZGV4TG9jay4KCk9uIHRoZSBvdGhlciBoYW5kLCB0aG9zZSBjYWxsYmFja3MgbWF5IGJlIHBl
cmZvcm1pbmcgbG9uZyBydW5uaW5nCm9wZXJhdGlvbnMgbGlrZSBkaXNrIGFjY2VzcyBlLmcuIHBn
c3Nfc2htZW1faW5pdC4gSG9sZGluZyBhIGxpZ2h0d2VpZ2h0CmxvY2sgdGhhdCBsb25nIHNob3Vs
ZCBiZSBhdm9pZGVkLCBpZiBwb3NzaWJsZS4gSXQgd2lsbCBjYXVzZSBhIGRlbGF5IGluCmxvYWRp
bmcgYW4gZXh0ZW5zaW9uIGluIGFsbCB0aGUgYmFja2VuZHMgc2luY2UgYWxsIGF0dGFjaF9mbnMg
d2lsbCBiZQpzZXJpYWxpemVkLgoKQXV0aG9yOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFw
YXQub3NzQGdtYWlsLmNvbT4KLS0tCiBzcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9zaG1lbS5jIHwg
MyArKy0KIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRp
ZmYgLS1naXQgYS9zcmMvYmFja2VuZC9zdG9yYWdlL2lwYy9zaG1lbS5jIGIvc3JjL2JhY2tlbmQv
c3RvcmFnZS9pcGMvc2htZW0uYwppbmRleCAxZWJmZmU1YTMyYS4uNjZiOTU3MTMwMjAgMTAwNjQ0
Ci0tLSBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvaXBjL3NobWVtLmMKKysrIGIvc3JjL2JhY2tlbmQv
c3RvcmFnZS9pcGMvc2htZW0uYwpAQCAtOTU2LDYgKzk1Niw4IEBAIENhbGxTaG1lbUNhbGxiYWNr
c0FmdGVyU3RhcnR1cChjb25zdCBTaG1lbUNhbGxiYWNrcyAqY2FsbGJhY2tzKQogCWxpc3RfZnJl
ZV9kZWVwKHBlbmRpbmdfc2htZW1fcmVxdWVzdHMpOwogCXBlbmRpbmdfc2htZW1fcmVxdWVzdHMg
PSBOSUw7CiAKKwlMV0xvY2tSZWxlYXNlKFNobWVtSW5kZXhMb2NrKTsKKwogCS8qIEZpbmlzaCBi
eSBjYWxsaW5nIHRoZSBhcHByb3ByaWF0ZSBzdWJzeXN0ZW0tc3BlY2lmaWMgY2FsbGJhY2sgKi8K
IAlpZiAoZm91bmRfYW55KQogCXsKQEAgLTk2OCw3ICs5NzAsNiBAQCBDYWxsU2htZW1DYWxsYmFj
a3NBZnRlclN0YXJ0dXAoY29uc3QgU2htZW1DYWxsYmFja3MgKmNhbGxiYWNrcykKIAkJCWNhbGxi
YWNrcy0+aW5pdF9mbihjYWxsYmFja3MtPm9wYXF1ZV9hcmcpOwogCX0KIAotCUxXTG9ja1JlbGVh
c2UoU2htZW1JbmRleExvY2spOwogCXNobWVtX3JlcXVlc3Rfc3RhdGUgPSBTUlNfRE9ORTsKIH0K
IAoKYmFzZS1jb21taXQ6IDI5ZTdkYmY1ZTRkYWE4ZmFmYzJiMThhMTU1MWU3YjMxYzg4NDczNDAK
LS0gCjIuMzQuMQoK
--0000000000006b12a5064edf79c0--