Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsAhx-009EuI-1J for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 02:21:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1vsAhv-007J4x-21 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Feb 2026 02:20:59 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vsAhv-007J4p-16 for pgsql-hackers@lists.postgresql.org; Tue, 17 Feb 2026 02:20:59 +0000 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1vsAht-000000017aY-0yhq for pgsql-hackers@postgresql.org; Tue, 17 Feb 2026 02:20:59 +0000 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-4376c0bffc1so2809676f8f.0 for ; Mon, 16 Feb 2026 18:20:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771294856; cv=none; d=google.com; s=arc-20240605; b=VUERoHDQaW0xtGrWP5VlsSj9SHb8+uxAbms7l0EpugUS0p6XFoY1oA9eQ02lLQcpQB drNS6wxZsjgup7V2mt2Ggio6sUbow7w6Qh70rD1UFiDvN+bvfMRgLaelQyTbyAOrRKcS +xNsRcVsbVfS2FBtPo9AMgnVCNF/dtbNBrR2YOsQRQey+kMhEjBfRzkjZoMzPYU0+ewc 766C3pDM4YpuGJZsBy4tUS+3EbX5KUoMYUNmAQ12Sy4rets+OM002JcNk5oAqCf/3YOa JzY8lLDpRWZI/jbRaZl0mQlRUJUXKX4zIsFxxec2CiTj3mP3URdqUOd/TW3s+AqS7XsF rw4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qHVtVeDy4dLRe6xQG71DBSpTRDbkwwXaNQeBZANfl7s=; fh=cmL6maNWJ7vQ0YngO+JnmpLKEecAjutcDV+N95mubZU=; b=N0EIdv4CXdwXTu4lNwlVE7BUMPqM17PgrzQhrg8M9j6lpuA0AHYaFbxpfN5lBmtFtT wSBoOuI9FGUoJqUe3dw03xw8MgVB6KrxGyH/eH7wWb6HuB/DTnXt1xquwa6DDbF5JdnY TLvP+VYhYiK8LJc1xCxa8W+MM/Mph2oPBCa/dpt62fxS4RkO2Surk1BavP2dbnV7IV6U OgsTzRh9KwVyIY/MV8tbolPyI7YQBxegYmo39LvdG8r/1XDzAcmRUzk272vka0ydB0qW cXZaB1fgJVtg2H2DgHh2iQ4fStZngd68+e+7NDHIFaHspHncg9Kz6netUz0EKS2+32EL WzKQ==; darn=postgresql.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771294856; x=1771899656; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qHVtVeDy4dLRe6xQG71DBSpTRDbkwwXaNQeBZANfl7s=; b=GQpXXguL1gjtVqubXFSyCsH31meC220MxLlxtoGNL+N+EnWCHVymGjC+c30kpdoeua MGeijnJmVql4Zcr7bvb0loCogmJdfl+zojjhK9lgLdyxZ/kUwJKWRIIsP3RTXe3Q9W/j TbYgtUPhuscp3nj0/bHu5qmF2qDnhn3jIpi8VBigNT0Neyc5ChxewvEnIXtTguuhziNB tFFKd+bZ/hlc61J3eoKOENMwJGqhffrZMNfgdcPcpiOGMc/Knzl6kageeWNVYQca54fM /R2Jq0/P89p2yqJhtgfuq0agECZALbrfPY8Fajmie0ZjQmJ1/MM457/emE0Dr4VrNLup 4cGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771294856; x=1771899656; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qHVtVeDy4dLRe6xQG71DBSpTRDbkwwXaNQeBZANfl7s=; b=NFX0yZgwejMPUogGe8g9etrk+jFWfepamaXikx8aHm54J+Aechi/jH5r5kMovxwMTd Gagf7WZtt3QPfuDdoHVPVyP13UgwJr78NP2XTLfh8wJRZ24b0sLze7jNjyjKp3VaHqDQ pAwn7U69okucw7jPU5wWMva8IZTKpWJiQRPaZY6jpiDEb/uvxlG1fegtKFCRED269CMC vK8BjuZ5QWSQ5yErMW7GGzhWacZvTK50xjTUz1ny3KW9PqvlJPC6E3LWXPLSWQSSJfVT l0goyjSBDkqUdpXq3kcde7ZWrWHUe0YxB0d60Sh6DXVaJ4jWiqP5VdVeuiDl9yjI9ikX TZWA== X-Forwarded-Encrypted: i=1; AJvYcCVL5CvswXSNF63ylM9x8ZrpEv+wjHxRods0A00cLnAa0YyEqUMwcsmiKrF5XXYKJRnPXspCyIinrBBYAS+t@postgresql.org X-Gm-Message-State: AOJu0Yw9dFukYKM4pblZUTULslRSq9ij0Q5V8D0nwcgypEJBlKiHEqKs BacI9tVslFjtJxCxoqKQQKlIa2PTtWoPhT8oFcH+VvHKEsV9YtzaAp7pkt3SK5gBnXuA3uzDFlF O4IYCSzYvwcexanXR2PdTSvFOHzo5T6kx41kM X-Gm-Gg: AZuq6aIu30Jh89h5m+bqp1c1RKoo6Kuod8fNKVzxLZs63BMgFEBPoUhDAegdIbPuK+9 mRJ/Zqvp7H5yDo60M9diO8m0YEWb95RGmMqa5DIRZAoVGNTWuiFJ040eswMzq246ZnZMODCEJV3 llkCrtz+Cn0tPqXGsxu0cwvrE8VIH670jD8yvmc1WRid3U+NQAOwy5lHZTi31paO0PZ8OHfD77w Fk1Zu27tZ99yhLY2+Xdwxj+riGnPmFoPyMia1uVd1OU/DjXfnYcm3kk6Rv52wM1LBpTa+yPuEt7 3CjXSvhQuEjN4RD+KoDSyKPfvRWWQShI6E2Wf9J9w1n0ORfP/sw= X-Received: by 2002:a05:6000:1843:b0:436:30b0:759e with SMTP id ffacd0b85a97d-437978ddaa8mr23141165f8f.26.1771294855772; Mon, 16 Feb 2026 18:20:55 -0800 (PST) MIME-Version: 1.0 References: <3bd49b59-7a87-4ab6-9eac-59b5d9cb78de@dunslane.net> <1133418.1771260634@sss.pgh.pa.us> In-Reply-To: <1133418.1771260634@sss.pgh.pa.us> From: Ashutosh Bapat Date: Tue, 17 Feb 2026 07:50:42 +0530 X-Gm-Features: AaiRm53atUhtO7coiX__XSwgVEBOHad_-MQzH-F59oD5odwTaKC_EGT-Ksohjp4 Message-ID: Subject: Re: [PATCH] pgindent truncates last line of files missing a trailing newline To: Tom Lane Cc: Andrew Dunstan , Akshay Joshi , pgsql-hackers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Mon, Feb 16, 2026 at 10:20=E2=80=AFPM Tom Lane wrote= : > > Andrew Dunstan writes: > > Yeah. I wonder if we shouldn't be just ensuring that there is a line > > feed at the end of the buffer, i.e. add one if it's not there. We > > shouldn't be adding files without a trailing LF, and ensuring there is > > one seems like a reasonable thing to do in pg_bsd_indent. > > +1 +1. That will allow me to remove some code from my patch preparation script. Ref. [1] [1] https://www.postgresql.org/message-id/flat/CAExHW5v8u7-2H2LqWP3ybhh5GnA= VVeCOYuTfkg9pmdnrLwAtNA%40mail.gmail.com#fdbb87e825f89e7109dfb0ed959b2dd4 --=20 Best Wishes, Ashutosh Bapat