MIME-Version: 1.0
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Sat, 6 Jun 2026 13:37:42 +0530
Message-ID: 
 <CAExHW5uzRMYVZsXXS3HXXT0fG_sNrpUhUqwP4NorhaCqH9JDhA@mail.gmail.com>
Subject: GetBufferDescriptor() being called for local buffers from
 MarkBufferDirtyHint()
To: Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000045c0b7065391462e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5uzRMYVZsXXS3HXXT0fG_sNrpUhUqwP4NorhaCqH9JDhA%40mail.gmail.com>
Precedence: bulk

--00000000000045c0b7065391462e
Content-Type: text/plain; charset="UTF-8"

Hi Andres,

82467f627bd478569de04f4a3f1993098e80c812 added MarkBufferDirtyHint()
which invokes GetBufferDescriptor() even for local buffers for which
id < 0. Since GetBufferDescriptor() declares id as uint32, -1 is
converted to a very large int32 value which is way larger than
NBuffers. Thus GetBufferDescriptor() may be returning something from
the BufferBlocks which probably has enough memory to accommodate that
memory access. But it's a bogus BufferDesc nevertheless. We are not
seeing any problem with this right now since MarkBufferDirtyHint()
uses the BufferDesc only when it's a shared buffer. Right fix is to
let that function handle local buffers first and then call
GetBufferDescriptor() as in the attached patch.

I caught this because of an Assertion added in GetBufferDescription()
in my shared buffer resizing patches. I think it's worth committing
that assertion and the related change to BufferManagerShmemInit()
separately from shared buffer resizing patches. Included those changes
in the attached patch as well.


-- 
Best Wishes,
Ashutosh Bapat

--00000000000045c0b7065391462e
Content-Type: text/x-patch; charset="US-ASCII";
	name="v20260606-0001-MarkBufferDirtyHint-calls-GetBufferDescrip.patch"
Content-Disposition: attachment;
	filename="v20260606-0001-MarkBufferDirtyHint-calls-GetBufferDescrip.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mq22lfn80>
X-Attachment-Id: f_mq22lfn80

RnJvbSBmNjZkZDhkNTI2NDUxNzgwNzc1YWEyYTkxZGU3ZjE3ODFhZGJiYzczIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdt
YWlsLmNvbT4KRGF0ZTogU2F0LCA2IEp1biAyMDI2IDEzOjIxOjUwICswNTMwClN1YmplY3Q6IFtQ
QVRDSCB2MjAyNjA2MDYgMS82XSBNYXJrQnVmZmVyRGlydHlIaW50KCkgY2FsbHMKIEdldEJ1ZmZl
ckRlc2NyaXB0b3IoKSBmb3IgbG9jYWwgYnVmZmVycwoKODI0NjdmNjI3YmQ0Nzg1NjlkZTA0ZjRh
M2YxOTkzMDk4ZTgwYzgxMiBhZGRlZCBNYXJrQnVmZmVyRGlydHlIaW50KCkgd2hpY2gKaW52b2tl
cyBHZXRCdWZmZXJEZXNjcmlwdG9yKCkgZXZlbiBmb3IgbG9jYWwgYnVmZmVycyB3aGljaCBoYXZl
IG5lZ2F0aXZlIGJ1ZmZlcgppZGVudGlmaWVycy4gU2luY2UgR2V0QnVmZmVyRGVzY3JpcHRvcigp
IGRlY2xhcmVzIGlkIGFzIHVpbnQzMiwgYSBuZWdhdGl2ZQppbnRlZ2VyIHBhc3NlZCB0byBpdCBp
cyBjb252ZXJ0ZWQgdG8gYSAzMiBiaXQgaW50ZWdlciB2YWx1ZSB3aGljaCBpcyB3YXkgbGFyZ2Vy
CnRoYW4gTkJ1ZmZlcnMuIFRodXMgR2V0QnVmZmVyRGVzY3JpcHRvcigpIG1heSBiZSByZXR1cm5p
bmcgYSBwb2ludGVyIGluc2lkZQpCdWZmZXJCbG9ja3Mgd2hpY2ggcHJvYmFibHkgaGFzIGVub3Vn
aCBtZW1vcnkgdG8gYWNjb21tb2RhdGUgdGhhdCBtZW1vcnkgYWNjZXNzLgpCdXQgaXQncyBhIGJv
Z3VzIEJ1ZmZlckRlc2MgbmV2ZXJ0aGVsZXNzLiBXZSBhcmUgbm90IHNlZWluZyBhbnkgcHJvYmxl
bSB3aXRoCnRoaXMgcmlnaHQgbm93IHNpbmNlIE1hcmtCdWZmZXJEaXJ0eUhpbnQoKSB1c2VzIHRo
ZSByZXR1cm5lZCBCdWZmZXJEZXNjIG9ubHkKd2hlbiBpdCBpcyBhIHNoYXJlZCBidWZmZXIuIEZp
eCBpdCBieSBsZXR0aW5nIE1hcmtCdWZmZXJEaXJ0eUhpbnQoKSBoYW5kbGUgbG9jYWwKYnVmZmVy
cyBmaXJzdCBhbmQgdGhlbiBjYWxsaW5nIEdldEJ1ZmZlckRlc2NyaXB0b3IoKS4KCkluIG9yZGVy
IHRvIGNhdGNoIGJvZ3VzIEJ1ZmZlckRlc2NzIHJldHVybmVkIGJ5IEdldEJ1ZmZlckRlc2NyaXB0
b3IoKSwgYWRkIGFuCmFzc2VydGlvbiBpbiBHZXRCdWZmZXJEZXNjcmlwdGlvbigpIHRvIGNoZWNr
IHRoYXQgdGhlIGJ1ZmZlciBpZGVudGlmaWVyIGluIHRoZQpCdWZmZXJEZXNjIGlzIGluZGVlZCB0
aGUgZXhwZXRlZCBvbmUuIEJlY2F1c2Ugb2YgdGhpcyBhc3NlcnRpb24gd2UgY2FuIG5vdCByZWx5
Cm9uIHVzaW5nIEdldEJ1ZmZlckRlc2NyaXB0b3IoKSBpbiB0aGUgaW5pdGlhbGl6YXRpb24gY29k
ZS4gSGVuY2UgY2hhbmdlCkJ1ZmZlck1hbmFnZXJTaG1lbUluaXQoKSB0byBhY2Nlc3MgQnVmZmVy
RGVzY3JpcHRvcnMgZGlyZWN0bHkuCgpSZXBvcnRlZCBieTogQXNodXRvc2ggQmFwYXQgPGFzaHV0
b3NoLmJhcGF0Lm9zc0BnbWFpbC5jb20+CkF1dGhvcjogQXNodXRvc2ggQmFwYXQgPGFzaHV0b3No
LmJhcGF0Lm9zc0BnbWFpbC5jb20+Ci0tLQogc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvYnVm
X2luaXQuYyB8IDMgKystCiBzcmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9idWZtZ3IuYyAgIHwg
NCArKy0tCiBzcmMvaW5jbHVkZS9zdG9yYWdlL2J1Zl9pbnRlcm5hbHMuaCAgIHwgNiArKysrKy0K
IDMgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAt
LWdpdCBhL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYnVmZmVyL2J1Zl9pbml0LmMgYi9zcmMvYmFja2Vu
ZC9zdG9yYWdlL2J1ZmZlci9idWZfaW5pdC5jCmluZGV4IDE0MDdjOTMwYzU2Li41YjU3MDNlMTAx
MiAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvYnVmX2luaXQuYworKysg
Yi9zcmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9idWZfaW5pdC5jCkBAIC0xMjQsNyArMTI0LDgg
QEAgQnVmZmVyTWFuYWdlclNobWVtSW5pdCh2b2lkICphcmcpCiAJICovCiAJZm9yIChpbnQgaSA9
IDA7IGkgPCBOQnVmZmVyczsgaSsrKQogCXsKLQkJQnVmZmVyRGVzYyAqYnVmID0gR2V0QnVmZmVy
RGVzY3JpcHRvcihpKTsKKwkJLyogR2V0QnVmZmVyRGVzY3JpcHRvcigpIGV4cGVjdHMgYnVmX2lk
IHRvIGJlIHNldCBpbiB0aGUgZGVzY3JpcHRvci4gKi8KKwkJQnVmZmVyRGVzYyAqYnVmID0gJihC
dWZmZXJEZXNjcmlwdG9yc1tpXSkuYnVmZmVyZGVzYzsKIAogCQlDbGVhckJ1ZmZlclRhZygmYnVm
LT50YWcpOwogCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9zdG9yYWdlL2J1ZmZlci9idWZtZ3Iu
YyBiL3NyYy9iYWNrZW5kL3N0b3JhZ2UvYnVmZmVyL2J1Zm1nci5jCmluZGV4IGNjMzk4ZGIxMjRk
Li5kNmMwY2MxZjZkNCAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvYnVm
bWdyLmMKKysrIGIvc3JjL2JhY2tlbmQvc3RvcmFnZS9idWZmZXIvYnVmbWdyLmMKQEAgLTU4MzEs
OCArNTgzMSw2IEBAIE1hcmtCdWZmZXJEaXJ0eUhpbnQoQnVmZmVyIGJ1ZmZlciwgYm9vbCBidWZm
ZXJfc3RkKQogewogCUJ1ZmZlckRlc2MgKmJ1ZkhkcjsKIAotCWJ1ZkhkciA9IEdldEJ1ZmZlckRl
c2NyaXB0b3IoYnVmZmVyIC0gMSk7Ci0KIAlpZiAoIUJ1ZmZlcklzVmFsaWQoYnVmZmVyKSkKIAkJ
ZWxvZyhFUlJPUiwgImJhZCBidWZmZXIgSUQ6ICVkIiwgYnVmZmVyKTsKIApAQCAtNTg0Miw2ICs1
ODQwLDggQEAgTWFya0J1ZmZlckRpcnR5SGludChCdWZmZXIgYnVmZmVyLCBib29sIGJ1ZmZlcl9z
dGQpCiAJCXJldHVybjsKIAl9CiAKKwlidWZIZHIgPSBHZXRCdWZmZXJEZXNjcmlwdG9yKGJ1ZmZl
ciAtIDEpOworCiAJTWFya1NoYXJlZEJ1ZmZlckRpcnR5SGludChidWZmZXIsIGJ1ZkhkciwKIAkJ
CQkJCQkgIHBnX2F0b21pY19yZWFkX3U2NCgmYnVmSGRyLT5zdGF0ZSksCiAJCQkJCQkJICBidWZm
ZXJfc3RkKTsKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL3N0b3JhZ2UvYnVmX2ludGVybmFscy5o
IGIvc3JjL2luY2x1ZGUvc3RvcmFnZS9idWZfaW50ZXJuYWxzLmgKaW5kZXggODk2MTVhMjU0YTMu
LjEwMGI1MjcyYTdhIDEwMDY0NAotLS0gYS9zcmMvaW5jbHVkZS9zdG9yYWdlL2J1Zl9pbnRlcm5h
bHMuaAorKysgYi9zcmMvaW5jbHVkZS9zdG9yYWdlL2J1Zl9pbnRlcm5hbHMuaApAQCAtNDIxLDcg
KzQyMSwxMSBAQCBleHRlcm4gUEdETExJTVBPUlQgQnVmZmVyRGVzYyAqTG9jYWxCdWZmZXJEZXNj
cmlwdG9yczsKIHN0YXRpYyBpbmxpbmUgQnVmZmVyRGVzYyAqCiBHZXRCdWZmZXJEZXNjcmlwdG9y
KHVpbnQzMiBpZCkKIHsKLQlyZXR1cm4gJihCdWZmZXJEZXNjcmlwdG9yc1tpZF0pLmJ1ZmZlcmRl
c2M7CisJQnVmZmVyRGVzYyAqYmRlc2MgPSAmKEJ1ZmZlckRlc2NyaXB0b3JzW2lkXSkuYnVmZmVy
ZGVzYzsKKworCUFzc2VydChiZGVzYy0+YnVmX2lkID09IGlkKTsKKworCXJldHVybiBiZGVzYzsg
CiB9CiAKIHN0YXRpYyBpbmxpbmUgQnVmZmVyRGVzYyAqCgpiYXNlLWNvbW1pdDogODllYWZhZDI5
N2E5YjAxYWQ3N2NmYzFhYjkzYTQzM2UwYWY4OTRiMAotLSAKMi4zNC4xCgo=
--00000000000045c0b7065391462e--