public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Bapat <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Ayush Tiwari <[email protected]>
Cc: SATYANARAYANA NARLAPURAM <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [Bug] Add the missing RTE_GRAPH_TABLE case to transformLockingClause()
Date: Thu, 9 Jul 2026 15:10:48 +0530
Message-ID: <CAExHW5v16VoMJSNTEudqOj4di9Y5WF_wUmf9wVTM6jdzYJXPxw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAHg+QDcE9wp6nOEC3SCRQ90nrCO=QF+OZq1MG8Qc6hnusmogqw@mail.gmail.com>
	<CAExHW5sQ5CfQeO4QXQaArRpD5FrUK_ndDAqHiQFg04DaC-+NaQ@mail.gmail.com>
	<CAJTYsWX8J2cUTCnVRwks0gJw4wiMCv_qVSxshFC9f8oh7Ch6JA@mail.gmail.com>
	<CAExHW5tGQCjWEdyhOHGMj32NAMObH--eZDGeoxKRS9O3Wv_7wQ@mail.gmail.com>
	<[email protected]>

On Thu, Jul 9, 2026 at 1:48 PM Peter Eisentraut <[email protected]> wrote:
>
> On 10.06.26 14:49, Ashutosh Bapat wrote:
> >> Attached is v2-0001, rebased on master and addressing
> >> the comments you added in case we plan on parking the feature
> >> work for once v20 opens.
> > Thanks. I revised it a bit. Reworded the commit message to describe
> > user facing behaviour instead of the internals, which are quite
> > obvious from the code changes. Other cases in transformLockingClause()
> > don't mention XXX, they just have ereport(). Removed that comment.
> > Also massaged comments in the test - we usually don't describe the
> > expected behaviour or error when it is obvious from the output.
> > Attached revised patch.
>
> Committed.
>

Thanks.

> I also modified the comment that said "ignore JOIN, SPECIAL, ..." to
> just say "ignore all other RTE kinds", because keeping that kind of list
> up to date is silly.  (RTE_SPECIAL hasn't existed in a long time.)

That comment is useful since it confirms that the omission is
intentional; however I agree that keeping it up to date is cumbersome.
Maybe we need some way to tie the two switch cases so that
unintentional omissions can be easily caught.

-- 
Best Wishes,
Ashutosh Bapat

view thread (4+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Bug] Add the missing RTE_GRAPH_TABLE case to transformLockingClause()
  In-Reply-To: <CAExHW5v16VoMJSNTEudqOj4di9Y5WF_wUmf9wVTM6jdzYJXPxw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox