MIME-Version: 1.0
References: 
 <CAHg+QDc97WFTSkXg=g_ZAH8GnY2gJrvq72cs+YjqEAuZgXnkAQ@mail.gmail.com>
 <CAExHW5swSoFHbL3F8nGKTx-qtk8W9inp0Afxfr+JBsQ6z2tmQw@mail.gmail.com>
 <CAExHW5vm8MA_w975hP==OkGhbX2uciinUjRp_Pk310fN5uGW8w@mail.gmail.com>
 <CA+TgmoZvC1XQe_QnTQnXyvrqP0WLn07NnNEmEPLzNQOjbnGXtw@mail.gmail.com>
 <CAExHW5t5_xs7sc0H2dT+QUsfEiNfTLtFKpCEE0Wr9ovF23dqoQ@mail.gmail.com>
 <19895d96-a27a-4e8a-a67f-f6dcf0ed4f82@eisentraut.org>
In-Reply-To: <19895d96-a27a-4e8a-a67f-f6dcf0ed4f82@eisentraut.org>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Mon, 11 May 2026 11:45:59 +0530
Message-ID: 
 <CAExHW5v1frgDptL_BsPq3-zt2q9zAkBkp80u3AyJtiQyJFTHRg@mail.gmail.com>
Subject: Re: [Patch]Add Graph* node support to expression_tree_mutator
To: Peter Eisentraut <peter@eisentraut.org>
Cc: Robert Haas <robertmhaas@gmail.com>,
	SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5v1frgDptL_BsPq3-zt2q9zAkBkp80u3AyJtiQyJFTHRg%40mail.gmail.com>
Precedence: bulk

On Mon, May 4, 2026 at 9:09=E2=80=AFPM Peter Eisentraut <peter@eisentraut.o=
rg> wrote:
>
> On 30.04.26 08:44, Ashutosh Bapat wrote:
> > On Thu, Apr 30, 2026 at 2:17=E2=80=AFAM Robert Haas <robertmhaas@gmail.=
com> wrote:
> >>
> >
> > Thanks for reviewing the patch.
> >
> >> Thanks for working on this. I ran into it independently today, and
> >> then discovered this thread. In expression_tree_mutator_impl,
> >> T_GraphLabelRef can be added to the "Primitive node types with no
> >> expression subnodes" section just as was done in
> >> expression_tree_walker_impl.
> >
> > Right. Fixed in the attached patch. Both GraphPropertyLabel and
> > GraphLabelRef need to be placed in that section since both are
> > primitive nodes.
>
> Committed.  (I reformatted the test query a little bit as you had
> suggested upstream.  Also, the ordering of the switch cases was slightly
> different between the walker and the mutator, which I fixed.)
>

Thanks. The changes look good to me.

--=20
Best Wishes,
Ashutosh Bapat