MIME-Version: 1.0
References: 
 <CAExHW5ti5igDwOOde6shgfS7JPtCY9gNrkB3xNr=FuGTYVDSjQ@mail.gmail.com>
 <2ebde3606beab536a8693e8f54c33dc0981b8478.camel@cybertec.at>
 <CAExHW5tvMaJupX9c33NqKQ41D-QoDxeYAnnJS580+N690LrA2A@mail.gmail.com>
 <3346e4ef343f1ac99ad9db02f2cdbb2fb7507a9f.camel@cybertec.at>
In-Reply-To: <3346e4ef343f1ac99ad9db02f2cdbb2fb7507a9f.camel@cybertec.at>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Tue, 30 Sep 2025 20:06:32 +0530
Message-ID: 
 <CAExHW5v5mn-t7=S7bCnGY27MVT-+XCn3D9QVV=ug5x+QXfyH-Q@mail.gmail.com>
Subject: Re: pg_restore documentation and --create/--single-transaction
 limitation
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5v5mn-t7%3DS7bCnGY27MVT-%2BXCn3D9QVV%3Dug5x%2BQXfyH-Q%40mail.gmail.com>
Precedence: bulk

On Tue, Sep 30, 2025 at 6:06=E2=80=AFPM Laurenz Albe <laurenz.albe@cybertec=
.at> wrote:
>
> On Tue, 2025-09-30 at 17:01 +0530, Ashutosh Bapat wrote:
> > Thanks a lot for the research and pointing out missing --jobs.
> >
> > > So I think that your suggestion makes sense.
> > >
> > > I tried to improve the English, and I have added the incompatibility
> > > with multiple --jobs to the --single-transaction documentation.
> > >
> > > Does that look alright to you?
> >
> > @@ -541,7 +545,9 @@ PostgreSQL documentation
> > emitted commands in <command>BEGIN</command>/<command>COMMIT</command>)=
. This
> > ensures that either all the commands complete successfully, or no
> > changes are applied. This option implies
> > - <option>--exit-on-error</option>.
> > + <option>--exit-on-error</option>. It cannot be used together with
> > + <option>--create</option>, which switches database connections, or wi=
th
> >
> > I didn't understand ", which switches ..." part. The code comment says
> > /*
> > * -C is not compatible with -1, because we can't create a database insi=
de
> > * a transaction block.
> > */
> > if (opts->createDB && opts->single_txn)
> > pg_fatal("options -C/--create and -1/--single-transaction cannot be
> > used together");
> >
> > It doesn't say anything about switching connections. But it's too low
> > level of detail, which we may just eliminate.
> >
> > + multiple <option>--jobs</option>.
> >
> > This seems to be confusing. I read it as --single-transaction can not
> > be used when there are multiple --jobs specifications e.g.
> > --single-transaction --jobs 1 --jobs 2. Maybe just say " multiple
> > jobs". Even corresponding --jobs documentation says
> >
> > pipe or standard input). Also, multiple
> > jobs cannot be used together with the
> > option <option>--single-transaction</option>.
> >
> > Attached patch with those changes.
>
> I agree with your simpler version.  I'll mark the patch "ready for commit=
ter".

Thanks.

--=20
Best Wishes,
Ashutosh Bapat