MIME-Version: 1.0
References: <afmHd5vSCJtMFueS@bdtpg>
 <c948abd3-7483-473c-a0e7-29c579c823fc@gmail.com>
 <afvvNP8b6QEfCNsQ@paquier.xyz>
 <29c33fb6-4200-4a08-be3d-a1a2ceef23b8@eisentraut.org>
 <aiYKqhUZyROUxlVs@paquier.xyz> <200148.1780878520@sss.pgh.pa.us>
 <CAExHW5sR8tY1JBoG4MGH3pU9A5wq1m4mHZOt0c8wXjcVqZ13sw@mail.gmail.com>
 <581648.1780944202@sss.pgh.pa.us> <aii7cGhWpIR8-vcd@paquier.xyz>
 <CAExHW5uMGdnmxiiWNRNZ+PEaZfec9fVQK8hZ7Vm8vUuQwYNbcg@mail.gmail.com>
 <aijzu0Wsv736_NuS@paquier.xyz>
In-Reply-To: <aijzu0Wsv736_NuS@paquier.xyz>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 10 Jun 2026 16:30:24 +0530
Message-ID: 
 <CAExHW5vZN5ADVaXj0X9Xq1gnShUr4SxjXTL5F4MwjzcD65sJzA@mail.gmail.com>
Subject: Re: Fix DROP PROPERTY GRAPH "unsupported object class" error
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>,
	Alex Guo <guo.alex.hengchen@gmail.com>,
	Bertrand Drouvot <bertranddrouvot.pg@gmail.com>,
 pgsql-hackers@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5vZN5ADVaXj0X9Xq1gnShUr4SxjXTL5F4MwjzcD65sJzA%40mail.gmail.com>
Precedence: bulk

On Wed, Jun 10, 2026 at 10:49=E2=80=AFAM Michael Paquier <michael@paquier.x=
yz> wrote:
>
> On Wed, Jun 10, 2026 at 09:28:56AM +0530, Ashutosh Bapat wrote:
> > Here's a patch fixing it.
>
> Based on the definitions of pglpgid/pgepgid/pgppgid (property graph
> relations), pgelelid (property graph element) and plpellabelid
> (property graph element label), that looks better.  I am still puzzled
> regarding the choice of "label" in the patch for plpellabelid while it
> is an "element label" based on the way it is stored in its catalog,
> with the catalog matching the object being named "property graph
> element label".
>

Which specific string you are referring to?

property graph element label  |        |      | e of element e of
property graph create_property_graph_tests.gt - that doesn't have a
bare label in there

probably the next one
property graph label property |        |      | a of label v1 of
element v1 of property graph create_property_graph_tests.gt

The term "element" comes later "label v1 of element v1".   There's
nothing in the standard called "element label". That term is an
artifact of our implementation. I think "label v1 of element v1" reads
better and follows the standard compared to "element label v1 of
element v1".

There's also a precedent of not using exact catalog names. In case of
user mapping we say " %s of server ...", we don't use "foreign server"
there even though the object is called "foreign server" and the
catalog is pg_foreign_server.

--=20
Best Wishes,
Ashutosh Bapat