Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qd8n0-002JwX-RM for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2023 12:34:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qd8mz-00B6S6-EI for pgsql-hackers@arkaria.postgresql.org; Mon, 04 Sep 2023 12:34:45 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qd8mz-00B6Rw-4D for pgsql-hackers@lists.postgresql.org; Mon, 04 Sep 2023 12:34:44 +0000 Received: from mail-ua1-x934.google.com ([2607:f8b0:4864:20::934]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qd8mv-002zDt-Ls for pgsql-hackers@postgresql.org; Mon, 04 Sep 2023 12:34:44 +0000 Received: by mail-ua1-x934.google.com with SMTP id a1e0cc1a2514c-7a4efcdab54so289967241.1 for ; Mon, 04 Sep 2023 05:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693830880; x=1694435680; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=naUvkhAcFhWHEtT47WhFwIKRMAK5lwZqiAZpAhYWXCw=; b=o5PgfAXVT27o4WlpigwPvZXHtvQZkLRblhwNZaYOUThXgnRlfdgXIYtQoPvBgxqX8B OkRHmOXsgL5u09UGXdPOEzEI84E//BiCLO9QsLPTv31+iOit4heTGVPUgsRgkSoLXigG jzw148Ur6HeOtkxFAvPkirXXWDHu6H8T2G40OpZrBFxrwpKSWEXv+WDe5MiAcEfAmml+ WoTw68caZL4NKxC8LnZLwLCJKaLA2c3NXTQol18xkMlbRlm69A6b8HfShq/FFInC8pD4 NAH0FxzFSndRbzc6EejPRGDlgkl8pywkbtm0VJv0nz0xxMtR8kc6NDEDE9W4NroDSK3i GF/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693830880; x=1694435680; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=naUvkhAcFhWHEtT47WhFwIKRMAK5lwZqiAZpAhYWXCw=; b=OJy9qAHOzUsuA4nHnDn8B+IlXOknRzOD+bSEbCl8wuovOPAmKA76N3qknMnsoxuAyZ y2u+aav2jUMIJE1vaT02cW+IibCOyryFwMQoW7PDBNmmFmA/bkCAFuHsQPKj79YrNsBH AJFn0q9X0DmXK1tc3nxsDxG5/OFR28mjtvwn9Q14cF53EUxk3PqG4lfdELPxzsEpKqsu y6UmqRI2RVTNISg4+UxOrx/fmp/FhQzA448EK1tbFYXy8VBL3JM6cTa0pZjOC5A8oZWS oa7qVXKM+hq1cTOS7kwosDtjc9LdLDSPV6kV33sR/rX1IIZlZ12vgcMsfzx7uGR/yeqD EoLA== X-Gm-Message-State: AOJu0Yy1AjCs9cGrzARXoOcEzAHa5ZGvc3oxZN+UcGnd+jJzXeIUdBFW C+1boWgg1PqgnimqApf9BBuuRNQbvKr2FsUSRYsgvyPc X-Google-Smtp-Source: AGHT+IFpeglfnhW3Jc2XZifgqVumqzF+yRe7M9xEVOc26eeRLIQBRN+kH573GmiQuGdsIEThyIn7EzrUIfyGMouDsBw= X-Received: by 2002:a05:6102:282e:b0:44e:ac98:c65d with SMTP id ba14-20020a056102282e00b0044eac98c65dmr5633659vsb.27.1693830879765; Mon, 04 Sep 2023 05:34:39 -0700 (PDT) MIME-Version: 1.0 References: <149ff9264db27cdf724b65709fbbaee4bf316835.camel@j-davis.com> <830a2bc6cbbb2e6e01c6c0d9f31f320822e10603.camel@j-davis.com> <63ceeec59ad6c07e17ce280e4bae31b65806ec06.camel@j-davis.com> In-Reply-To: From: Ashutosh Bapat Date: Mon, 4 Sep 2023 18:04:28 +0530 Message-ID: Subject: Re: [17] CREATE SUBSCRIPTION ... SERVER To: Robert Haas Cc: Jeff Davis , Joe Conway , pgsql-hackers@postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Sep 2, 2023 at 1:41=E2=80=AFAM Robert Haas = wrote: > > On Fri, Sep 1, 2023 at 4:04=E2=80=AFPM Jeff Davis wro= te: > > On Thu, 2023-08-31 at 17:17 -0400, Joe Conway wrote: > > > Maybe move postgres_fdw to be a first class built in feature instead > > > of > > > an extension? > > > > That could make sense, but we still have to solve the problem of how to > > present a built-in FDW. > > > > FDWs don't have a schema, so it can't be inside pg_catalog. So we'd > > need some special logic somewhere to make pg_dump and psql \dew work as > > expected, and I'm not quite sure what to do there. > > I'm worried that an approach based on postgres_fdw would have security > problems. I think that we don't want postgres_fdw installed in every > PostgreSQL cluster for security reasons. And I think that the set of > people who should be permitted to manage connection strings for > logical replication subscriptions could be different from the set of > people who are entitled to use postgres_fdw. If postgres_fdw was the only way to specify a connection to be used with subscriptions, what you are saying makes sense. But it's not. We will continue to support current mechanism which doesn't require postgres_fdw to be installed on every PostgreSQL cluster. What security problems do you foresee if postgres_fdw is used in addition to the current mechanism? --=20 Best Wishes, Ashutosh Bapat