public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ashutosh Bapat <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
Date: Fri, 13 Sep 2024 16:14:04 +0530
Message-ID: <CAExHW5vjV1=oLsX8Hw8+M3Vf2Fuurq8HPUa4Ms8mC5H5DZPjcA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAApHDvpF2_bn0WergLrxQvS8qHSKXV3-HOUjku49jCaK3DaMRQ@mail.gmail.com>
	<[email protected]>
	<CAExHW5vRPRLvsZYLmNGcDLkPDWDHXGSWYjox-to-OsCVFETd3w@mail.gmail.com>
	<[email protected]>

On Fri, Sep 13, 2024 at 3:02 PM Tatsuo Ishii <[email protected]> wrote:
>
> > The patch looks fine but it doesn't add a test case where Storage is
> > Disk
>
> We can test the case by setting work_mem to the minimum size (64kB)
> and giving slightly larger "stop" parameter to generate_series.
>

WFM

> > or the case when the last usage fit in memory but an earlier
> > usage spilled to disk.
>
> In my understanding once tuplestore changes the storage type to disk,
> it never returns to the memory storage type in terms of
> tuplestore_get_stats.  i.e. once state->usedDisk is set to true, it
> never goes back to false. So the test case is not necessary.
> David, am I correct?

I understand that. I am requesting a testcase to test that same logic.
-- 
Best Wishes,
Ashutosh Bapat

view thread (9+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add memory/disk usage for WindowAgg nodes in EXPLAIN
  In-Reply-To: <CAExHW5vjV1=oLsX8Hw8+M3Vf2Fuurq8HPUa4Ms8mC5H5DZPjcA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox