MIME-Version: 1.0
References: 
 <CAHg+QDc97WFTSkXg=g_ZAH8GnY2gJrvq72cs+YjqEAuZgXnkAQ@mail.gmail.com>
 <CAExHW5swSoFHbL3F8nGKTx-qtk8W9inp0Afxfr+JBsQ6z2tmQw@mail.gmail.com>
In-Reply-To: 
 <CAExHW5swSoFHbL3F8nGKTx-qtk8W9inp0Afxfr+JBsQ6z2tmQw@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Tue, 28 Apr 2026 20:35:11 +0530
Message-ID: 
 <CAExHW5vm8MA_w975hP==OkGhbX2uciinUjRp_Pk310fN5uGW8w@mail.gmail.com>
Subject: Re: [Patch]Add Graph* node support to expression_tree_mutator
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="00000000000099b71e0650868fb0"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5vm8MA_w975hP%3D%3DOkGhbX2uciinUjRp_Pk310fN5uGW8w%40mail.gmail.com>
Precedence: bulk

--00000000000099b71e0650868fb0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 23, 2026 at 12:18=E2=80=AFPM Ashutosh Bapat
<ashutosh.bapat.oss@gmail.com> wrote:
>
>
> Why is MUTATE not called on GraphElementPattern::labelexpr and
> GraphElementPattern::quantifier?

The walker didn't WALK labelexpr and quantifier either. Given that
labelexpr is a boolean expression it needs to be WALKed. quantifier is
IntList which is ignored by other nodes as well when WALKing. But we
need to copy quantifier in mutator otherwise the mutated expression
will point to the same IntList as the original node. Other nodes also
copy the OidLists and IntLists when mutating them. I have modified the
test query to cover the label expression mutator.

raw_expression_walker didn't cover labelexpr either. Added it there.
The label expression at that stage contains ColumnRef and BoolExpr
which are already covered by raw expression tree walker.

--=20
Best Wishes,
Ashutosh Bapat

--00000000000099b71e0650868fb0
Content-Type: text/x-patch; charset="US-ASCII";
	name="v20260428-0001-Handle-nodes-that-may-appear-in-GraphPatte.patch"
Content-Disposition: attachment;
	filename="v20260428-0001-Handle-nodes-that-may-appear-in-GraphPatte.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_moirceql0>
X-Attachment-Id: f_moirceql0

RnJvbSBmMGM3Mzg0ZWUzN2NmMGI2NGQ1NGVmYjUzYjJkOTc2MDBlYmRiOTI4IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBzYXR5YW5hcmF5YW5hIG5hcmxhcHVyYW0gPHNhdHlhbmFybGFw
dXJhbUBnbWFpbC5jb20+CkRhdGU6IFR1ZSwgMjEgQXByIDIwMjYgMTQ6MzM6MzMgKzAwMDAKU3Vi
amVjdDogW1BBVENIIHYyMDI2MDQyOCAzLzNdIEhhbmRsZSBub2RlcyB0aGF0IG1heSBhcHBlYXIg
aW4gR3JhcGhQYXR0ZXJuCiBleHByZXNzaW9uIHRyZWVzCgpleHByZXNzaW9uX3RyZWVfbXV0YXRv
cl9pbXBsKCkgd2FzIG1pc3NpbmcgY2FzZSBoYW5kbGVycyBmb3IgVF9HcmFwaFBhdHRlcm4sClRf
R3JhcGhFbGVtZW50UGF0dGVybiwgYW5kIFRfR3JhcGhQcm9wZXJ0eVJlZi4gIFRoZSBjb3JyZXNw
b25kaW5nCmV4cHJlc3Npb25fdHJlZV93YWxrZXJfaW1wbCgpIGFscmVhZHkgaGFuZGxlZCBhbGwg
dGhyZWUgbm9kZSB0eXBlcywgYnV0IHRoZQptdXRhdG9yIGRpZCBub3QsIGNhdXNpbmcgYW4gInVu
cmVjb2duaXplZCBub2RlIHR5cGUgIiBlcnJvciB3aGVuZXZlciBhCkdSQVBIX1RBQkxFIGFwcGVh
cmVkIGluIGFuIGV4cHJlc3Npb24gdHJlZS4KCldoaWxlIGF0IGl0IGFsc28gdXBkYXRlIHJhd19l
eHByZXNzaW9uX3RyZWVfd2Fsa2VyKCkgYW5kCmV4cHJlc3Npb25fdHJlZV93YWxrZXIoKSB0byBo
YW5kbGUgbWlzc2luZyBub2RlcyB0aGF0IG1heSBhcHBlYXIgaW4gR3JhcGhQYXR0ZXJuCmV4cHJl
c3Npb24gdHJlZXMuIFdoZW4gcmF3X2V4cHJlc3Npb25fdHJlZV93YWxrZXIoKSBpcyBjYWxsZWQs
CkdyYXBoRWxlbWVudFBhdHRlcm46OmxhYmVsZXhwciBkb2VzIGNvbnRhaW5zIENvbHVtblJlZnMg
aW5zdGVhZCBvZgpHcmFwaExhYmVsUmVmcy4gSGVuY2UgdGhvc2UgYXJlIG5vdCBoYW5kbGVkIGlu
IHJhd19leHByZXNzaW9uX3RyZWVfd2Fsa2VyKCkuCgpSZXBvcnRlZCBieTogU2F0eWFuYXJheWFu
YSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21haWwuY29tPgpBdXRob3I6IFNhdHlhbmFy
YXlhbmEgTmFybGFwdXJhbSA8c2F0eWFuYXJsYXB1cmFtQGdtYWlsLmNvbT4KQXV0aG9yOiBBc2h1
dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdtYWlsLmNvbT4KUmV2aWV3ZWQgYnk6IEFz
aHV0b3NoIEJhcGF0IDxhc2h1dG9zaC5iYXBhdC5vc3NAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBo
dHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlkL0NBSGcrUURjOTdXRlRTa1hnPWdf
WkFIOEduWTJnSnJ2cTcyY3MrWWpxRUF1WmdYbmtBUUBtYWlsLmdtYWlsLmNvbQotLS0KIHNyYy9i
YWNrZW5kL25vZGVzL25vZGVGdW5jcy5jICAgICAgICAgICAgIHwgNDUgKysrKysrKysrKysrKysr
KysrKysrKysKIHNyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUub3V0IHwgMTUg
KysrKysrKysKIHNyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbCAgICAgIHwgIDkg
KysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNjkgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3Ny
Yy9iYWNrZW5kL25vZGVzL25vZGVGdW5jcy5jIGIvc3JjL2JhY2tlbmQvbm9kZXMvbm9kZUZ1bmNz
LmMKaW5kZXggN2VkYmQ1YjcyMjUuLmRiMmVmZjM0M2Q3IDEwMDY0NAotLS0gYS9zcmMvYmFja2Vu
ZC9ub2Rlcy9ub2RlRnVuY3MuYworKysgYi9zcmMvYmFja2VuZC9ub2Rlcy9ub2RlRnVuY3MuYwpA
QCAtMjEzNSw2ICsyMTM1LDcgQEAgZXhwcmVzc2lvbl90cmVlX3dhbGtlcl9pbXBsKE5vZGUgKm5v
ZGUsCiAJCWNhc2UgVF9SYW5nZVRibFJlZjoKIAkJY2FzZSBUX1NvcnRHcm91cENsYXVzZToKIAkJ
Y2FzZSBUX0NURVNlYXJjaENsYXVzZToKKwkJY2FzZSBUX0dyYXBoTGFiZWxSZWY6CiAJCWNhc2Ug
VF9HcmFwaFByb3BlcnR5UmVmOgogCQljYXNlIFRfTWVyZ2VTdXBwb3J0RnVuYzoKIAkJCS8qIHBy
aW1pdGl2ZSBub2RlIHR5cGVzIHdpdGggbm8gZXhwcmVzc2lvbiBzdWJub2RlcyAqLwpAQCAtMjY5
OCw2ICsyNjk5LDggQEAgZXhwcmVzc2lvbl90cmVlX3dhbGtlcl9pbXBsKE5vZGUgKm5vZGUsCiAJ
CQl7CiAJCQkJR3JhcGhFbGVtZW50UGF0dGVybiAqZ2VwID0gKEdyYXBoRWxlbWVudFBhdHRlcm4g
Kikgbm9kZTsKIAorCQkJCWlmIChXQUxLKGdlcC0+bGFiZWxleHByKSkKKwkJCQkJcmV0dXJuIHRy
dWU7CiAJCQkJaWYgKFdBTEsoZ2VwLT5zdWJleHByKSkKIAkJCQkJcmV0dXJuIHRydWU7CiAJCQkJ
aWYgKFdBTEsoZ2VwLT53aGVyZUNsYXVzZSkpCkBAIC0zODE0LDYgKzM4MTcsNDYgQEAgZXhwcmVz
c2lvbl90cmVlX211dGF0b3JfaW1wbChOb2RlICpub2RlLAogCQkJCXJldHVybiAoTm9kZSAqKSBu
ZXdub2RlOwogCQkJfQogCQkJYnJlYWs7CisJCWNhc2UgVF9HcmFwaExhYmVsUmVmOgorCQkJewor
CQkJCUdyYXBoTGFiZWxSZWYgKm5ld25vZGU7CisKKwkJCQlGTEFUQ09QWShuZXdub2RlLCBub2Rl
LCBHcmFwaExhYmVsUmVmKTsKKwkJCQlyZXR1cm4gKE5vZGUgKikgbmV3bm9kZTsKKwkJCX0KKwkJ
CWJyZWFrOworCQljYXNlIFRfR3JhcGhQcm9wZXJ0eVJlZjoKKwkJCXsKKwkJCQlHcmFwaFByb3Bl
cnR5UmVmICpuZXdub2RlOworCisJCQkJRkxBVENPUFkobmV3bm9kZSwgbm9kZSwgR3JhcGhQcm9w
ZXJ0eVJlZik7CisJCQkJcmV0dXJuIChOb2RlICopIG5ld25vZGU7CisJCQl9CisJCQlicmVhazsK
KwkJY2FzZSBUX0dyYXBoRWxlbWVudFBhdHRlcm46CisJCQl7CisJCQkJR3JhcGhFbGVtZW50UGF0
dGVybiAqZ2VwID0gKEdyYXBoRWxlbWVudFBhdHRlcm4gKikgbm9kZTsKKwkJCQlHcmFwaEVsZW1l
bnRQYXR0ZXJuICpuZXdub2RlOworCisJCQkJRkxBVENPUFkobmV3bm9kZSwgZ2VwLCBHcmFwaEVs
ZW1lbnRQYXR0ZXJuKTsKKwkJCQlNVVRBVEUobmV3bm9kZS0+bGFiZWxleHByLCBnZXAtPmxhYmVs
ZXhwciwgTm9kZSAqKTsKKwkJCQlNVVRBVEUobmV3bm9kZS0+c3ViZXhwciwgZ2VwLT5zdWJleHBy
LCBMaXN0ICopOworCQkJCU1VVEFURShuZXdub2RlLT53aGVyZUNsYXVzZSwgZ2VwLT53aGVyZUNs
YXVzZSwgTm9kZSAqKTsKKwkJCQluZXdub2RlLT5xdWFudGlmaWVyID0gbGlzdF9jb3B5KGdlcC0+
cXVhbnRpZmllcik7CisJCQkJcmV0dXJuIChOb2RlICopIG5ld25vZGU7CisJCQl9CisJCQlicmVh
azsKKwkJY2FzZSBUX0dyYXBoUGF0dGVybjoKKwkJCXsKKwkJCQlHcmFwaFBhdHRlcm4gKmdwID0g
KEdyYXBoUGF0dGVybiAqKSBub2RlOworCQkJCUdyYXBoUGF0dGVybiAqbmV3bm9kZTsKKworCQkJ
CUZMQVRDT1BZKG5ld25vZGUsIGdwLCBHcmFwaFBhdHRlcm4pOworCQkJCU1VVEFURShuZXdub2Rl
LT5wYXRoX3BhdHRlcm5fbGlzdCwgZ3AtPnBhdGhfcGF0dGVybl9saXN0LCBMaXN0ICopOworCQkJ
CU1VVEFURShuZXdub2RlLT53aGVyZUNsYXVzZSwgZ3AtPndoZXJlQ2xhdXNlLCBOb2RlICopOwor
CQkJCXJldHVybiAoTm9kZSAqKSBuZXdub2RlOworCQkJfQorCQkJYnJlYWs7CiAJCWRlZmF1bHQ6
CiAJCQllbG9nKEVSUk9SLCAidW5yZWNvZ25pemVkIG5vZGUgdHlwZTogJWQiLAogCQkJCSAoaW50
KSBub2RlVGFnKG5vZGUpKTsKQEAgLTQ3OTYsNiArNDgzOSw4IEBAIHJhd19leHByZXNzaW9uX3Ry
ZWVfd2Fsa2VyX2ltcGwoTm9kZSAqbm9kZSwKIAkJCXsKIAkJCQlHcmFwaEVsZW1lbnRQYXR0ZXJu
ICpnZXAgPSAoR3JhcGhFbGVtZW50UGF0dGVybiAqKSBub2RlOwogCisJCQkJaWYgKFdBTEsoZ2Vw
LT5sYWJlbGV4cHIpKQorCQkJCQlyZXR1cm4gdHJ1ZTsKIAkJCQlpZiAoV0FMSyhnZXAtPnN1YmV4
cHIpKQogCQkJCQlyZXR1cm4gdHJ1ZTsKIAkJCQlpZiAoV0FMSyhnZXAtPndoZXJlQ2xhdXNlKSkK
ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUub3V0IGIv
c3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJsZS5vdXQKaW5kZXggMTJiODcwNmI1
ZjMuLjgwMzhmY2QzOWI3IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dy
YXBoX3RhYmxlLm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxl
Lm91dApAQCAtMTAzMiw0ICsxMDMyLDE5IEBAIFNFTEVDVCBzbmFtZSwgZG5hbWUgRlJPTSBHUkFQ
SF9UQUJMRSAoZzEgTUFUQ0ggKHNyYyktPihkZXN0KSBXSEVSRSBzcmMudnByb3AxID4KIEVSUk9S
OiAgc3VicXVlcmllcyB3aXRoaW4gR1JBUEhfVEFCTEUgcmVmZXJlbmNlIGFyZSBub3Qgc3VwcG9y
dGVkCiBTRUxFQ1Qgc25hbWUsIGRuYW1lIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChzcmMp
LT4oZGVzdCkgV0hFUkUgb3V0X2RlZ3JlZShzcmMudm5hbWUpID4gKFNFTEVDVCBtYXgob3V0X2Rl
Z3JlZShubmFtZSkpIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChub2RlKSBDT0xVTU5TIChu
b2RlLnZuYW1lIEFTIG5uYW1lKSkpIENPTFVNTlMoc3JjLnZuYW1lIEFTIHNuYW1lLCBkZXN0LnZu
YW1lIEFTIGRuYW1lKSk7CiBFUlJPUjogIHN1YnF1ZXJpZXMgd2l0aGluIEdSQVBIX1RBQkxFIHJl
ZmVyZW5jZSBhcmUgbm90IHN1cHBvcnRlZAorLS0gR1JBUEhfVEFCTEUgc3VicXVlcnkgaW4gSEFW
SU5HIGNsYXVzZQorU0VMRUNUIHNyYy52bmFtZSwgY291bnQoKikKKyAgRlJPTSB2MSBBUyBzcmMK
KyAgR1JPVVAgQlkgc3JjLnZuYW1lCisgIEhBVklORyBjb3VudCgqKSA+PSAoU0VMRUNUIGNvdW50
KCopCisgICAgICAgICAgICAgICAgICAgICAgICBGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAo
YSBJUyB2bDEgfCB2bDIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICBDT0xVTU5TIChhLnZuYW1lIEFTIG4pKQorICAgICAgICAgICAgICAgICAgICAgICBXSEVSRSBu
ID0gc3JjLnZuYW1lKTsKKyB2bmFtZSB8IGNvdW50IAorLS0tLS0tLSstLS0tLS0tCisgdjEzICAg
fCAgICAgMQorIHYxMiAgIHwgICAgIDEKKyB2MTEgICB8ICAgICAxCisoMyByb3dzKQorCiAtLSBs
ZWF2ZSB0aGUgb2JqZWN0cyBiZWhpbmQgZm9yIHBnX3VwZ3JhZGUvcGdfZHVtcCB0ZXN0cwpkaWZm
IC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsIGIvc3JjL3Rlc3Qv
cmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsCmluZGV4IGE1ZGY0NjQ3YjZhLi5hMzY4MWM2YzBl
ZiAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsCisrKyBi
L3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbApAQCAtNTkwLDQgKzU5MCwxMyBA
QCBTRUxFQ1QgKiBGUk9NIGN1c3RvbWVycyBjbyBXSEVSRSBjby5jdXN0b21lcl9pZCA9IChTRUxF
Q1QgY3VzdG9tZXJfaWQgRlJPTSBHUkFQSAogU0VMRUNUIHNuYW1lLCBkbmFtZSBGUk9NIEdSQVBI
X1RBQkxFIChnMSBNQVRDSCAoc3JjKS0+KGRlc3QpIFdIRVJFIHNyYy52cHJvcDEgPiAoU0VMRUNU
IG1heCh2MS52cHJvcDEpIEZST00gdjEpIENPTFVNTlMoc3JjLnZuYW1lIEFTIHNuYW1lLCBkZXN0
LnZuYW1lIEFTIGRuYW1lKSk7CiBTRUxFQ1Qgc25hbWUsIGRuYW1lIEZST00gR1JBUEhfVEFCTEUg
KGcxIE1BVENIIChzcmMpLT4oZGVzdCkgV0hFUkUgb3V0X2RlZ3JlZShzcmMudm5hbWUpID4gKFNF
TEVDVCBtYXgob3V0X2RlZ3JlZShubmFtZSkpIEZST00gR1JBUEhfVEFCTEUgKGcxIE1BVENIIChu
b2RlKSBDT0xVTU5TIChub2RlLnZuYW1lIEFTIG5uYW1lKSkpIENPTFVNTlMoc3JjLnZuYW1lIEFT
IHNuYW1lLCBkZXN0LnZuYW1lIEFTIGRuYW1lKSk7CiAKKy0tIEdSQVBIX1RBQkxFIHN1YnF1ZXJ5
IGluIEhBVklORyBjbGF1c2UKK1NFTEVDVCBzcmMudm5hbWUsIGNvdW50KCopCisgIEZST00gdjEg
QVMgc3JjCisgIEdST1VQIEJZIHNyYy52bmFtZQorICBIQVZJTkcgY291bnQoKikgPj0gKFNFTEVD
VCBjb3VudCgqKQorICAgICAgICAgICAgICAgICAgICAgICAgRlJPTSBHUkFQSF9UQUJMRSAoZzEg
TUFUQ0ggKGEgSVMgdmwxIHwgdmwyKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgQ09MVU1OUyAoYS52bmFtZSBBUyBuKSkKKyAgICAgICAgICAgICAgICAgICAgICAg
V0hFUkUgbiA9IHNyYy52bmFtZSk7CisKIC0tIGxlYXZlIHRoZSBvYmplY3RzIGJlaGluZCBmb3Ig
cGdfdXBncmFkZS9wZ19kdW1wIHRlc3RzCi0tIAoyLjM0LjEKCg==
--00000000000099b71e0650868fb0--