MIME-Version: 1.0
References: 
 <CAHg+QDcyKNWyzDoKMxiZNjv7C-wAxs8y0ZoNkOV137Y+nk3UXg@mail.gmail.com>
 <CAEG8a3KTP1sX+RbPFNST4kHdeRZQR5-dd6kEihV56=K5irrhyQ@mail.gmail.com>
 <CAHg+QDdzUMW4qQmywiPmVo2z3+HccFZL+mujdXbB+ghU21u7dA@mail.gmail.com>
In-Reply-To: 
 <CAHg+QDdzUMW4qQmywiPmVo2z3+HccFZL+mujdXbB+ghU21u7dA@mail.gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Date: Wed, 29 Apr 2026 19:39:41 +0530
Message-ID: 
 <CAExHW5vmmAS6Vroh8W9+vmuM2ReocODRCWPqYozGSyhxCxxL+Q@mail.gmail.com>
Subject: Re: [PATCH] Resolve unknown-type literals in GRAPH_TABLE COLUMNS
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: Junwang Zhao <zhjwpku@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="000000000000eee94e065099e68a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAExHW5vmmAS6Vroh8W9%2BvmuM2ReocODRCWPqYozGSyhxCxxL%2BQ%40mail.gmail.com>
Precedence: bulk

--000000000000eee94e065099e68a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Apr 27, 2026 at 11:34=E2=80=AFAM SATYANARAYANA NARLAPURAM
<satyanarlapuram@gmail.com> wrote:
>
> Hi,
>
> On Sun, Apr 26, 2026 at 8:10=E2=80=AFAM Junwang Zhao <zhjwpku@gmail.com> =
wrote:
>>
>> Hi SATYANARAYANA,
>>
>> On Sun, Apr 26, 2026 at 3:53=E2=80=AFAM SATYANARAYANA NARLAPURAM
>> <satyanarlapuram@gmail.com> wrote:
>> >
>> > Hi hackers,
>> >
>> > transformRangeGraphTable() calls transformExpr() and
>> > assign_list_collations() for COLUMNS expressions but missed calling
>> > resolveTargetListUnknowns(). As a result, literals such as 'val1'
>> > in a COLUMNS clause retained type "unknown", causing failures with
>> > ORDER BY, UNION, and output conversions.
>> >
>> > Fix by calling resolveTargetListUnknowns() on the columns target
>> > list right after assign_list_collations(), similar to SELECT target li=
sts in
>> > transformSelectStmt().
>> >
>> > Attached a patch to fix this, which also includes test cases to reprod=
uce.
>>
>> I can reproduce this and the patch fixes it.
>>
>> One question: why is resolveTargetListUnknowns called after
>> assign_list_collations?
>>
>> I'm asking because in transformSelectStmt, resolveTargetListUnknowns
>> is invoked before assign_query_collations. It might not matter, but keep=
ing
>> the order consistent would be good for readers.
>
>
> Updated the patch. It should be before.

Do we really need a test for ORDER BY on a literal column? I replaced
all the test queries with a single one which covers all the scenarios
covered by those queries.

The patch needed to consider pstate->p_resolve_unknowns. Unknown
literals are not resolved as text always. See the test query.

--
Best Wishes,
Ashutosh Bapat

--000000000000eee94e065099e68a
Content-Type: text/x-patch; charset="US-ASCII";
	name="v20260429-0001-Resolve-unknown-type-literals-in-GRAPH_TAB.patch"
Content-Disposition: attachment;
	filename="v20260429-0001-Resolve-unknown-type-literals-in-GRAPH_TAB.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mok4su7w0>
X-Attachment-Id: f_mok4su7w0

RnJvbSBjOWU2YjBkZjk0NWU5MGJiMGJlNDNjODhkMWM1NWUxZWUwYTlhOTgyIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBBc2h1dG9zaCBCYXBhdCA8YXNodXRvc2guYmFwYXQub3NzQGdt
YWlsLmNvbT4KRGF0ZTogV2VkLCAyOSBBcHIgMjAyNiAxOTowNzoxMyArMDUzMApTdWJqZWN0OiBb
UEFUQ0ggdjIwMjYwNDI5IDUvNV0gUmVzb2x2ZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgaW4gR1JB
UEhfVEFCTEUKIENPTFVNTlMKClRoZSB1bmtub3duLXR5cGUgbGl0ZXJhbHMgaW4gdGhlIENPTFVN
TlMgY2xhdXNlIG9mIGEgR1JBUEhfVEFCTEUgYXJlIG5vdwpyZXNvbHZlZCB0byB0aGUgYXBwcm9w
cmlhdGUgdHlwZXMsIGNhdXNpbmcgdmFyaW91cyBmYWlsdXJlcy4gQ2FsbApyZXNvbHZlVGFyZ2V0
TGlzdFVua25vd25zKCkgb24gdGhlIGNvbHVtbnMgdGFyZ2V0bGlzdCB0byByZXNvbHZlIHVua25v
bncgdHlwZQpsaXRlcmFscy4gRG8gdGhpcyBiZWZvcmUgYXNzaWduaW5nIGNvbGxhdGlvbnMgc28g
dGhhdCB0aGUgcmVzb2x2ZWQgdHlwZXMgYXJlCnVzZWQgZm9yIGNvbGxhdGlvbnMgYXNzaWdubWVu
dC4KClJlcG9ydGVkIGJ5OiBTYXR5YSBOYXJsYXB1cmFtIDxzYXR5YW5hcmxhcHVyYW1AZ21haWwu
Y29tPgpBdXRob3I6IFNhdHlhIE5hcmxhcHVyYW0gPHNhdHlhbmFybGFwdXJhbUBnbWFpbC5jb20+
CkF1dGhvcjogQXNodXRvc2ggQmFwYXQgPGFzaHV0b3NoLmJhcGF0Lm9zc0BnbWFpbC5jb20+ClJl
dmlld2VkIGJ5OiBKdW53YW5nIFpoYW8gPHpoandwa3VAZ21haWwuY29tPgpEaXNjdXNzaW9uOiBo
dHRwczovL3d3dy5wb3N0Z3Jlc3FsLm9yZy9tZXNzYWdlLWlkL0NBSGcrUURjeUtOV3l6RG9LTXhp
Wk5qdjdDLXdBeHM4eTBab05rT1YxMzdZK25rM1VYZ0BtYWlsLmdtYWlsLmNvbQotLS0KIHNyYy9i
YWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYyAgICAgICAgIHwgIDQgKysrKwogc3JjL3Rlc3Qv
cmVncmVzcy9leHBlY3RlZC9ncmFwaF90YWJsZS5vdXQgfCAxMSArKysrKysrKysrKwogc3JjL3Rl
c3QvcmVncmVzcy9zcWwvZ3JhcGhfdGFibGUuc3FsICAgICAgfCAgNiArKysrKysKIDMgZmlsZXMg
Y2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL3BhcnNl
ci9wYXJzZV9jbGF1c2UuYyBiL3NyYy9iYWNrZW5kL3BhcnNlci9wYXJzZV9jbGF1c2UuYwppbmRl
eCA0MjcwYzIzODJjNC4uM2QwNTg1YjhlZmIgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNl
ci9wYXJzZV9jbGF1c2UuYworKysgYi9zcmMvYmFja2VuZC9wYXJzZXIvcGFyc2VfY2xhdXNlLmMK
QEAgLTEwMDMsNiArMTAwMywxMCBAQCB0cmFuc2Zvcm1SYW5nZUdyYXBoVGFibGUoUGFyc2VTdGF0
ZSAqcHN0YXRlLCBSYW5nZUdyYXBoVGFibGUgKnJndCkKIAkJY29sdW1ucyA9IGxhcHBlbmQoY29s
dW1ucywgdGUpOwogCX0KIAorCS8qIHJlc29sdmUgYW55IHN0aWxsLXVucmVzb2x2ZWQgb3V0cHV0
IGNvbHVtbnMgYXMgYmVpbmcgdHlwZSB0ZXh0ICovCisJaWYgKHBzdGF0ZS0+cF9yZXNvbHZlX3Vu
a25vd25zKQorCQlyZXNvbHZlVGFyZ2V0TGlzdFVua25vd25zKHBzdGF0ZSwgY29sdW1ucyk7CisK
IAkvKgogCSAqIEFzc2lnbiBjb2xsYXRpb25zIHRvIGNvbHVtbiBleHByZXNzaW9ucyBub3cgc2lu
Y2UKIAkgKiBhc3NpZ25fcXVlcnlfY29sbGF0aW9ucygpIGRvZXMgbm90IHByb2Nlc3MgcmFuZ2V0
YWJsZSBlbnRyaWVzLgpkaWZmIC0tZ2l0IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ncmFw
aF90YWJsZS5vdXQgYi9zcmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2dyYXBoX3RhYmxlLm91dApp
bmRleCA4MDM4ZmNkMzliNy4uNWVmOThlMjgxZTYgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jl
c3MvZXhwZWN0ZWQvZ3JhcGhfdGFibGUub3V0CisrKyBiL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0
ZWQvZ3JhcGhfdGFibGUub3V0CkBAIC0xMDQ3LDQgKzEwNDcsMTUgQEAgU0VMRUNUIHNyYy52bmFt
ZSwgY291bnQoKikKICB2MTEgICB8ICAgICAxCiAoMyByb3dzKQogCistLSBVbmtub3duIHR5cGUg
cmVzb2x1dGlvbgorU0VMRUNUIGMxLCBwZ190eXBlb2YoYzEpLCAibnVsbCIsIHBnX3R5cGVvZigi
bnVsbCIpIEZST00KKyAgICAoU0VMRUNUICpGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJ
UyB2bDEpIENPTFVNTlMgKCcxJyBBUyBjMSwgTlVMTCBhcyAibnVsbCIpKQorICAgICBVTklPTgor
ICAgICBTRUxFQ1QgMiwgTlVMTCk7CisgYzEgfCBwZ190eXBlb2YgfCBudWxsIHwgcGdfdHlwZW9m
IAorLS0tLSstLS0tLS0tLS0tLSstLS0tLS0rLS0tLS0tLS0tLS0KKyAgMSB8IGludGVnZXIgICB8
ICAgICAgfCB0ZXh0CisgIDIgfCBpbnRlZ2VyICAgfCAgICAgIHwgdGV4dAorKDIgcm93cykKKwog
LS0gbGVhdmUgdGhlIG9iamVjdHMgYmVoaW5kIGZvciBwZ191cGdyYWRlL3BnX2R1bXAgdGVzdHMK
ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbCBiL3NyYy90
ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbAppbmRleCBhMzY4MWM2YzBlZi4uZDNkZGNk
YzhlMjAgMTAwNjQ0Ci0tLSBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL2dyYXBoX3RhYmxlLnNxbAor
KysgYi9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ncmFwaF90YWJsZS5zcWwKQEAgLTU5OSw0ICs1OTks
MTAgQEAgU0VMRUNUIHNyYy52bmFtZSwgY291bnQoKikKICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgIENPTFVNTlMgKGEudm5hbWUgQVMgbikpCiAgICAgICAgICAgICAg
ICAgICAgICAgIFdIRVJFIG4gPSBzcmMudm5hbWUpOwogCistLSBVbmtub3duIHR5cGUgcmVzb2x1
dGlvbgorU0VMRUNUIGMxLCBwZ190eXBlb2YoYzEpLCAibnVsbCIsIHBnX3R5cGVvZigibnVsbCIp
IEZST00KKyAgICAoU0VMRUNUICpGUk9NIEdSQVBIX1RBQkxFIChnMSBNQVRDSCAoYSBJUyB2bDEp
IENPTFVNTlMgKCcxJyBBUyBjMSwgTlVMTCBhcyAibnVsbCIpKQorICAgICBVTklPTgorICAgICBT
RUxFQ1QgMiwgTlVMTCk7CisKIC0tIGxlYXZlIHRoZSBvYmplY3RzIGJlaGluZCBmb3IgcGdfdXBn
cmFkZS9wZ19kdW1wIHRlc3RzCi0tIAoyLjM0LjEKCg==
--000000000000eee94e065099e68a--