public inbox for [email protected]
help / color / mirror / Atom feedFrom: Matthias van de Meent <[email protected]>
To: Tom Lane <[email protected]>
Cc: Anton A. Melnikov <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Subject: Re: [BUG] Excessive memory usage with update on STORED generated columns.
Date: Mon, 30 Mar 2026 20:50:37 +0200
Message-ID: <CAEze2WhsfFwfjooci5gqpSvq_1ibJHnJZ29c58GbDJWH9nbYkA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Mon, 30 Mar 2026 at 20:35, Tom Lane <[email protected]> wrote:
>
> So I think the correct fix is that there needs to be a separate
> boolean tracking whether this work has been done, akin to
> ExecGetExtraUpdatedCols's use of ri_extraUpdatedCols_valid.
Why would it need a new boolean? ri_extraUpdatedCols_valid tracks
exactly whether we've already gone through ExecInitGenerated(...,
CMD_UPDATE), and in doing so if both ri_extraUpdatedCols,
ri_GeneratedExprsU, and ri_NumGeneratedNeededU are valid or whether
they still need to be populated. Adding a new boolean would therefore
be rather duplicative.
See also the patch of a few hours ago at [0].
Kind regards,
Matthias van de Meent
Databricks (https://www.databricks.com)
[0] https://postgr.es/m/CAEze2Wh%2B_C8LtmiMRb58df%3DA1PrBVmMnYMOfbBUk9c%3Dm99CN%2Bw%40mail.gmail.com
view thread (4+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: [BUG] Excessive memory usage with update on STORED generated columns.
In-Reply-To: <CAEze2WhsfFwfjooci5gqpSvq_1ibJHnJZ29c58GbDJWH9nbYkA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox