MIME-Version: 1.0
References: <0238206d-81c9-4bce-acb4-127fbc4a96ac@dunslane.net>
 <202603301544.utwvuj534m36@alvherre.pgsql>
In-Reply-To: <202603301544.utwvuj534m36@alvherre.pgsql>
From: solai v <solai.cdac@gmail.com>
Date: Mon, 22 Jun 2026 10:44:09 +0530
Message-ID: 
 <CAF0whucy3wpEYqtVEX=eKi9rd5uR-=hQMkaCmjYwxQ-rOmheVw@mail.gmail.com>
Subject: Re: [PATCH] Add support for INSERT ... SET syntax
To: Suraj Kharage <suraj.kharage@enterprisedb.com>
Cc: Andrew Dunstan <andrew@dunslane.net>,
 "David G. Johnston" <david.g.johnston@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	=?UTF-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>,
	Ajay Pal <ajay.pal.k@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAF0whucy3wpEYqtVEX%3DeKi9rd5uR-%3DhQMkaCmjYwxQ-rOmheVw%40mail.gmail.com>
Precedence: bulk

Hi Suraj,

I tested v3 of the patch on current master.
The patch applied and built cleanly on my setup. Before applying it,
statements using the proposed INSERT...SET syntax resulted in a syntax
error near SET, which is expected since PostgreSQL does not currently
support this syntax. After applying the patch, the same statements
worked as expected and rows were inserted successfully.
I went through the functionality added by the patch and tested a few
different scenarios, including basic INSERT...SET usage, DEFAULT
values, expressions/functions, RETURNING, ON CONFLICT DO UPDATE,
multi-row inserts, different column sets in multi-row inserts, and
subqueries in assignments.
All of them behaved as expected in my testing.
I also verified the query that Ajay previously reported as causing a
backend crash:
INSERT INTO emp_test SET (empno,ename)=(SELECT 1,'aa');
With v3, I was not able to reproduce the crash. The query returned a
normal syntax error, and the server continued to run normally
afterward.
In addition, I ran the regression test suite and all tests passed successfully.
Overall, the patch worked well in my testing and I did not notice any
regressions.


Regards,
solai