MIME-Version: 1.0
References: 
 <CAJTYsWXOkyeDVbzymWc9sKrq7Y_MUv6XJXN4H9GfsBOPd3NJ+w@mail.gmail.com>
 <CACJufxE3e1jPsKLsjNWMucahFJW7UO_UGWzhRESRvJ+8PeKgkg@mail.gmail.com>
 <CAJTYsWX+g49jMArk0MdS0+suEY8CckyAYpm+KvNLU9Zx9=6t3g@mail.gmail.com>
 <CACJufxGPNgAcQEiwD0QFCTP8vi0XZzys06EEQUnR84_0Qo9s9Q@mail.gmail.com>
 <CAJTYsWUooEDFaNOiOLjz0NqmqBtof65b-sQQHWmh8jV9t-VYEA@mail.gmail.com>
 <CACJufxGBSeAcyStRHajNvqerGCRGB5Wb=e5cbGd7HFT4=aMsLw@mail.gmail.com>
 <CAJTYsWWw7s0N2hnAW9pfhkSx-aN=wELErrBEicoPMnmmS1e7kg@mail.gmail.com>
 <CACJufxGdr-A7hwBRWh02YHbb13M-LG3bAOad+86iivp2008tTA@mail.gmail.com>
In-Reply-To: 
 <CACJufxGdr-A7hwBRWh02YHbb13M-LG3bAOad+86iivp2008tTA@mail.gmail.com>
From: solai v <solai.cdac@gmail.com>
Date: Tue, 19 May 2026 11:01:27 +0530
Message-ID: 
 <CAF0whufxMsRLvoGAsxAouboBj_31P07f0Etexgwh7d6fnyOu_w@mail.gmail.com>
Subject: Re: [PATCH] Rebuild CHECK constraints after generated column SET
 EXPRESSION
To: jian he <jian.universality@gmail.com>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
 Zsolt Parragi <zsolt.parragi@percona.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAF0whufxMsRLvoGAsxAouboBj_31P07f0Etexgwh7d6fnyOu_w%40mail.gmail.com>
Precedence: bulk

Hi
I tested v5-0001-recreate-wholerow-dependent-while-ALTER-COLUMN-SET-EXPRESSION.patch
on the current master.The patch applied cleanly and PostgreSQL built
successfully.
I was able to reproduce the issue on unpatched master using a
whole-row CHECK constraint referencing the generated column
through:CHECK ((gtest).b IS NOT NULL).
Without the patch,ALTER COLUMN SET EXPRESSION succeeded even though
existing rows no longer satisfied the constraint.
After applying the patch ,the same ALTER TABLE command correctly
failed with : ERROR:check constraint "whole_row_check" of relation
"gtest" is violated by some row.
The fix and regression coverage look good to me.

Regards,
Solai