MIME-Version: 1.0
References: <20210423204306.5osfpkt2ggaedyvy@alap3.anarazel.de>
 <CAP4vRV5gEHFLB7NwOE6_dyHAeVfkvqF8Z_g5GaCQZNgBAE0Frw@mail.gmail.com>
 <20210611011850.detxnd7bnffg3daz@alap3.anarazel.de> <CAD21AoC-xMv1pModWvUQ1g1qByxMmu6yLghsKVb-R35rmShiwA@mail.gmail.com>
 <CAD21AoDVhkXp8HjpFO-gp3TgL6tCKcZQNxn04m01VAtcSi-5sA@mail.gmail.com>
 <CAB8KJ=j1b3kscX8Cg5G=Q39ZQsv2x4URXsuTueJLz=fcvJ3eoQ@mail.gmail.com>
 <64524348-b10e-9904-4858-8fe62d058b14@iki.fi> <CAD21AoDouzPRqhZJWpoXje=MPFUx8kM3SGa2MkrRtsjzJSrSpQ@mail.gmail.com>
 <CAD21AoAyYBZOiB1UPCPZJHTLk0-arrq5zqNGj+PrsbpdUy=g-g@mail.gmail.com>
In-Reply-To: <CAD21AoAyYBZOiB1UPCPZJHTLk0-arrq5zqNGj+PrsbpdUy=g-g@mail.gmail.com>
From: John Naylor <john.naylor@enterprisedb.com>
Date: Fri, 21 Apr 2023 10:02:31 +0700
Message-ID: <CAFBsxsGAh23p5ny9sHRf6UB9ve6KAb95Hi5e4NdkqPEEZDrOaQ@mail.gmail.com>
Subject: Re: Testing autovacuum wraparound (including failsafe)
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Ian Lawrence Barwick <barwick@gmail.com>, 
	Andres Freund <andres@anarazel.de>, Anastasia Lubennikova <lubennikovaav@gmail.com>, 
	pgsql-hackers <pgsql-hackers@postgresql.org>, Peter Geoghegan <pg@bowt.ie>
Content-Type: multipart/alternative; boundary="0000000000001831c405f9cfe479"
Archived-At: <https://www.postgresql.org/message-id/CAFBsxsGAh23p5ny9sHRf6UB9ve6KAb95Hi5e4NdkqPEEZDrOaQ%40mail.gmail.com>
Precedence: bulk

--0000000000001831c405f9cfe479
Content-Type: text/plain; charset="UTF-8"

I agree having the new functions in the tree is useful. I also tried
running the TAP tests in v2, but 001 and 002 fail to run:

Odd number of elements in hash assignment at [...]/Cluster.pm line 2010.
Can't locate object method "pump_nb" via package
"PostgreSQL::Test::BackgroundPsql" at [...]

It seems to be complaining about

+my $in  = '';
+my $out = '';
+my $timeout = IPC::Run::timer($PostgreSQL::Test::Utils::timeout_default);
+my $background_psql = $node->background_psql('postgres', \$in, \$out,
$timeout);

...that call to background_psql doesn't look like other ones that have "key
=> value". Is there something I'm missing?

--
John Naylor
EDB: http://www.enterprisedb.com

--0000000000001831c405f9cfe479
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">I agree having the=C2=A0new functions in the tree=C2=A0is =
useful. I also tried running the TAP tests in v2, but 001 and 002 fail to r=
un:<div><br></div><div>Odd number of elements in hash assignment at [...]/C=
luster.pm line 2010.<br>Can&#39;t locate object method &quot;pump_nb&quot; =
via package &quot;PostgreSQL::Test::BackgroundPsql&quot; at [...]<br><br>It=
 seems to be complaining about</div><div><br></div><div>+my $in =C2=A0=3D &=
#39;&#39;;<br>+my $out =3D &#39;&#39;;<br>+my $timeout =3D IPC::Run::timer(=
$PostgreSQL::Test::Utils::timeout_default);<br>+my $background_psql =3D $no=
de-&gt;background_psql(&#39;postgres&#39;, \$in, \$out, $timeout);<br><br>.=
..that call to background_psql doesn&#39;t look like other ones that have &=
quot;key =3D&gt; value&quot;. Is there something I&#39;m missing?<br><br>--=
<br>John Naylor<br>EDB: <a href=3D"http://www.enterprisedb.com">http://www.=
enterprisedb.com</a></div></div>

--0000000000001831c405f9cfe479--