MIME-Version: 1.0
References: 
 <CAFC+b6q6EsNqZ4+QugmMugbGChuJfu4HorJ3hZ0f6cyxCAxFgQ@mail.gmail.com>
 <202603261900.qbqphzjnlz7s@alvherre.pgsql>
In-Reply-To: <202603261900.qbqphzjnlz7s@alvherre.pgsql>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Sat, 28 Mar 2026 00:12:18 +0530
Message-ID: 
 <CAFC+b6oJkNoFEgDUNBOdspWkPGQbeaGohE=W179PKwEegp8YSw@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Antonin Houska <ah@cybertec.at>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Content-Type: multipart/mixed; boundary="000000000000059e13064e05dd76"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6oJkNoFEgDUNBOdspWkPGQbeaGohE%3DW179PKwEegp8YSw%40mail.gmail.com>
Precedence: bulk

--000000000000059e13064e05dd76
Content-Type: multipart/alternative; boundary="000000000000059e11064e05dd74"

--000000000000059e11064e05dd74
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Alvaro,

On Fri, Mar 27, 2026 at 12:45=E2=80=AFAM Alvaro Herrera <alvherre@alvh.no-i=
p.org>
wrote:

>
> I don't disagree with changing this, but AFAICS the patch as presented
> provokes multiple test failures.
>

Fixed with the attached patch.


--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--000000000000059e11064e05dd74
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi=C2=A0Alvaro,</div><br><div class=3D"gm=
ail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On F=
ri, Mar 27, 2026 at 12:45=E2=80=AFAM Alvaro Herrera &lt;<a href=3D"mailto:a=
lvherre@alvh.no-ip.org">alvherre@alvh.no-ip.org</a>&gt; wrote:</div><blockq=
uote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1p=
x solid rgb(204,204,204);padding-left:1ex">
<br>
I don&#39;t disagree with changing this, but AFAICS the patch as presented<=
br>
provokes multiple test failures.<br></blockquote><div><br>Fixed with the at=
tached patch.=C2=A0</div></div><div><br clear=3D"all"></div><div><br></div>=
<span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34)">T=
hanks,</span><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,=
34,34)">Srinath Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34)"><=
span style=3D"color:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://www.=
enterprisedb.com/" style=3D"color:rgb(17,85,204)" target=3D"_blank">https:/=
/www.enterprisedb.com/</a></div></div></div>

--000000000000059e11064e05dd74--

--000000000000059e13064e05dd76
Content-Type: application/octet-stream;
	name="nocfbot-v2-0001-Check-for-transaction-block-early-in-ExecRepack.patch"
Content-Disposition: attachment;
	filename="nocfbot-v2-0001-Check-for-transaction-block-early-in-ExecRepack.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn98y7v60>
X-Attachment-Id: f_mn98y7v60

RnJvbSBjYjNhMTRmODkzMWQ2YmU5MTM1OTgyYmI2Mzc4ZTg5MmFiZWIyZDU1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTcmluYXRoIFJlZGR5IFNhZGlwaXJhbGxhIDxzcmluYXRoMjEz
M0BnbWFpbC5jb20+CkRhdGU6IEZyaSwgMjcgTWFyIDIwMjYgMjM6NTk6MTUgKzA1MzAKU3ViamVj
dDogW1BBVENIIHYyIDEvMV0gQ2hlY2sgZm9yIHRyYW5zYWN0aW9uIGJsb2NrIGVhcmx5IGluIEV4
ZWNSZXBhY2sKCkN1cnJlbnRseSwgZXhlY3V0aW5nIFJFUEFDSyAoQ09OQ1VSUkVOVExZKSB3aXRo
b3V0IGEgdGFibGUgbmFtZSBpbnNpZGUgYQp0cmFuc2FjdGlvbiBibG9jayB0aHJvd3MgdGhlIGVy
cm9yICJSRVBBQ0sgQ09OQ1VSUkVOVExZIHJlcXVpcmVzIGV4cGxpY2l0CnRhYmxlIG5hbWUiIGlu
c3RlYWQgb2YgdGhlIGV4cGVjdGVkIHRyYW5zYWN0aW9uIGJsb2NrIGVycm9yLiBUaGlzIG9jY3Vy
cwpiZWNhdXNlIEV4ZWNSZXBhY2soKSB2YWxpZGF0ZXMgdGhlIHBhcnNlZCBvcHRpb25zIGFuZCBt
aXNzaW5nIHJlbGF0aW9uCmJlZm9yZSB2ZXJpZnlpbmcgdGhlIHRyYW5zYWN0aW9uIHN0YXRlLgoK
VGhpcyBiZWhhdmlvciBpcyBpbmNvbnNpc3RlbnQgd2l0aCBvdGhlciB1dGlsaXR5IGNvbW1hbmRz
IGxpa2UgVkFDVVVNCixSRUlOREVYLCBldGM7IHdoaWNoIGludm9rZSBQcmV2ZW50SW5UcmFuc2Fj
dGlvbkJsb2NrKCkgYXQgdGhlIHZlcnkgc3RhcnQKb2YgdGhlaXIgZXhlY3V0aW9uIHRvIHByb3Bl
cmx5IHJlamVjdCBleGVjdXRpb24gaW5zaWRlIHVzZXIgdHJhbnNhY3Rpb25zCmJlZm9yZSB2YWxp
ZGF0aW5nIHRhcmdldHMuCgpBZGQgUHJldmVudEluVHJhbnNhY3Rpb25CbG9jayB0byB0aGUgdG9w
IG9mIEV4ZWNSZXBhY2soKSB0byBlbmZvcmNlIHRoZQp0cmFuc2FjdGlvbiBibG9jayByZXN0cmlj
dGlvbiBlYXJseS4gVGhpcyBwcmV2ZW50cyB0aGUgdXNlciBmcm9tIGZpeGluZwphIG1pc3Npbmcg
dGFibGUgZXJyb3Igb25seSB0byBpbW1lZGlhdGVseSBoaXQgYSB0cmFuc2FjdGlvbiBibG9jayBl
cnJvciwKYW5kIGFsc28gZW5zdXJlcyBjb25zaXN0ZW5jeSB3aXRoIHJlc3Qgb2YgdGhlIGNvbW1h
bmRzLgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL2NsdXN0ZXIuYyB8IDI3ICsrKysrKysrKysr
KysrLS0tLS0tLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEzIGRl
bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NsdXN0ZXIuYyBi
L3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NsdXN0ZXIuYwppbmRleCA3N2MyMDZmZjk0NC4uNmQ5M2Iy
MWRmMGEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL2NsdXN0ZXIuYworKysgYi9z
cmMvYmFja2VuZC9jb21tYW5kcy9jbHVzdGVyLmMKQEAgLTM4NCw2ICszODQsMjAgQEAgRXhlY1Jl
cGFjayhQYXJzZVN0YXRlICpwc3RhdGUsIFJlcGFja1N0bXQgKnN0bXQsIGJvb2wgaXNUb3BMZXZl
bCkKIAkJCQkJcGFyc2VyX2VycnBvc2l0aW9uKHBzdGF0ZSwgb3B0LT5sb2NhdGlvbikpOwogCX0K
IAorCWlmIChwYXJhbXMub3B0aW9ucyAmIENMVU9QVF9DT05DVVJSRU5UKQorCXsKKwkJLyoKKwkJ
ICogTWFrZSBzdXJlIHdlIGhhdmUgbm8gWElEIGFzc2lnbmVkLCBvdGhlcndpc2UgY2FsbCBvZgor
CQkgKiByZXBhY2tfc2V0dXBfbG9naWNhbF9kZWNvZGluZygpIGNhbiBjYXVzZSBhIGRlYWRsb2Nr
LgorCQkgKgorCQkgKiBUaGUgZXhpc3RlbmNlIG9mIHRyYW5zYWN0aW9uIGJsb2NrIGFjdHVhbGx5
IGRvZXMgbm90IGltcGx5IHRoYXQgWElECisJCSAqIHdhcyBhbHJlYWR5IGFzc2lnbmVkLCBidXQg
aXQgdmVyeSBsaWtlbHkgaXMuIFdlIG1pZ2h0IHdhbnQgdG8gY2hlY2sKKwkJICogdGhlIHJlc3Vs
dCBvZiBHZXRDdXJyZW50VHJhbnNhY3Rpb25JZElmQW55KCkgaW5zdGVhZCwgYnV0IHRoYXQKKwkJ
ICogd291bGQgYmUgbGVzcyBjbGVhciBmcm9tIHVzZXIncyBwZXJzcGVjdGl2ZS4KKwkJICovCisJ
CVByZXZlbnRJblRyYW5zYWN0aW9uQmxvY2soaXNUb3BMZXZlbCwgIlJFUEFDSyAoQ09OQ1VSUkVO
VExZKSIpOworCX0KKwogCS8qCiAJICogRGV0ZXJtaW5lIHRoZSBsb2NrIG1vZGUgZXhwZWN0ZWQg
YnkgY2x1c3Rlcl9yZWwoKS4KIAkgKgpAQCAtNjA4LDIwICs2MjIsNyBAQCBjbHVzdGVyX3JlbChS
ZXBhY2tDb21tYW5kIGNtZCwgUmVsYXRpb24gT2xkSGVhcCwgT2lkIGluZGV4T2lkLAogCiAJLyog
VGhlcmUgYXJlIHNwZWNpZmljIHJlcXVpcmVtZW50cyBvbiBjb25jdXJyZW50IHByb2Nlc3Npbmcu
ICovCiAJaWYgKGNvbmN1cnJlbnQpCi0JewotCQkvKgotCQkgKiBNYWtlIHN1cmUgd2UgaGF2ZSBu
byBYSUQgYXNzaWduZWQsIG90aGVyd2lzZSBjYWxsIG9mCi0JCSAqIHJlcGFja19zZXR1cF9sb2dp
Y2FsX2RlY29kaW5nKCkgY2FuIGNhdXNlIGEgZGVhZGxvY2suCi0JCSAqCi0JCSAqIFRoZSBleGlz
dGVuY2Ugb2YgdHJhbnNhY3Rpb24gYmxvY2sgYWN0dWFsbHkgZG9lcyBub3QgaW1wbHkgdGhhdCBY
SUQKLQkJICogd2FzIGFscmVhZHkgYXNzaWduZWQsIGJ1dCBpdCB2ZXJ5IGxpa2VseSBpcy4gV2Ug
bWlnaHQgd2FudCB0byBjaGVjawotCQkgKiB0aGUgcmVzdWx0IG9mIEdldEN1cnJlbnRUcmFuc2Fj
dGlvbklkSWZBbnkoKSBpbnN0ZWFkLCBidXQgdGhhdAotCQkgKiB3b3VsZCBiZSBsZXNzIGNsZWFy
IGZyb20gdXNlcidzIHBlcnNwZWN0aXZlLgotCQkgKi8KLQkJUHJldmVudEluVHJhbnNhY3Rpb25C
bG9jayhpc1RvcExldmVsLCAiUkVQQUNLIChDT05DVVJSRU5UTFkpIik7Ci0KIAkJY2hlY2tfcmVw
YWNrX2NvbmN1cnJlbnRseV9yZXF1aXJlbWVudHMoT2xkSGVhcCwgJmlkZW50X2lkeCk7Ci0JfQog
CiAJLyogQ2hlY2sgZm9yIHVzZXItcmVxdWVzdGVkIGFib3J0LiAqLwogCUNIRUNLX0ZPUl9JTlRF
UlJVUFRTKCk7Ci0tIAoyLjQzLjAKCg==
--000000000000059e13064e05dd76--