MIME-Version: 1.0
References: 
 <CAKYtNApkh=Vy2DpNRCnEJmPpxNuksbAh_QBav=2fLmVjBhGwFw@mail.gmail.com>
 <CAKYtNApxyeeQbjxjFCgHwuv0T2TJvFaU6QSQaMU_yr1nP4Y8Fg@mail.gmail.com>
In-Reply-To: 
 <CAKYtNApxyeeQbjxjFCgHwuv0T2TJvFaU6QSQaMU_yr1nP4Y8Fg@mail.gmail.com>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Sun, 15 Mar 2026 19:14:57 +0530
Message-ID: 
 <CAFC+b6op5Y6CbAqSmUUPj-0z8=A7QR93Vppv4ko1wLqftY+GjA@mail.gmail.com>
Subject: Re: pg_restore --format= option(without any value) should report an
 error as pg_dump is reporting an error
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000007e8dca064d104f85"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6op5Y6CbAqSmUUPj-0z8%3DA7QR93Vppv4ko1wLqftY%2BGjA%40mail.gmail.com>
Precedence: bulk

--0000000000007e8dca064d104f85
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 15, 2026 at 9:48=E2=80=AFAM Mahendra Singh Thalor <mahi6run@gma=
il.com>
wrote:

> On Sun, 13 Apr 2025 at 18:32, Mahendra Singh Thalor <mahi6run@gmail.com>
> wrote:
> >
> > Hi,
> > With "pg_restore --format=3D", we are not giving any error because in
> code, we are checking length of arg but pg_dump is reporting an error for
> the same option.
> >
> > For the consistency purpose, pg_dump and pg_restore both should report
> an error for the test case below.
> >
> > Ex: (output after this patch)but before this patch, below command is
> passing.
> > /pg_restore  x1 -d postgres -j 10 -C --verbose --format=3D
> > pg_restore: error: unrecognized archive format ""; please specify "c",
> "d", or "t"
> >
> > Here, I am attaching a patch which is fixing the same. I added 2 TAP
> tests also for invalid options.
> >
> > Note: We have 2 more options in pg_restore code which validate the
> option if arg has non zero length. I will prepare patches for both(--host
> and --port). We need to add some validate function also for both these
> options.
> >
> > --
> > Thanks and Regards
> > Mahendra Singh Thalor
> > EnterpriseDB: http://www.enterprisedb.com
>
> Hi all,
> Here I am attaching a re-based patch.
>
> I think we should sync behaviour with pg_dump and pg_restore. Please
> review this patch and let me know feedback.
>

+1 , patch LGTM, i think this also needs backpatching,
but i think in the TAP test, change the test_name from pg_dump to
pg_restore.

diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.p=
l
index bf661910c66..3914fb158c2 100755
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -204,12 +204,12 @@ command_fails_like(
 command_fails_like(
        [ 'pg_restore', '-f -', '--format=3D'],
        qr/\Qpg_restore: error: unrecognized archive format "";\E/,
-       'pg_dump: unrecognized archive format empty string');
+       'pg_restore: unrecognized archive format empty string');

 command_fails_like(
        [ 'pg_restore', '-f -', '-F', 'p' ],
        qr/\Qpg_restore: error: archive format "p" is not supported; please
use psql\E/,
-       'pg_dump: unrecognized archive format p|plain');
+       'pg_restore: unrecognized archive format p|plain');

 command_fails_like(
        [ 'pg_dump', '--on-conflict-do-nothing' ],


--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--0000000000007e8dca064d104f85
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 15,=
 2026 at 9:48=E2=80=AFAM Mahendra Singh Thalor &lt;<a href=3D"mailto:mahi6r=
un@gmail.com">mahi6run@gmail.com</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">On Sun, 13 Apr 2025 at 18:32, Mahendra Sin=
gh Thalor &lt;<a href=3D"mailto:mahi6run@gmail.com" target=3D"_blank">mahi6=
run@gmail.com</a>&gt; wrote:<br>
&gt;<br>
&gt; Hi,<br>
&gt; With &quot;pg_restore --format=3D&quot;, we are not giving any error b=
ecause in code, we are checking length of arg but pg_dump is reporting an e=
rror for the same option.<br>
&gt;<br>
&gt; For the consistency purpose, pg_dump and pg_restore both should report=
 an error for the test case below.<br>
&gt;<br>
&gt; Ex: (output after this patch)but before this patch, below command is p=
assing.<br>
&gt; /pg_restore=C2=A0 x1 -d postgres -j 10 -C --verbose --format=3D<br>
&gt; pg_restore: error: unrecognized archive format &quot;&quot;; please sp=
ecify &quot;c&quot;, &quot;d&quot;, or &quot;t&quot;<br>
&gt;<br>
&gt; Here, I am attaching a patch which is fixing the same. I added 2 TAP t=
ests also for invalid options.<br>
&gt;<br>
&gt; Note: We have 2 more options in pg_restore code which validate the opt=
ion if arg has non zero length. I will prepare patches for both(--host and =
--port). We need to add some validate function also for both these options.=
<br>
&gt;<br>
&gt; --<br>
&gt; Thanks and Regards<br>
&gt; Mahendra Singh Thalor<br>
&gt; EnterpriseDB: <a href=3D"http://www.enterprisedb.com" rel=3D"noreferre=
r" target=3D"_blank">http://www.enterprisedb.com</a><br>
<br>
Hi all,<br>
Here I am attaching a re-based patch.<br>
<br>
I think we should sync behaviour with pg_dump and pg_restore. Please<br>
review this patch and let me know feedback.<br>
</blockquote></div><div><br>+1 , patch LGTM, i think this also needs backpa=
tching,<br>but i think in the TAP test, change the test_name from pg_dump t=
o pg_restore.<br><br>diff --git a/src/bin/pg_dump/t/<a href=3D"http://001_b=
asic.pl">001_basic.pl</a> b/src/bin/pg_dump/t/<a href=3D"http://001_basic.p=
l">001_basic.pl</a><br>index bf661910c66..3914fb158c2 100755<br>--- a/src/b=
in/pg_dump/t/<a href=3D"http://001_basic.pl">001_basic.pl</a><br>+++ b/src/=
bin/pg_dump/t/<a href=3D"http://001_basic.pl">001_basic.pl</a><br>@@ -204,1=
2 +204,12 @@ command_fails_like(<br>=C2=A0command_fails_like(<br>=C2=A0 =C2=
=A0 =C2=A0 =C2=A0 [ &#39;pg_restore&#39;, &#39;-f -&#39;, &#39;--format=3D&=
#39;],<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 qr/\Qpg_restore: error: unrecognized =
archive format &quot;&quot;;\E/,<br>- =C2=A0 =C2=A0 =C2=A0 &#39;pg_dump: un=
recognized archive format empty string&#39;);<br>+ =C2=A0 =C2=A0 =C2=A0 =
9;pg_restore: unrecognized archive format empty string&#39;);<br>=C2=A0<br>=
=C2=A0command_fails_like(<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 [ &#39;pg_restore&=
#39;, &#39;-f -&#39;, &#39;-F&#39;, &#39;p&#39; ],<br>=C2=A0 =C2=A0 =C2=A0 =
=C2=A0 qr/\Qpg_restore: error: archive format &quot;p&quot; is not supporte=
d; please use psql\E/,<br>- =C2=A0 =C2=A0 =C2=A0 &#39;pg_dump: unrecognized=
 archive format p|plain&#39;);<br>+ =C2=A0 =C2=A0 =C2=A0 &#39;pg_restore: u=
nrecognized archive format p|plain&#39;);<br>=C2=A0<br>=C2=A0command_fails_=
like(<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 [ &#39;pg_dump&#39;, &#39;--on-conflic=
t-do-nothing&#39; ],<br><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34)">Thanks,</spa=
n><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,34,34)">Sri=
nath Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34)"><span style=
=3D"color:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://www.enterprise=
db.com/" style=3D"color:rgb(17,85,204)" target=3D"_blank">https://www.enter=
prisedb.com/</a></div></div></div>

--0000000000007e8dca064d104f85--