MIME-Version: 1.0
References: 
 <CAKYtNArrHiJ0LDB9BFZiUWs6tC78QkBN50wiwO07WhxewYDS3Q@mail.gmail.com>
In-Reply-To: 
 <CAKYtNArrHiJ0LDB9BFZiUWs6tC78QkBN50wiwO07WhxewYDS3Q@mail.gmail.com>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Sun, 15 Mar 2026 11:44:50 +0530
Message-ID: 
 <CAFC+b6pOQ3HZMVQu43jZo-pA7+Y+ndPprKa5jV6CQoug3xcs1Q@mail.gmail.com>
Subject: Re: bug: pg_dumpall with --data-only and --clean options is giving an
 error after some dump
To: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Type: multipart/alternative; boundary="000000000000c9e9c6064d0a0590"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6pOQ3HZMVQu43jZo-pA7%2BY%2BndPprKa5jV6CQoug3xcs1Q%40mail.gmail.com>
Precedence: bulk

--000000000000c9e9c6064d0a0590
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hello,

On Sun, Mar 15, 2026 at 12:49=E2=80=AFAM Mahendra Singh Thalor <mahi6run@gm=
ail.com>
wrote:

> Hi all,
>
> I was doing some tests with pg_dump, pg_dumpall and pg_restore tools. Wit=
h
> "pg_dumpall --data-only --clean", we are reporting an error after dumping
> some data.
>
> Please see the example below.
>
> ./pg_dumpall --data-only --clean
>> --
>> -- PostgreSQL database cluster dump
>> --
>>
>> \restrict ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWM=
Y
>>
>> SET default_transaction_read_only =3D off;
>>
>> SET client_encoding =3D 'UTF8';
>> SET standard_conforming_strings =3D on;
>>
>> \unrestrict
>> ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccKbXG8q6PI4RB69Dd8KaqcWMY
>>
>> --
>> -- Databases
>> --
>>
>> --
>> -- Database "template1" dump
>> --
>>
>> pg_dump: error: options -c/--clean and -a/--data-only cannot be used
>> together
>> pg_dumpall: error: pg_dump failed on database "template1", exiting
>>
>>
> Error is coming from pg_dump but it should come from pg_dumpall without
> any dump.
>
> Here, I am attaching a patch to fix this problem. Please review this.
>

+1 for the fix , as it immediately throws an error in pg_dumpall itself,
instead of going through all the way until pg_dump and then finding
out it's not a correct combination of options.

I have reviewed,tested the patch , except these it LGTM.
1) maybe match the pg_dumpall comment with the pg_dump comment.
2) please fix the indentation using pgindent

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 47a062d0160..b47e683e1d4 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -455,9 +455,9 @@ main(int argc, char *argv[])
                                                schema_only,
"-s/--schema-only",
                                                tablespaces_only,
"-t/--tablespaces-only");

-       /* --clean and --data-only are incompatible */
+       /* --clean is incompatible with --data-only */
        check_mut_excl_opts(output_clean, "-c/--clean",
-                       data_only, "-a/--data-only");
+                                               data_only,
"-a/--data-only");

        if (if_exists && !output_clean)
                pg_fatal("option %s requires option %s",

--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--000000000000c9e9c6064d0a0590
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hello,</div><br><div class=3D"gmail_quote=
 gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Mar 1=
5, 2026 at 12:49=E2=80=AFAM Mahendra Singh Thalor &lt;<a href=3D"mailto:mah=
i6run@gmail.com">mahi6run@gmail.com</a>&gt; wrote:<br></div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"><div>Hi all,</div><div>=
<br></div><div>I was doing some tests with pg_dump, pg_dumpall and pg_resto=
re tools. With &quot;pg_dumpall --data-only --clean&quot;, we are reporting=
 an error after dumping some data.</div><div><br></div><div>Please see the =
example below.</div><div><br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex">./pg_dumpall --data-only --clean<br>--<br>-- PostgreSQL database=
 cluster dump<br>--<br><br>\restrict ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDc=
cKbXG8q6PI4RB69Dd8KaqcWMY<br><br>SET default_transaction_read_only =3D off;=
<br><br>SET client_encoding =3D &#39;UTF8&#39;;<br>SET standard_conforming_=
strings =3D on;<br><br>\unrestrict ZQDDv56JBW8CVfkLsRDeyRpBvDGYUeqhZbJkDccK=
bXG8q6PI4RB69Dd8KaqcWMY<br><br>--<br>-- Databases<br>--<br><br>--<br>-- Dat=
abase &quot;template1&quot; dump<br>--<br><br>pg_dump: error: options -c/--=
clean and -a/--data-only cannot be used together<br>pg_dumpall: error: pg_d=
ump failed on database &quot;template1&quot;, exiting<br><br></blockquote><=
div><br></div><div>Error is coming from pg_dump but it should come from pg_=
dumpall without any=C2=A0dump.</div><div><br></div><div>Here, I am attachin=
g a patch to fix this problem. Please review this.</div></div></blockquote>=
<div><br>+1 for the fix , as it immediately throws an error in pg_dumpall i=
tself,<br>instead of going through all the way until pg_dump and then findi=
ng<br>out it&#39;s not a correct combination of options.<br><br>I have revi=
ewed,tested the patch , except these it LGTM.<br>1) maybe match the pg_dump=
all comment with the pg_dump comment.<br>2) please fix the indentation usin=
g pgindent<br><br>diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_du=
mp/pg_dumpall.c<br>index 47a062d0160..b47e683e1d4 100644<br>--- a/src/bin/p=
g_dump/pg_dumpall.c<br>+++ b/src/bin/pg_dump/pg_dumpall.c<br>@@ -455,9 +455=
,9 @@ main(int argc, char *argv[])<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 schema_only, &q=
uot;-s/--schema-only&quot;,<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 tablespaces_only, &quo=
t;-t/--tablespaces-only&quot;);<br>=C2=A0<br>- =C2=A0 =C2=A0 =C2=A0 /* --cl=
ean and --data-only are incompatible */<br>+ =C2=A0 =C2=A0 =C2=A0 /* --clea=
n is incompatible with --data-only */<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 check_=
mut_excl_opts(output_clean, &quot;-c/--clean&quot;,<br>- =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data_only, &quo=
t;-a/--data-only&quot;);<br>+ =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 data_only, &quot;-a/--data-only&q=
uot;);<br>=C2=A0<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (if_exists &amp;&amp; !o=
utput_clean)<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pg_=
fatal(&quot;option %s requires option %s&quot;,</div></div><div><br></div><=
span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34)">T=
hanks,</span><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,=
34,34)">Srinath Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34)"><=
span style=3D"color:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://www.=
enterprisedb.com/" style=3D"color:rgb(17,85,204)" target=3D"_blank">https:/=
/www.enterprisedb.com/</a></div></div></div>

--000000000000c9e9c6064d0a0590--