MIME-Version: 1.0
References: 
 <CAHGQGwHhpizYzMo3nFP4GkNMueSNMY3QfC-gBN1VTXtuiANDvw@mail.gmail.com>
 <CAFC+b6qaCMoO7JZUx-etHJhinvPpQow8GKXZDXFfrCydeDtAdQ@mail.gmail.com>
 <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com>
In-Reply-To: 
 <CAHGQGwHz8aOjPbJd+mCb=OuYdfZQ-RkeatuQrfDCE4cqJxt69w@mail.gmail.com>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Mon, 18 May 2026 17:29:34 +0530
Message-ID: 
 <CAFC+b6pZ4UgAfpM_xhyPAyr6PtKbuvKt=7Gb1NDZrTT6QZxOjQ@mail.gmail.com>
Subject: Re: pg_recvlogical: honor source cluster file permissions for output
 files
To: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/alternative; boundary="0000000000006ab38a0652164c6a"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6pZ4UgAfpM_xhyPAyr6PtKbuvKt%3D7Gb1NDZrTT6QZxOjQ%40mail.gmail.com>
Precedence: bulk

--0000000000006ab38a0652164c6a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, May 18, 2026 at 4:17=E2=80=AFPM Fujii Masao <masao.fujii@gmail.com>=
 wrote:

>
>
> The test you added checks that pg_recvlogical creates output files with
> mode 0640 when the cluster is initialized with group access enabled.
> However, it does not check the opposite case, i.e., that pg_recvlogical
> creates output files with mode 0600 when group access is disabled.
>
> It seems we should test both cases, similar to what 010_basebackup.pl
> does?
>
> As far as I can tell, 010_basebackup.pl initializes the cluster without
> group
> access and checks the backup permissions, then enables group access using
> chmod_recursive() and verifies that group permissions are also applied to
> the backup. I updated the TAP test following this approach and attached
> a revised patch.
>

+1 , I totally missed this case :), patch LGTM.


>
> I'm currently thinking of backpatching the fix itself to all supported
> branches,
> but adding the test only to master. Because it does not seem worthwhile t=
o
> spend much time backporting the test to older branches, where the test co=
de
> differs much from master. Thought?
>

makes sense.


--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--0000000000006ab38a0652164c6a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote g=
mail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On Mon, May 18,=
 2026 at 4:17=E2=80=AFPM Fujii Masao &lt;<a href=3D"mailto:masao.fujii@gmai=
l.com">masao.fujii@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"g=
mail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204=
,204,204);padding-left:1ex"><br>
<br>
The test you added checks that pg_recvlogical creates output files with<br>
mode 0640 when the cluster is initialized with group access enabled.<br>
However, it does not check the opposite case, i.e., that pg_recvlogical<br>
creates output files with mode 0600 when group access is disabled.<br>
<br>
It seems we should test both cases, similar to what <a href=3D"http://010_b=
asebackup.pl" rel=3D"noreferrer" target=3D"_blank">010_basebackup.pl</a> do=
es?<br>
<br>
As far as I can tell, <a href=3D"http://010_basebackup.pl" rel=3D"noreferre=
r" target=3D"_blank">010_basebackup.pl</a> initializes the cluster without =
group<br>
access and checks the backup permissions, then enables group access using<b=
r>
chmod_recursive() and verifies that group permissions are also applied to<b=
r>
the backup. I updated the TAP test following this approach and attached<br>
a revised patch.<br></blockquote><div><br>+1 , I totally missed this case :=
), patch LGTM.<br>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:=
1ex"><br>
I&#39;m currently thinking of backpatching the fix itself to all supported =
branches,<br>
but adding the test only to master. Because it does not seem worthwhile to<=
br>
spend much time backporting the test to older branches, where the test code=
<br>
differs much from master. Thought?<br></blockquote><div><br>makes sense.=C2=
=A0</div></div><div><br clear=3D"all"></div><div><br></div><span class=3D"g=
mail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_signat=
ure"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34)">Thanks,</span><br=
 style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,34,34)">Srinath =
Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34)"><span style=3D"co=
lor:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://www.enterprisedb.com=
/" style=3D"color:rgb(17,85,204)" target=3D"_blank">https://www.enterprised=
b.com/</a></div></div></div>

--0000000000006ab38a0652164c6a--