MIME-Version: 1.0
References: <202603242222.5i7awkn7jpdr@alvherre.pgsql>
 <23099.1774429249@localhost>
In-Reply-To: <23099.1774429249@localhost>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Wed, 25 Mar 2026 21:22:16 +0530
Message-ID: 
 <CAFC+b6q6EsNqZ4+QugmMugbGChuJfu4HorJ3hZ0f6cyxCAxFgQ@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Antonin Houska <ah@cybertec.at>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Content-Type: multipart/mixed; boundary="00000000000042ad3e064ddb4105"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6q6EsNqZ4%2BQugmMugbGChuJfu4HorJ3hZ0f6cyxCAxFgQ%40mail.gmail.com>
Precedence: bulk

--00000000000042ad3e064ddb4105
Content-Type: multipart/alternative; boundary="00000000000042ad3d064ddb4103"

--00000000000042ad3d064ddb4103
Content-Type: text/plain; charset="UTF-8"

Hello,

While reviewing/testing V44 patch set , i found that if we run REPACK
(CONCURRENTLY)
without a table name inside a transaction block throws the error "REPACK
CONCURRENTLY requires explicit
table name" instead of the expected transaction block error. This occurs
because ExecRepack() validates the parsed options and missing relation
before verifying the transaction state.

I attached a patch below to maintain consistency with other commands like
VACUUM, REINDEX , and more
and also not to confuse the user , because if user runs REPACK
(CONCURRENTLY)
without a table name inside a transaction block, if user gets "REPACK
CONCURRENTLY requires explicit
table name" and then to correct the mistake the user gives table and again
runs the in
transaction block , just to find out a new error "cannot run inside a
transaction block".

psql (19devel)
Type "help" for help.

postgres=# BEGIN;
SET TRANSACTION READ ONLY;
BEGIN
SET
postgres=*# REPACK (concurrently);
ERROR:  REPACK CONCURRENTLY requires explicit table name

psql (19devel)
Type "help" for help.

postgres=# BEGIN;
SET TRANSACTION READ ONLY;
BEGIN
SET
postgres=*# REPACK (concurrently) stress_victim;
ERROR:  REPACK (CONCURRENTLY) cannot run inside a transaction block

After the fix:

psql (19devel)
Type "help" for help.

postgres=# BEGIN;
SET TRANSACTION READ ONLY;
BEGIN
SET
postgres=*# REPACK (concurrently);
ERROR:  REPACK (CONCURRENTLY) cannot run inside a transaction block

Thoughts?

-- 
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--00000000000042ad3d064ddb4103
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hello,</div><div class=3D"gmail_quote gma=
il_quote_container"><div class=3D"gmail_attr"><br>While reviewing/testing V=
44 patch set , i found that if we run REPACK (CONCURRENTLY)<br>without a ta=
ble name inside a transaction block throws the error &quot;REPACK CONCURREN=
TLY requires explicit</div>table name&quot; instead of the expected transac=
tion block error. This occurs<br>because ExecRepack() validates the parsed =
options and missing relation<br>before verifying the transaction state.<br>=
<br>I attached a patch below to maintain consistency with other commands li=
ke VACUUM, REINDEX , and more<br>and also not to confuse the user , because=
 if user runs REPACK (CONCURRENTLY)</div>without a table name inside a tran=
saction block, if user gets &quot;REPACK CONCURRENTLY requires explicit<br>=
table name&quot; and then to correct the mistake the user gives table and a=
gain runs the in<br>transaction block , just to find out a new error &quot;=
cannot run inside a transaction block&quot;.<br><br>psql (19devel)<br>Type =
&quot;help&quot; for help.<br><br>postgres=3D# BEGIN;<br>SET TRANSACTION RE=
AD ONLY;<br>BEGIN<br>SET<br>postgres=3D*# REPACK (concurrently);<br>ERROR: =
=C2=A0REPACK CONCURRENTLY requires explicit table name<br><br>psql (19devel=
)<br>Type &quot;help&quot; for help.<br><br>postgres=3D# BEGIN; =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>SET TRANSACTION READ ONLY;=
<br>BEGIN<br>SET<br>postgres=3D*# REPACK (concurrently) stress_victim;<br>E=
RROR: =C2=A0REPACK (CONCURRENTLY) cannot run inside a transaction block<br>=
<br>After the fix:<br><br>psql (19devel)<br>Type &quot;help&quot; for help.=
<br><br>postgres=3D# BEGIN; =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=
=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<br>SET T=
RANSACTION READ ONLY;<br>BEGIN<br>SET<br>postgres=3D*# REPACK (concurrently=
);<br>ERROR: =C2=A0REPACK (CONCURRENTLY) cannot run inside a transaction bl=
ock<br><br>Thoughts?<br><div><br></div><span class=3D"gmail_signature_prefi=
x">-- </span><br><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr=
"><span style=3D"color:rgb(34,34,34)">Thanks,</span><br style=3D"color:rgb(=
34,34,34)"><span style=3D"color:rgb(34,34,34)">Srinath Reddy Sadipiralla</s=
pan><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,34,34)">E=
DB:=C2=A0</span><a href=3D"https://www.enterprisedb.com/" style=3D"color:rg=
b(17,85,204)" target=3D"_blank">https://www.enterprisedb.com/</a></div></di=
v></div>

--00000000000042ad3d064ddb4103--

--00000000000042ad3e064ddb4105
Content-Type: application/octet-stream;
	name="0001-Check-for-transaction-block-early-in-ExecRepack.patch"
Content-Disposition: attachment;
	filename="0001-Check-for-transaction-block-early-in-ExecRepack.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mn681x2d0>
X-Attachment-Id: f_mn681x2d0

RnJvbSA2ZTRkOTQxY2FiYmMxNmM2MGQ3NzgzNDU1NTg2MTIyMDhkNzhkODgxIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTcmluYXRoIFJlZGR5IFNhZGlwaXJhbGxhIDxzcmluYXRoMjEz
M0BnbWFpbC5jb20+CkRhdGU6IFdlZCwgMjUgTWFyIDIwMjYgMjA6NTM6MDkgKzA1MzAKU3ViamVj
dDogW1BBVENIIDEvMV0gQ2hlY2sgZm9yIHRyYW5zYWN0aW9uIGJsb2NrIGVhcmx5IGluIEV4ZWNS
ZXBhY2sKCkN1cnJlbnRseSwgZXhlY3V0aW5nIFJFUEFDSyAoQ09OQ1VSUkVOVExZKSB3aXRob3V0
IGEgdGFibGUgbmFtZSBpbnNpZGUgYQp0cmFuc2FjdGlvbiBibG9jayB0aHJvd3MgdGhlIGVycm9y
ICJSRVBBQ0sgQ09OQ1VSUkVOVExZIHJlcXVpcmVzIGV4cGxpY2l0CnRhYmxlIG5hbWUiIGluc3Rl
YWQgb2YgdGhlIGV4cGVjdGVkIHRyYW5zYWN0aW9uIGJsb2NrIGVycm9yLiBUaGlzIG9jY3Vycwpi
ZWNhdXNlIEV4ZWNSZXBhY2soKSB2YWxpZGF0ZXMgdGhlIHBhcnNlZCBvcHRpb25zIGFuZCBtaXNz
aW5nIHJlbGF0aW9uCmJlZm9yZSB2ZXJpZnlpbmcgdGhlIHRyYW5zYWN0aW9uIHN0YXRlLgoKVGhp
cyBiZWhhdmlvciBpcyBpbmNvbnNpc3RlbnQgd2l0aCBvdGhlciB1dGlsaXR5IGNvbW1hbmRzIGxp
a2UgVkFDVVVNCixSRUlOREVYLCBldGM7IHdoaWNoIGludm9rZSBQcmV2ZW50SW5UcmFuc2FjdGlv
bkJsb2NrKCkgYXQgdGhlIHZlcnkgc3RhcnQKb2YgdGhlaXIgZXhlY3V0aW9uIHRvIHByb3Blcmx5
IHJlamVjdCBleGVjdXRpb24gaW5zaWRlIHVzZXIgdHJhbnNhY3Rpb25zCmJlZm9yZSB2YWxpZGF0
aW5nIHRhcmdldHMuCgpBZGQgUHJldmVudEluVHJhbnNhY3Rpb25CbG9jayB0byB0aGUgdG9wIG9m
IEV4ZWNSZXBhY2soKSB0byBlbmZvcmNlIHRoZQp0cmFuc2FjdGlvbiBibG9jayByZXN0cmljdGlv
biBlYXJseS4gVGhpcyBwcmV2ZW50cyB0aGUgdXNlciBmcm9tIGZpeGluZwphIG1pc3NpbmcgdGFi
bGUgZXJyb3Igb25seSB0byBpbW1lZGlhdGVseSBoaXQgYSB0cmFuc2FjdGlvbiBibG9jayBlcnJv
ciwKYW5kIGFsc28gZW5zdXJlcyBjb25zaXN0ZW5jeSB3aXRoIHJlc3Qgb2YgdGhlIGNvbW1hbmRz
LgotLS0KIHNyYy9iYWNrZW5kL2NvbW1hbmRzL2NsdXN0ZXIuYyB8IDM5ICsrKysrKysrKysrKysr
KysrKystLS0tLS0tLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAx
NyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9jb21tYW5kcy9jbHVzdGVy
LmMgYi9zcmMvYmFja2VuZC9jb21tYW5kcy9jbHVzdGVyLmMKaW5kZXggNDIzY2VhMjZiMGIuLjM4
YzU4ZjZkZjZlIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy9jbHVzdGVyLmMKKysr
IGIvc3JjL2JhY2tlbmQvY29tbWFuZHMvY2x1c3Rlci5jCkBAIC0zNjksNiArMzY5LDI4IEBAIEV4
ZWNSZXBhY2soUGFyc2VTdGF0ZSAqcHN0YXRlLCBSZXBhY2tTdG10ICpzdG10LCBib29sIGlzVG9w
TGV2ZWwpCiAJCQkJCXBhcnNlcl9lcnJwb3NpdGlvbihwc3RhdGUsIG9wdC0+bG9jYXRpb24pKTsK
IAl9CiAKKwlpZiAocGFyYW1zLm9wdGlvbnMgJiBDTFVPUFRfQ09OQ1VSUkVOVCkKKwl7CisJCS8q
CisJCSAqIE1ha2Ugc3VyZSB3ZSdyZSBub3QgaW4gYSB0cmFuc2FjdGlvbiBibG9jay4KKwkJICoK
KwkJICogVGhlIHJlYXNvbiBpcyB0aGF0IHJlcGFja19zZXR1cF9sb2dpY2FsX2RlY29kaW5nKCkg
Y291bGQgZGVhZGxvY2sKKwkJICogaWYgdGhlcmUncyBhbiBYSUQgYWxyZWFkeSBhc3NpZ25lZC4g
IEl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIHJ1biBpbgorCQkgKiBhIHRyYW5zYWN0aW9uIGJsb2Nr
IGlmIHdlIGhhZCBubyBYSUQsIGJ1dCB0aGlzIHJlc3RyaWN0aW9uIGlzCisJCSAqIHNpbXBsZXIg
Zm9yIHVzZXJzIHRvIHVuZGVyc3RhbmQgYW5kIHdlIGRvbid0IGxvc2UgYW55dGhpbmcuCisJCSAq
LworCQlQcmV2ZW50SW5UcmFuc2FjdGlvbkJsb2NrKGlzVG9wTGV2ZWwsICJSRVBBQ0sgKENPTkNV
UlJFTlRMWSkiKTsKKwl9CisJZWxzZQorCXsKKwkJLyoKKwkJICogSW4gb3JkZXIgdG8gYXZvaWQg
aG9sZGluZyBsb2NrcyBmb3IgdG9vIGxvbmcsIHdlIHdhbnQgdG8gcHJvY2VzcworCQkgKiBlYWNo
IHRhYmxlIGluIGl0cyBvd24gdHJhbnNhY3Rpb24uICBUaGlzIGZvcmNlcyB1cyB0byBkaXNhbGxv
dworCQkgKiBydW5uaW5nIGluc2lkZSBhIHVzZXIgdHJhbnNhY3Rpb24gYmxvY2suCisJCSAqLwor
CQlQcmV2ZW50SW5UcmFuc2FjdGlvbkJsb2NrKGlzVG9wTGV2ZWwsIFJlcGFja0NvbW1hbmRBc1N0
cmluZyhzdG10LT5jb21tYW5kKSk7CisJfQorCiAJLyogRGV0ZXJtaW5lIHRoZSBsb2NrIG1vZGUg
dG8gdXNlLiAqLwogCWxvY2ttb2RlID0gUmVwYWNrTG9ja0xldmVsKChwYXJhbXMub3B0aW9ucyAm
IENMVU9QVF9DT05DVVJSRU5UKSAhPSAwKTsKIApAQCAtNDEzLDEzICs0MzUsNiBAQCBFeGVjUmVw
YWNrKFBhcnNlU3RhdGUgKnBzdGF0ZSwgUmVwYWNrU3RtdCAqc3RtdCwgYm9vbCBpc1RvcExldmVs
KQogCQkJCQllcnJtc2coIlJFUEFDSyBDT05DVVJSRU5UTFkgcmVxdWlyZXMgZXhwbGljaXQgdGFi
bGUgbmFtZSIpKTsKIAl9CiAKLQkvKgotCSAqIEluIG9yZGVyIHRvIGF2b2lkIGhvbGRpbmcgbG9j
a3MgZm9yIHRvbyBsb25nLCB3ZSB3YW50IHRvIHByb2Nlc3MgZWFjaAotCSAqIHRhYmxlIGluIGl0
cyBvd24gdHJhbnNhY3Rpb24uICBUaGlzIGZvcmNlcyB1cyB0byBkaXNhbGxvdyBydW5uaW5nCi0J
ICogaW5zaWRlIGEgdXNlciB0cmFuc2FjdGlvbiBibG9jay4KLQkgKi8KLQlQcmV2ZW50SW5UcmFu
c2FjdGlvbkJsb2NrKGlzVG9wTGV2ZWwsIFJlcGFja0NvbW1hbmRBc1N0cmluZyhzdG10LT5jb21t
YW5kKSk7Ci0KIAkvKiBBbHNvLCB3ZSBuZWVkIGEgbWVtb3J5IGNvbnRleHQgdG8gaG9sZCBvdXIg
bGlzdCBvZiByZWxhdGlvbnMgKi8KIAlyZXBhY2tfY29udGV4dCA9IEFsbG9jU2V0Q29udGV4dENy
ZWF0ZShQb3J0YWxDb250ZXh0LAogCQkJCQkJCQkJCSAgICJSZXBhY2siLApAQCAtNjA1LDE2ICs2
MjAsNiBAQCBjbHVzdGVyX3JlbChSZXBhY2tDb21tYW5kIGNtZCwgUmVsYXRpb24gT2xkSGVhcCwg
T2lkIGluZGV4T2lkLAogCSAqLwogCWlmIChjb25jdXJyZW50KQogCXsKLQkJLyoKLQkJICogTWFr
ZSBzdXJlIHdlJ3JlIG5vdCBpbiBhIHRyYW5zYWN0aW9uIGJsb2NrLgotCQkgKgotCQkgKiBUaGUg
cmVhc29uIGlzIHRoYXQgcmVwYWNrX3NldHVwX2xvZ2ljYWxfZGVjb2RpbmcoKSBjb3VsZCBkZWFk
bG9jawotCQkgKiBpZiB0aGVyZSdzIGFuIFhJRCBhbHJlYWR5IGFzc2lnbmVkLiAgSXQgd291bGQg
YmUgcG9zc2libGUgdG8gcnVuIGluCi0JCSAqIGEgdHJhbnNhY3Rpb24gYmxvY2sgaWYgd2UgaGFk
IG5vIFhJRCwgYnV0IHRoaXMgcmVzdHJpY3Rpb24gaXMKLQkJICogc2ltcGxlciBmb3IgdXNlcnMg
dG8gdW5kZXJzdGFuZCBhbmQgd2UgZG9uJ3QgbG9zZSBhbnl0aGluZy4KLQkJICovCi0JCVByZXZl
bnRJblRyYW5zYWN0aW9uQmxvY2soaXNUb3BMZXZlbCwgIlJFUEFDSyAoQ09OQ1VSUkVOVExZKSIp
OwotCiAJCWNoZWNrX3JlcGFja19jb25jdXJyZW50bHlfcmVxdWlyZW1lbnRzKE9sZEhlYXAsICZp
ZGVudF9pZHgpOwogCX0KIAotLSAKMi40My4wCgo=
--00000000000042ad3e064ddb4105--