MIME-Version: 1.0
References: <202602241757.6ac3iss2u4vo@alvherre.pgsql>
 <9116.1772009759@localhost>
 <CAFC+b6o2yzA80YmfEhmMO9puN8qvGRvr-15BBLn3UmJxPfpr2w@mail.gmail.com>
 <100248.1772048475@localhost> <4200.1772781295@localhost>
 <29157.1774029970@localhost>
 <46846.1774267234@localhost>
In-Reply-To: <46846.1774267234@localhost>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Thu, 26 Mar 2026 18:49:53 +0530
Message-ID: 
 <CAFC+b6qD+eP=AhA9GeoZS0UafTOcX12Son+S5ZKU-9H5ueGg+w@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Antonin Houska <ah@cybertec.at>
Cc: alvherre@alvh.no-ip.org, Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Content-Type: multipart/alternative; boundary="000000000000214347064ded3e94"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6qD%2BeP%3DAhA9GeoZS0UafTOcX12Son%2BS5ZKU-9H5ueGg%2Bw%40mail.gmail.com>
Precedence: bulk

--000000000000214347064ded3e94
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Antonin,

On Mon, Mar 23, 2026 at 5:30=E2=80=AFPM Antonin Houska <ah@cybertec.at> wro=
te:

>
> I could not resist digging in it deeper :-) Attached is a test that
> reproduces
> the crash - it includes the isolation tester enhancement that I posted
> separately [1]. It crashes reliably with v43 [2] if your fix v43-0005 is
> omitted.
>

+1, i tested the same and yeah it reproduces the crash ,also reviewed
the patch LGTM, except i think you need to add this to makefile, so that a
simple
make check would be enough to run the isolation test, i think this all
makes sense
if this [1] patch goes in.

diff --git a/contrib/test_decoding/Makefile b/contrib/test_decoding/Makefil=
e
index acbcaed2feb..201e3c84cb4 100644
--- a/contrib/test_decoding/Makefile
+++ b/contrib/test_decoding/Makefile
@@ -9,7 +9,10 @@ REGRESS =3D ddl xact rewrite toast permissions
decoding_in_xact \
 ISOLATION =3D mxact delayed_startup ondisk_startup concurrent_ddl_dml \
        oldest_xmin snapshot_transfer subxact_without_top concurrent_stream
\
        twophase_snapshot slot_creation_error catalog_change_snapshot \
-       skip_snapshot_restore invalidation_distribution
parallel_session_origin
+       skip_snapshot_restore invalidation_distribution
parallel_session_origin \
+       filtering
+
+EXTRA_INSTALL =3D src/test/modules/injection_points

 REGRESS_OPTS =3D --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf
 ISOLATION_OPTS =3D --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf

[1] - https://www.postgresql.org/message-id/flat/4703.1774250534%40localhos=
t


--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--000000000000214347064ded3e94
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">Hi=C2=A0Antonin,</div><br><div class=3D"g=
mail_quote gmail_quote_container"><div dir=3D"ltr" class=3D"gmail_attr">On =
Mon, Mar 23, 2026 at 5:30=E2=80=AFPM Antonin Houska &lt;<a href=3D"mailto:a=
h@cybertec.at">ah@cybertec.at</a>&gt; wrote:<br></div><blockquote class=3D"=
gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(20=
4,204,204);padding-left:1ex"><br>
I could not resist digging in it deeper :-) Attached is a test that reprodu=
ces<br>
the crash - it includes the isolation tester enhancement that I posted<br>
separately [1]. It crashes reliably with v43 [2] if your fix v43-0005 is<br=
>
omitted.<br>
</blockquote></div><div><br clear=3D"all"></div><div>+1, i tested the same =
and yeah it reproduces the crash ,also reviewed<br>the patch LGTM, except i=
 think you need to add this to makefile, so that a simple<br>make check wou=
ld be enough to run the isolation test, i think this all makes sense<br>if =
this [1] patch goes in.<br><br>diff --git a/contrib/test_decoding/Makefile =
b/contrib/test_decoding/Makefile<br>index acbcaed2feb..201e3c84cb4 100644<b=
r>--- a/contrib/test_decoding/Makefile<br>+++ b/contrib/test_decoding/Makef=
ile<br>@@ -9,7 +9,10 @@ REGRESS =3D ddl xact rewrite toast permissions deco=
ding_in_xact \<br>=C2=A0ISOLATION =3D mxact delayed_startup ondisk_startup =
concurrent_ddl_dml \<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 oldest_xmin snapshot_tr=
ansfer subxact_without_top concurrent_stream \<br>=C2=A0 =C2=A0 =C2=A0 =C2=
=A0 twophase_snapshot slot_creation_error catalog_change_snapshot \<br>- =
=C2=A0 =C2=A0 =C2=A0 skip_snapshot_restore invalidation_distribution parall=
el_session_origin<br>+ =C2=A0 =C2=A0 =C2=A0 skip_snapshot_restore invalidat=
ion_distribution parallel_session_origin \<br>+ =C2=A0 =C2=A0 =C2=A0 filter=
ing<br>+<br>+EXTRA_INSTALL =3D src/test/modules/injection_points<br>=C2=A0<=
br>=C2=A0REGRESS_OPTS =3D --temp-config $(top_srcdir)/contrib/test_decoding=
/logical.conf<br>=C2=A0ISOLATION_OPTS =3D --temp-config $(top_srcdir)/contr=
ib/test_decoding/logical.conf<br><br>[1] -=C2=A0<a href=3D"https://www.post=
gresql.org/message-id/flat/4703.1774250534%40localhost">https://www.postgre=
sql.org/message-id/flat/4703.1774250534%40localhost</a><br><br><br></div><s=
pan class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=
=3D"gmail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34)">T=
hanks,</span><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb(34,=
34,34)">Srinath Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34)"><=
span style=3D"color:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://www.=
enterprisedb.com/" style=3D"color:rgb(17,85,204)" target=3D"_blank">https:/=
/www.enterprisedb.com/</a></div></div></div>

--000000000000214347064ded3e94--