MIME-Version: 1.0
References: <CAKYtNAp9vOtydXL3_pnGJ+TetZtN=FYSnZSMCqXceU3mkHPxPg@mail.gmail.com>
 <202501110844.5ztsym4vbflm@alvherre.pgsql> <CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com>
 <CACJufxGcZ1rK94cgfdc9McCD7W-83PT9_cx5VoFeC-HVc10Wzg@mail.gmail.com>
 <CAKYtNAqd4k+4+XANxjDc35i+WPme476DkP7msjYpX85F+4UsUg@mail.gmail.com>
 <CAKYtNAobHS158cfmA3X+Zr+oJ1ffNjjn3+BrU4-MokZ16jSVzw@mail.gmail.com>
 <CACJufxEtDgADBXQhX5cp3mJtNVMy+j+Jdovuk3PWe5qJ0sE3Ag@mail.gmail.com>
 <CAKYtNArwUxqR=LkQY1PT7tw+raMhf53oafo4WmSHGPHiER9d=A@mail.gmail.com>
 <CACJufxHUDGWe=2ZukvMfuwEcSK8CsVYm=9+rtPnrW7CRCfoCsw@mail.gmail.com>
 <CACJufxGOy1kAot+SAD9siKB797rj9K-bqeZOrS4fDYFFLo31bA@mail.gmail.com>
 <CAKYtNApE=x0sZxU3c9KqsYRU3dCztcfhQ+CDWhzgtH83HQUkuA@mail.gmail.com>
 <CACJufxHNNjAhVYJQS8x5U-9Fqsj6+tzG4uCivk2XTAOPTmstTA@mail.gmail.com>
 <CACJufxFJ9yJ=+WAHpXbDxf077Xw3O+ZziTwS55+ZK5APJ+6mUg@mail.gmail.com>
 <CACJufxEA-Q2hatN_BLcNrgfo8-4-m102gDdwVp0NTbuM2zyeDA@mail.gmail.com>
 <CAKYtNAqWjU6-J=VA-9-CVDLh7nX_Y_MgdSgyLFb6yYyZ1NYsyg@mail.gmail.com>
 <CACJufxEFxaiqytZRpL0Xbj8_XEtTm8-A2FE6u_9vigGO3z5oZQ@mail.gmail.com>
 <CAKYtNAr732dgvu43vLRBnDK=dPBVWAFBKaCp0982kwp0Yn8DOA@mail.gmail.com>
 <CACJufxGwXjG80LZ4miX+dXaT+3z5Kf1Mf0P_7FnR+641oqfUyg@mail.gmail.com>
 <CACJufxEQUcjBocKJQ0Amf3AfiS9wFB7zYSHrj1qqD_oWeaJoGQ@mail.gmail.com>
 <CAKYtNApzcsV3a_jR6oduA12yKrx=aBv+vcA=RseT-2rLrC2o_g@mail.gmail.com>
 <CAFC+b6p84_wtbviPu-mLNxfOPLozN8OOjWcz_tjoDf=SuVDMTQ@mail.gmail.com>
 <CAFC+b6qJ9BAmN-J2ha-Q08MPbZ2FqTUB++B0ouvSk72px3D-NA@mail.gmail.com>
 <CAKYtNAqsOwq-u-h0+WEm2nonwZD4S=9ri4-d0vhAGjNQZ7FjnQ@mail.gmail.com>
 <CAKYtNAr+YSMu1TkyXzsxtvCMRoya05_=1V_LFKDrL=XpYJ9DxQ@mail.gmail.com>
 <CACJufxGp5p7_7EwNwg-GuKZO+XB9uxfWTZ+QWhhNvwgUF0Vb0w@mail.gmail.com>
 <CACJufxGoUgqv+T1MXuh_SH_FTwTMpqfUcntHP1c5Q7KnyPXgKQ@mail.gmail.com> <CACJufxFWFLZhtgk92HR78tKiYk0yRX-26v2y1eEN2NtjyXtU4A@mail.gmail.com>
In-Reply-To: <CACJufxFWFLZhtgk92HR78tKiYk0yRX-26v2y1eEN2NtjyXtU4A@mail.gmail.com>
From: Srinath Reddy <srinath2133@gmail.com>
Date: Sat, 1 Feb 2025 21:36:29 +0530
Message-ID: <CAFC+b6qnLKSX+rPVVpsSPkAGYA=79_7U1z4C_0oKUw+Cp8zDtw@mail.gmail.com>
Subject: Re: Non-text mode for pg_dumpall
To: Mahendra Singh Thalor <mahi6run@gmail.com>, jian.universality@gmail.com
Cc: pgsql-hackers@lists.postgresql.org
Content-Type: multipart/alternative; boundary="00000000000052ca52062d16d86c"
Archived-At: <https://www.postgresql.org/message-id/CAFC%2Bb6qnLKSX%2BrPVVpsSPkAGYA%3D79_7U1z4C_0oKUw%2BCp8zDtw%40mail.gmail.com>
Precedence: bulk

--00000000000052ca52062d16d86c
Content-Type: text/plain; charset="UTF-8"

Hi,
i think we have to change the pg_dumpall "--help" message similar to
pg_dump's specifying that now pg_dumpall dumps cluster into to other
non-text formats.
Need similar "--help" message change in pg_restore to specify that now
pg_restore supports restoring whole cluster from archive created from
pg_dumpall.

diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
index 3e022ecdeb..728abe841c 100644
--- a/src/bin/pg_dump/pg_dumpall.c
+++ b/src/bin/pg_dump/pg_dumpall.c
@@ -667,7 +667,7 @@ main(int argc, char *argv[])
 static void
 help(void)
 {
- printf(_("%s extracts a PostgreSQL database cluster into an SQL script
file.\n\n"), progname);
+ printf(_("%s extracts a PostgreSQL database cluster into an SQL script
file or to other formats.\n\n"), progname);

diff --git a/src/bin/pg_dump/pg_restore.c b/src/bin/pg_dump/pg_restore.c
index fc248a441e..c4e58c1f3b 100644
--- a/src/bin/pg_dump/pg_restore.c
+++ b/src/bin/pg_dump/pg_restore.c
@@ -582,6 +582,8 @@ static void
 usage(const char *progname)
 {
  printf(_("%s restores a PostgreSQL database from an archive created by
pg_dump.\n\n"), progname);
+ printf(_("[or]\n"));
+ printf(_("%s restores a PostgreSQL entire cluster from an archive created
by pg_dumpall.\n\n"), progname); Regards, Srinath Reddy Sadipiralla, EDB:
https://www.enterprisedb.com <http://www.enterprisedb.com/>

--00000000000052ca52062d16d86c
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi,<br>i think we have to change the pg_dumpall &quot;--he=
lp&quot; message similar to pg_dump&#39;s specifying that now pg_dumpall du=
mps cluster into to other non-text formats.<br>Need similar &quot;--help&qu=
ot; message change in pg_restore to specify that now pg_restore supports re=
storing whole=C2=A0cluster from archive created from pg_dumpall.<br><br>dif=
f --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c<br>in=
dex 3e022ecdeb..728abe841c 100644<br>--- a/src/bin/pg_dump/pg_dumpall.c<br>=
+++ b/src/bin/pg_dump/pg_dumpall.c<br>@@ -667,7 +667,7 @@ main(int argc, ch=
ar *argv[])<br>=C2=A0static void<br>=C2=A0help(void)<br>=C2=A0{<br>-	printf=
(_(&quot;%s extracts a PostgreSQL database cluster into an SQL script file.=
\n\n&quot;), progname);<br>+	printf(_(&quot;%s extracts a PostgreSQL databa=
se cluster into an SQL script file or to other formats.\n\n&quot;), prognam=
e);<br><br><div style=3D"color:rgb(212,212,212);background-color:rgb(30,30,=
30);font-family:Menlo,Monaco,&quot;Courier New&quot;,monospace;font-size:12=
px;line-height:18px;white-space:pre">diff --git a/src/bin/pg_dump/pg_restor=
e.c b/src/bin/pg_dump/pg_restore.c<br>index fc248a441e..c4e58c1f3b 100644<b=
r>--- a/src/bin/pg_dump/pg_restore.c<br>+++ b/src/bin/pg_dump/pg_restore.c<=
br>@@ -582,6 +582,8 @@ static void<br>=C2=A0usage(const char *progname)<br>=
=C2=A0{<br>=C2=A0	printf(_(&quot;%s restores a PostgreSQL database from an =
archive created by pg_dump.\n\n&quot;), progname);<br>+	printf(_(&quot;[or]=
\n&quot;));<br>+	printf(_(&quot;%s restores a PostgreSQL entire cluster fro=
m an archive created by pg_dumpall.\n\n&quot;), progname);

Regards,
Srinath Reddy Sadipiralla,
EDB:<span style=3D"font-family:Arial,Helvetica,sans-serif;font-size:small;c=
olor:rgb(207,203,196)">=C2=A0</span><a href=3D"http://www.enterprisedb.com/=
" rel=3D"noreferrer" target=3D"_blank" style=3D"font-family:Arial,Helvetica=
,sans-serif;font-size:small">https://www.enterprisedb.com</a></div></div>

--00000000000052ca52062d16d86c--