MIME-Version: 1.0
References: <202604031448.3nakw63kxkmr@alvherre.pgsql>
 <202604031922.t6lgu5a2alwo@alvherre.pgsql>
In-Reply-To: <202604031922.t6lgu5a2alwo@alvherre.pgsql>
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
Date: Sat, 4 Apr 2026 18:46:58 +0530
Message-ID: 
 <CAFC+b6r23cpPBsxiJwDJGALkb6yCw=HwT0j0z1pHkyeCFBQbug@mail.gmail.com>
Subject: Re: Adding REPACK [concurrently]
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Antonin Houska <ah@cybertec.at>, Amit Kapila <amit.kapila16@gmail.com>,
	Mihail Nikalayeu <mihailnikalayeu@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>,
 Robert Treat <rob@xzilla.net>
Content-Type: multipart/alternative; boundary="0000000000005bc8f8064ea24067"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFC%2Bb6r23cpPBsxiJwDJGALkb6yCw%3DHwT0j0z1pHkyeCFBQbug%40mail.gmail.com>
Precedence: bulk

--0000000000005bc8f8064ea24067
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Alvaro,

On Sat, Apr 4, 2026 at 1:01=E2=80=AFAM Alvaro Herrera <alvherre@alvh.no-ip.=
org>
wrote:

> On 2026-Apr-03, Alvaro Herrera wrote:
>
> > - I polished the patch to reserve replication slots for REPACK.  Given
> >   the new implementation of 0006 that was submitted implies that we can
> >   now run multiple repacks concurrently, I changed the default of 1 to =
5.
>
> Srinath let me know that this new part was causing CI failures on
> Windows.  This version v51 should be okay (or, at least, it passes for
> me on CI).


yes indeed , TotalMaxReplicationSlots was the culprit , as the window
after getting repack worked was forked , i think this was set back to 0.
Thanks for fixing this with "repack" flag , initially i thought why can't w=
e
go with a macro
#define TotalMaxReplicationSlots (max_replication_slots +
max_repack_replication_slots)
but i thought maybe in future we might need this "repack" flag to add
more slot requirements.

--=20
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

--0000000000005bc8f8064ea24067
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><div>Hi Alvaro,</div><br><div class=3D"gm=
ail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Apr 4, 2026 at 1:0=
1=E2=80=AFAM Alvaro Herrera &lt;<a href=3D"mailto:alvherre@alvh.no-ip.org" =
target=3D"_blank">alvherre@alvh.no-ip.org</a>&gt; wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px =
solid rgb(204,204,204);padding-left:1ex">On 2026-Apr-03, Alvaro Herrera wro=
te:<br>
<br>
&gt; - I polished the patch to reserve replication slots for REPACK.=C2=A0 =
Given<br>
&gt;=C2=A0 =C2=A0the new implementation of 0006 that was submitted implies =
that we can<br>
&gt;=C2=A0 =C2=A0now run multiple repacks concurrently, I changed the defau=
lt of 1 to 5.<br>
<br>
Srinath let me know that this new part was causing CI failures on<br>
Windows.=C2=A0 This version v51 should be okay (or, at least, it passes for=
<br>
me on CI).</blockquote></div><div><br>yes indeed ,=C2=A0TotalMaxReplication=
Slots was the culprit , as the window<br>after getting repack worked was fo=
rked , i think this was set back to 0.<br>Thanks for fixing this with &quot=
;repack&quot; flag , initially i thought why can&#39;t we<br>go with a macr=
o=C2=A0<br>#define TotalMaxReplicationSlots (max_replication_slots + max_re=
pack_replication_slots)<br>but i thought maybe in future we might need this=
 &quot;repack&quot; flag to add<br>more slot requirements.</div><div><br></=
div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" c=
lass=3D"gmail_signature"><div dir=3D"ltr"><span style=3D"color:rgb(34,34,34=
)">Thanks,</span><br style=3D"color:rgb(34,34,34)"><span style=3D"color:rgb=
(34,34,34)">Srinath Reddy Sadipiralla</span><br style=3D"color:rgb(34,34,34=
)"><span style=3D"color:rgb(34,34,34)">EDB:=C2=A0</span><a href=3D"https://=
www.enterprisedb.com/" style=3D"color:rgb(17,85,204)" target=3D"_blank">htt=
ps://www.enterprisedb.com/</a></div></div></div>
</div>

--0000000000005bc8f8064ea24067--