MIME-Version: 1.0
From: Vinod Sridharan <vsridh90@gmail.com>
Date: Thu, 12 Mar 2026 13:26:14 -0700
Message-ID: 
 <CAFMdLD6mQvAuStiOGvBJxAEfo6wdjZhj3+JveTLxOX8MVn4zmA@mail.gmail.com>
Subject: Add a check for interrupts in ginInsert
To: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Content-Type: multipart/mixed; boundary="0000000000003a7c21064cd99197"
Archived-At: 
 <https://www.postgresql.org/message-id/CAFMdLD6mQvAuStiOGvBJxAEfo6wdjZhj3%2BJveTLxOX8MVn4zmA%40mail.gmail.com>
Precedence: bulk

--0000000000003a7c21064cd99197
Content-Type: text/plain; charset="UTF-8"

Hello,
Please find attached a small patch that adds the ability to check for
interrupts during the insert into the GIN index. Currently, ginInsert
can generate a large number of entries for a given input tuple from
extractEntries. In the case of Json/Jsonb for instance, the standard
opclasses may generate 1 term per path & value (which may be large).
During index build, the build process does check for interrupts in
between the inserts of each entry into the index (since there may be a
large number of entries to insert). However, the same loop during
insert was not checking for interrupts. This patch adds an interrupt
check to allow for early termination if the overall request is
abandoned. I believe this should be a safe point for checking for
interrupts since we should not be in the middle of modifying the index
tree in between entries.

Thanks and Regards,
Vinod Sridharan
[Microsoft]

--0000000000003a7c21064cd99197
Content-Type: application/octet-stream;
	name="v1-0001-Check-for-interrupts-during-gin-insert.patch"
Content-Disposition: attachment;
	filename="v1-0001-Check-for-interrupts-during-gin-insert.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_mmnw76iu0>
X-Attachment-Id: f_mmnw76iu0

RnJvbSBmYjI3YWVhYjNlYzI1MDYxY2UwMmNiMGY5Y2EzZWRmOWEwZWUzMjhmIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBWaW5vZCBTcmlkaGFyYW4gPHZzcmlkaDkwQGdtYWlsLmNvbT4K
RGF0ZTogVGh1LCAxMiBNYXIgMjAyNiAxOTozMjowMiArMDAwMApTdWJqZWN0OiBbUEFUQ0ggdjFd
IENoZWNrIGZvciBpbnRlcnJ1cHRzIGR1cmluZyBnaW4gaW5zZXJ0LiBUaGUgR0lOIGluZGV4CiBl
eHRyYWN0RW50cmllcyBjYW4gcHJvZHVjZSBhIGxvdCBvZiB0ZXJtcyBmb3IgYSBnaXZlbiB0dXBs
ZS4gVGhpcyBpcyB0cnVlIGZvcgogb3BjbGFzc2VzIGxpa2UganNvbi9qc29uYiB3aGljaCBjYW4g
aGF2ZSBhIHRlcm0gcGVyIHBhdGggJiB2YWx1ZS4gRHVyaW5nIHRoZQogYnVpbGQgcGhhc2Ugb2Yg
dGhlIGdpbiBpbmRleCwgd2UgZG8gY2hlY2sgZm9yIGludGVycnVwdHMgYW5kIGVuc3VyZSB0aGF0
IHdlCiBjYW4gYmFpbCBpZiB0aGVyZSBhcmUgbWFueSBlbnRyaWVzIGdlbmVyYXRlZC4gSG93ZXZl
ciwgZHVyaW5nIHRoZSBpbnNlcnQKIHBoYXNlLCB0aGlzIGNoZWNrIGRvZXNuJ3QgZXhpc3QgYW5k
IHdlIGNvbnRpbnVlIG9uIGV2ZW4gaWYgdGhlcmUgd2FzIGEKIGNhbmNlbGxhdGlvbi4gVGhpcyBh
ZGRzIGEgY2hlY2sgZm9yIGNhbmNlbGxhdGlvbiBpbiBiZXR3ZWVuIHRlcm1zLiBUaGlzIHNlZW1z
CiBsaWtlIGEgc2FmZSBwbGFjZSB0byBkbyBpdCBzaW5jZSBhdCB0aGlzIHBvaW50LCB3ZSBhcmVu
J3QgaW4gdGhlIG1pZGRsZSBvZgogbW9kaWZpeWluZyB0aGUgaW5kZXggdHJlZS4KCi0tLQogc3Jj
L2JhY2tlbmQvYWNjZXNzL2dpbi9naW5pbnNlcnQuYyB8IDQgKysrKwogMSBmaWxlIGNoYW5nZWQs
IDQgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2FjY2Vzcy9naW4vZ2lu
aW5zZXJ0LmMgYi9zcmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dpbmluc2VydC5jCmluZGV4IGM3ZTM4
ZGJlMTkzLi45N2NlYTVmN2Q0ZSAxMDA2NDQKLS0tIGEvc3JjL2JhY2tlbmQvYWNjZXNzL2dpbi9n
aW5pbnNlcnQuYworKysgYi9zcmMvYmFja2VuZC9hY2Nlc3MvZ2luL2dpbmluc2VydC5jCkBAIC04
NTAsOCArODUwLDEyIEBAIGdpbkhlYXBUdXBsZUluc2VydChHaW5TdGF0ZSAqZ2luc3RhdGUsIE9m
ZnNldE51bWJlciBhdHRudW0sCiAJCQkJCQkJCSZuZW50cmllcywgJmNhdGVnb3JpZXMpOwogCiAJ
Zm9yIChpID0gMDsgaSA8IG5lbnRyaWVzOyBpKyspCisJeworCQkvKiB0aGVyZSBjb3VsZCBiZSBt
YW55IGVudHJpZXMsIHNvIGJlIHdpbGxpbmcgdG8gYWJvcnQgaGVyZSAqLworCQlDSEVDS19GT1Jf
SU5URVJSVVBUUygpOwogCQlnaW5FbnRyeUluc2VydChnaW5zdGF0ZSwgYXR0bnVtLCBlbnRyaWVz
W2ldLCBjYXRlZ29yaWVzW2ldLAogCQkJCQkgICBpdGVtLCAxLCBOVUxMKTsKKwl9CiB9CiAKIGJv
b2wKLS0gCjIuNDMuMAoK
--0000000000003a7c21064cd99197--