MIME-Version: 1.0
References: 
 <CAKz==b+k7OwOib__LgfDadUzW9jFrbQ9FqdERpsufi8d7F=vkQ@mail.gmail.com>
 <CAHut+PuhDwEySMSMz_4hgmFNG75Wx=Wv4guuaUSGi6e3ixsUUw@mail.gmail.com>
 <CAKz==bLEjr+706MkmpHsd1wfz0EqYzEXJVb2cn2mxp2nnHf=kQ@mail.gmail.com>
 <CAFPTHDa-k7qV=H_UgojLs-denk8upJWG7s6xZwD4r4ZTP-=q5Q@mail.gmail.com>
 <CAKz==bLYWG43n6J0Ze1Y5fgyrW32_73WQkNSPbWGmFwLE8Aa0A@mail.gmail.com>
 <CAKz==bKd4jdbMhp5AxSk6R9v1fUubceqoOQ-AGM93gFEdgNWEg@mail.gmail.com>
In-Reply-To: 
 <CAKz==bKd4jdbMhp5AxSk6R9v1fUubceqoOQ-AGM93gFEdgNWEg@mail.gmail.com>
From: Ajin Cherian <itsajin@gmail.com>
Date: Mon, 30 Mar 2026 15:42:48 +1100
Message-ID: 
 <CAFPTHDZNkQEU+5cS5miG9cZ8Ei29uTNJLqj4F9v7SpHYPxTotQ@mail.gmail.com>
Subject: Re: pg_publication_tables: return NULL attnames when no column list
 is specified
To: Roberto Mello <roberto.mello@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Archived-At: 
 <https://www.postgresql.org/message-id/CAFPTHDZNkQEU%2B5cS5miG9cZ8Ei29uTNJLqj4F9v7SpHYPxTotQ%40mail.gmail.com>
Precedence: bulk

On Sat, Mar 28, 2026 at 6:54=E2=80=AFAM Roberto Mello <roberto.mello@gmail.=
com> wrote:
>
> On Fri, Mar 27, 2026 at 11:27=E2=80=AFAM Roberto Mello <roberto.mello@gma=
il.com> wrote:
>>
>> On Thu, Mar 26, 2026 at 10:07=E2=80=AFPM Ajin Cherian <itsajin@gmail.com=
> wrote:
>>>
>>>
>>> One observation from reviewing the patch: the test suite covers the
>>> partial column list and dropped column cases well, but is missing a
>>> test for the two-publication conflict scenario (one pub with no list +
>>> one pub with an explicit list of all columns on the same table). That
>>> is the breaking change called out in the original report and probably
>>> deserves its own regression test with a comment explaining the
>>> expected behavior change for users in that configuration.
>>> Patch LGTM otherwise.
>>
>>
>> Good point. I know I worked on that, so I must have accidentally dropped=
 it from the patch.
>>
>> Will prepare a revision and submit.
>
>
> Here's v3 of the patch with the missing test.

LGTM

regards,
Ajin Cherian
Fujitsu Australia