Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpBHN-001XGN-WE for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Mar 2025 19:16:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tpBHM-00EmQU-K7 for pgsql-hackers@arkaria.postgresql.org; Mon, 03 Mar 2025 19:16:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tpBHM-00EmQM-A4 for pgsql-hackers@lists.postgresql.org; Mon, 03 Mar 2025 19:16:40 +0000 Received: from mail-ua1-x931.google.com ([2607:f8b0:4864:20::931]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tpBHI-000lHI-2s for pgsql-hackers@postgresql.org; Mon, 03 Mar 2025 19:16:39 +0000 Received: by mail-ua1-x931.google.com with SMTP id a1e0cc1a2514c-86b3b60d647so2102686241.3 for ; Mon, 03 Mar 2025 11:16:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741029396; x=1741634196; darn=postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=GCgLYh7UhBUHCE2TZQ0/U9Uox3bgoNFLgXuxdIlc84A=; b=JFnRNRnuyK26y0nrCpWHr3V/Z3rupgP5Ek9H8oeLZCDksLP2EOsKoTTkcTPNrhb5eA ay0pHFwDNyAB8QRA4/Vp7ztCNe1hWhz3IJxKrjpx2B01/V/U+YYga9dQ4cldTInov+z1 olOdeOUqPeT+yx7FJhNb2kMKbJ9yg4q9pbPqM9DRrXKF8+YUtB3jCC/o+altaIFXRzbc TWZ+kEpU55FpLKnnJW6dmXGUiDOq1G9LZZz1eSuTxuDl0cuS3b2SMMC9oI3jE81iV4W3 WT8IizI1cOPHhrKCtKURcOfSZrN3GZxufmsCRc7m48Bp4I24/h31rSHs7LtjeRbiBu06 jXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741029396; x=1741634196; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GCgLYh7UhBUHCE2TZQ0/U9Uox3bgoNFLgXuxdIlc84A=; b=kWXBfotxijhsZaBNAk944KS+DdXkBaWzcNaKrVvc8Ekm77sEv7XaMseTOyo2OlWw54 9Z4uG8VSYhh4ogsaGQhgu8PhBTbtavy8r8GRlfFxecwjhcvu84C3NFkBSaigNw8xTpww uCpGTeP1YqFAcjDZq623SMCODrQbTJGJpzAHzw6uif7ZsEJmht8INT5X82uHLIx/jy2W E5h0L2Zf3ipUIMdXT5J95eLWQdtZaO2g0x0tdgAouoPcpUUcUC8dqBBLsX7zPjkJQP7h NZ3akRNOB874ofZba37LV+gDGeTfQqRUQ8fwhDaLYUqGaPrO7A2U/CnVLXBDy8Vmc4/H YnZA== X-Forwarded-Encrypted: i=1; AJvYcCVpvkgOIV0/dR9DtI55t0jG0J5BnJPfiNFOxQ8+SaPUBuMm/M6vsoEVcqk2bgeuTVGECEYolmpRPlqAnLY1@postgresql.org X-Gm-Message-State: AOJu0YxrwD/+5IUnHmBLUcNGiItWcKHmNRFJPJ7ZYT4U/y4cRj0kgFLh icOewchrR6tWGYjjfnkSlPRm1tWgMc6WQLUdJ6Cm5sEdYs6Ec+5Vb0aX5d+I4GVzR8+lClsJ/96 CXOs5SkjuDplwcwu8m7c45obcWyA= X-Gm-Gg: ASbGnct1NkToOVr1Hx6icUfZph6vD/I+UOUk+YQ928fI4LHgcMk6G5YXRSdHsqFFoSW BvmE4mjCyQLsqZhJjtn8iXyZ0su8AHnKpEyoi2cro3DkupPqEM8wB2TlsyAvajdFTz5JeU/slJz GSVfC3XiUpe3wpQaVoWQ4GLYCT6PpQ0iWysSgHlCz6+7txV1BYtxQWwvuh5ts= X-Google-Smtp-Source: AGHT+IHpT2Gb0mXRKYQuimSDu1GTofIaRDF8bt6LD6SZRxdW+drER9+HOoY3h2G5q2eDLRnVljq94GnB4C81ooxP9Q0= X-Received: by 2002:a05:6102:3f4f:b0:4bb:db41:3b6c with SMTP id ada2fe7eead31-4c04490e8a4mr10164278137.12.1741029396410; Mon, 03 Mar 2025 11:16:36 -0800 (PST) MIME-Version: 1.0 References: <21fa36b4-6d56-4556-b524-9e3955b922c8@eisentraut.org> In-Reply-To: From: Matheus Alcantara Date: Mon, 3 Mar 2025 16:16:09 -0300 X-Gm-Features: AQ5f1JqEXRh_Q348tcMMr3trDO2QXWpyQwLkYtFgJHew7riyjjSo1vhJz4DPcAM Message-ID: Subject: Re: SQL:2023 JSON simplified accessor support To: Alexandra Wang Cc: Peter Eisentraut , Andrew Dunstan , Nikita Glukhov , PostgreSQL Hackers , "David E. Wheeler" , jian he Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Alex, The code comments and the commit messages help a lot when reviewing! Thanks for the new version. The code LGTM and check-world is happy. I've also performed some tests and everything looks good! Just some minor points about this new version: ## v9-0005 Typo on commit message title ## v9-0006 > + * The following functions create various types of JsonPathParseItem nodes, > + * which are used to build JsonPath expressions for jsonb simplified accessor. > Just to avoid misinterpretation I think that we can replace "The following functions" with "The make_jsonpath_item_* functions" since we can have more functions in the future that are not fully related with these. Does that make sense? -- Matheus Alcantara